mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: "benbjiang(蒋彪)" <benbjiang@tencent.com>
Cc: Jiang Biao <benbjiang@gmail.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
	"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"bsegall@google.com" <bsegall@google.com>,
	"mgorman@suse.de" <mgorman@suse.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail)
Date: Tue, 11 Aug 2020 17:54:29 +0200	[thread overview]
Message-ID: <4964e359-afc5-a256-4950-853a9485eeff@arm.com> (raw)
In-Reply-To: <CCA1D942-3669-4216-92BD-768967B1ECE5@tencent.com>

On 11/08/2020 02:41, benbjiang(蒋彪) wrote:
> Hi,
> 
>> On Aug 10, 2020, at 9:24 PM, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>
>> On 06/08/2020 17:52, benbjiang(蒋彪) wrote:
>>> Hi, 
>>>
>>>> On Aug 6, 2020, at 9:29 PM, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>>>
>>>> On 03/08/2020 13:26, benbjiang(蒋彪) wrote:
>>>>>
>>>>>
>>>>>> On Aug 3, 2020, at 4:16 PM, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>>>>>
>>>>>> On 01/08/2020 04:32, Jiang Biao wrote:
>>>>>>> From: Jiang Biao <benbjiang@tencent.com>

[...]

>> Because of this very small weight (weight=3), compared to a SCHED_NORMAL
>> nice 0 task (weight=1024), a SCHED_IDLE task is penalized by a huge
>> se->vruntime value (1024/3 higher than for a SCHED_NORMAL nice 0 task).
>> This should make sure it doesn't tick preempt a SCHED_NORMAL nice 0 task.
> Could you please explain how the huge penalization of vruntime(1024/3) could
> make sure SCHED_IDLE not tick preempting SCHED_NORMAL nice 0 task?
> 
> Thanks a lot.

Trace a run of 2 SCHED_OTHER (nice 0) tasks and 1 SCHED_IDLE task on a
single CPU and trace_printk the conditions  'if (delta < 0)' and ' if
(delta > ideal_runtime)' in check_preempt_tick().

Then do the same with 3 SCHED_OTHER (nice 0) tasks. You can also change
the niceness of the 2 SCHED_OTHER task to 19 to see some differences in
the kernelshark's task layout.

rt-app (https://github.com/scheduler-tools/rt-app) is a nice tool to
craft those artificial use cases.

[...]

  reply	other threads:[~2020-08-11 15:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01  2:32 [PATCH] sched/fair: reduce preemption with IDLE tasks runable Jiang Biao
2020-08-03  8:16 ` Dietmar Eggemann
2020-08-03 11:26   ` [PATCH] sched/fair: reduce preemption with IDLE tasks runable(Internet mail) benbjiang(蒋彪)
2020-08-06 13:29     ` Dietmar Eggemann
2020-08-06 15:52       ` benbjiang(蒋彪)
2020-08-10 13:24         ` Dietmar Eggemann
2020-08-11  0:41           ` benbjiang(蒋彪)
2020-08-11 15:54             ` Dietmar Eggemann [this message]
2020-08-12  3:19               ` benbjiang(蒋彪)
2020-08-12 18:39                 ` Dietmar Eggemann
2020-08-13 23:55                   ` benbjiang(蒋彪)
2020-08-17  8:57                     ` Dietmar Eggemann
2020-08-17 12:05                       ` benbjiang(蒋彪)
2020-08-19 10:46                         ` Dietmar Eggemann
2020-08-19 11:05                           ` Vincent Guittot
2020-08-19 11:55                             ` Dietmar Eggemann
2020-08-19 14:27                               ` benbjiang(蒋彪)
2020-08-19 14:55                                 ` Vincent Guittot
2020-08-20  0:13                                   ` benbjiang(蒋彪)
2020-08-20  7:35                                     ` Vincent Guittot
2020-08-20 11:27                                       ` benbjiang(蒋彪)
2020-08-20 12:45                                         ` Vincent Guittot
2020-08-20 14:28                                           ` Jiang Biao
2020-08-20 14:36                                             ` Vincent Guittot
2020-08-21  0:14                                               ` Jiang Biao
2020-08-19 14:10                           ` benbjiang(蒋彪)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4964e359-afc5-a256-4950-853a9485eeff@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=benbjiang@gmail.com \
    --cc=benbjiang@tencent.com \
    --cc=bsegall@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®