* [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
@ 2026-11-02 6:58 Shuai Liu
2026-11-02 8:51 ` Loic Poulain
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
0 siblings, 2 replies; 7+ messages in thread
From: Shuai Liu @ 2026-11-02 6:58 UTC (permalink / raw)
To: bryan.odonoghue
Cc: vladimir.zapolskiy, loic.poulain, mchehab, manivannan.sadhasivam,
linux-media, linux-arm-msm, linux-kernel, 847807867
Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
invisible bool gating phy-core-mipi-dphy.c where that helper lives.
With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
GENERIC_PHY_MIPI_DPHY, the build fails at link time:
camss-csiphy.c:(.text+0x51d): undefined reference to
`phy_mipi_dphy_get_default_config_for_hsclk'
Select GENERIC_PHY_MIPI_DPHY, matching the other MIPI D-PHY consumers
such as rkisp1, mali-c55, cadence-csi2rx and sun6i-mipi-csi2.
Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
Signed-off-by: Shuai Liu <847807867@qq.com>
---
drivers/media/platform/qcom/camss/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
index b51745c942c9..b18ae4405502 100644
--- a/drivers/media/platform/qcom/camss/Kconfig
+++ b/drivers/media/platform/qcom/camss/Kconfig
@@ -8,4 +8,5 @@ config VIDEO_QCOM_CAMSS
select VIDEOBUF2_DMA_SG
select V4L2_FWNODE
select GENERIC_PHY
+ select GENERIC_PHY_MIPI_DPHY
imply PHY_QCOM_MIPI_CSI2
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-02 6:58 [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY Shuai Liu
@ 2026-11-02 8:51 ` Loic Poulain
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
1 sibling, 0 replies; 7+ messages in thread
From: Loic Poulain @ 2026-11-02 8:51 UTC (permalink / raw)
To: Shuai Liu
Cc: bryan.odonoghue, vladimir.zapolskiy, mchehab,
manivannan.sadhasivam, linux-media, linux-arm-msm, linux-kernel
On Mon, Nov 2, 2026 at 7:58 AM Shuai Liu <847807867@qq.com> wrote:
>
> Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
> devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
> in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
> invisible bool gating phy-core-mipi-dphy.c where that helper lives.
>
> With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
> GENERIC_PHY_MIPI_DPHY, the build fails at link time:
>
> camss-csiphy.c:(.text+0x51d): undefined reference to
> `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Select GENERIC_PHY_MIPI_DPHY, matching the other MIPI D-PHY consumers
> such as rkisp1, mali-c55, cadence-csi2rx and sun6i-mipi-csi2.
>
> Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
> Signed-off-by: Shuai Liu <847807867@qq.com>
> ---
> drivers/media/platform/qcom/camss/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index b51745c942c9..b18ae4405502 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -8,4 +8,5 @@ config VIDEO_QCOM_CAMSS
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> select GENERIC_PHY
> + select GENERIC_PHY_MIPI_DPHY
So do we still need to select GENERIC_PHY?
> imply PHY_QCOM_MIPI_CSI2
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-02 6:58 [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY Shuai Liu
2026-11-02 8:51 ` Loic Poulain
@ 2026-11-02 9:20 ` Shuai Liu
2026-11-04 0:28 ` Vladimir Zapolskiy
1 sibling, 1 reply; 7+ messages in thread
From: Shuai Liu @ 2026-11-02 9:20 UTC (permalink / raw)
To: linux-media
Cc: bryan.odonoghue, vladimir.zapolskiy, mchehab,
manivannan.sadhasivam, loic.poulain, linux-arm-msm, linux-kernel
Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
invisible bool gating phy-core-mipi-dphy.c where that helper lives.
With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
GENERIC_PHY_MIPI_DPHY, the build fails at link time:
camss-csiphy.c:(.text+0x51d): undefined reference to
`phy_mipi_dphy_get_default_config_for_hsclk'
Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
Signed-off-by: Shuai Liu <847807867@qq.com>
---
Changes in v2:
- drop the redundant "select GENERIC_PHY", as suggested by Loic
Poulain; GENERIC_PHY_MIPI_DPHY selects it transitively
drivers/media/platform/qcom/camss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
index b51745c942c9..e0cef2cdd0a1 100644
--- a/drivers/media/platform/qcom/camss/Kconfig
+++ b/drivers/media/platform/qcom/camss/Kconfig
@@ -7,5 +7,5 @@ config VIDEO_QCOM_CAMSS
select VIDEO_V4L2_SUBDEV_API
select VIDEOBUF2_DMA_SG
select V4L2_FWNODE
- select GENERIC_PHY
+ select GENERIC_PHY_MIPI_DPHY
imply PHY_QCOM_MIPI_CSI2
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
@ 2026-11-04 0:28 ` Vladimir Zapolskiy
2026-11-04 1:11 ` [PATCH v3] " Shuai Liu
0 siblings, 1 reply; 7+ messages in thread
From: Vladimir Zapolskiy @ 2026-11-04 0:28 UTC (permalink / raw)
To: Shuai Liu, linux-media
Cc: bryan.odonoghue, mchehab, manivannan.sadhasivam, loic.poulain,
linux-arm-msm, linux-kernel
On 11/2/26 11:20, Shuai Liu wrote:
> Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
> devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
> in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
> invisible bool gating phy-core-mipi-dphy.c where that helper lives.
>
> With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
> GENERIC_PHY_MIPI_DPHY, the build fails at link time:
>
> camss-csiphy.c:(.text+0x51d): undefined reference to
> `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
> which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
> transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
> consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
>
> Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
> Signed-off-by: Shuai Liu <847807867@qq.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v3] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-04 0:28 ` Vladimir Zapolskiy
@ 2026-11-04 1:11 ` Shuai Liu
2026-11-04 8:17 ` Loic Poulain
2026-11-04 13:32 ` Bryan O'Donoghue
0 siblings, 2 replies; 7+ messages in thread
From: Shuai Liu @ 2026-11-04 1:11 UTC (permalink / raw)
To: linux-media
Cc: bryan.odonoghue, vladimir.zapolskiy, mchehab,
manivannan.sadhasivam, loic.poulain, linux-arm-msm, linux-kernel
Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
invisible bool gating phy-core-mipi-dphy.c where that helper lives.
With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
GENERIC_PHY_MIPI_DPHY, the build fails at link time:
camss-csiphy.c:(.text+0x51d): undefined reference to
`phy_mipi_dphy_get_default_config_for_hsclk'
Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
Signed-off-by: Shuai Liu <847807867@qq.com>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
---
Changes in v3:
- collect Reviewed-by tag
Changes in v2:
- drop the redundant "select GENERIC_PHY", as suggested by Loic
Poulain; GENERIC_PHY_MIPI_DPHY selects it transitively
---
drivers/media/platform/qcom/camss/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
index b51745c942c9..e0cef2cdd0a1 100644
--- a/drivers/media/platform/qcom/camss/Kconfig
+++ b/drivers/media/platform/qcom/camss/Kconfig
@@ -7,5 +7,5 @@ config VIDEO_QCOM_CAMSS
select VIDEO_V4L2_SUBDEV_API
select VIDEOBUF2_DMA_SG
select V4L2_FWNODE
- select GENERIC_PHY
+ select GENERIC_PHY_MIPI_DPHY
imply PHY_QCOM_MIPI_CSI2
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-04 1:11 ` [PATCH v3] " Shuai Liu
@ 2026-11-04 8:17 ` Loic Poulain
2026-11-04 13:32 ` Bryan O'Donoghue
1 sibling, 0 replies; 7+ messages in thread
From: Loic Poulain @ 2026-11-04 8:17 UTC (permalink / raw)
To: Shuai Liu
Cc: linux-media, bryan.odonoghue, vladimir.zapolskiy, mchehab,
manivannan.sadhasivam, linux-arm-msm, linux-kernel
On Wed, Nov 4, 2026 at 2:11 AM Shuai Liu <847807867@qq.com> wrote:
>
> Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
> devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
> in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
> invisible bool gating phy-core-mipi-dphy.c where that helper lives.
>
> With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
> GENERIC_PHY_MIPI_DPHY, the build fails at link time:
>
> camss-csiphy.c:(.text+0x51d): undefined reference to
> `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
> which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
> transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
> consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
>
> Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
> Signed-off-by: Shuai Liu <847807867@qq.com>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Please do not submit a new revision solely to update tags when there
are no other changes.
Reviewed-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
> Changes in v3:
> - collect Reviewed-by tag
>
> Changes in v2:
> - drop the redundant "select GENERIC_PHY", as suggested by Loic
> Poulain; GENERIC_PHY_MIPI_DPHY selects it transitively
> ---
> drivers/media/platform/qcom/camss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index b51745c942c9..e0cef2cdd0a1 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -7,5 +7,5 @@ config VIDEO_QCOM_CAMSS
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> - select GENERIC_PHY
> + select GENERIC_PHY_MIPI_DPHY
> imply PHY_QCOM_MIPI_CSI2
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY
2026-11-04 1:11 ` [PATCH v3] " Shuai Liu
2026-11-04 8:17 ` Loic Poulain
@ 2026-11-04 13:32 ` Bryan O'Donoghue
1 sibling, 0 replies; 7+ messages in thread
From: Bryan O'Donoghue @ 2026-11-04 13:32 UTC (permalink / raw)
To: Shuai Liu, linux-media
Cc: vladimir.zapolskiy, mchehab, manivannan.sadhasivam, loic.poulain,
linux-arm-msm, linux-kernel
On 04/11/2026 01:11, Shuai Liu wrote:
> Commit 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API
> devices") added a call to phy_mipi_dphy_get_default_config_for_hsclk()
> in camss-csiphy.c but did not select GENERIC_PHY_MIPI_DPHY, the
> invisible bool gating phy-core-mipi-dphy.c where that helper lives.
>
> With CONFIG_VIDEO_QCOM_CAMSS=y and no other driver pulling in
> GENERIC_PHY_MIPI_DPHY, the build fails at link time:
>
> camss-csiphy.c:(.text+0x51d): undefined reference to
> `phy_mipi_dphy_get_default_config_for_hsclk'
>
> Select GENERIC_PHY_MIPI_DPHY and drop the explicit "select GENERIC_PHY",
> which is redundant as GENERIC_PHY_MIPI_DPHY selects GENERIC_PHY
> transitively (drivers/phy/Kconfig). This matches the other MIPI D-PHY
> consumers such as rkisp1, mali-c55 and sun6i-mipi-csi2.
>
> Fixes: 0ee6c8a921b1 ("media: qcom: camss: Add support for PHY API devices")
> Signed-off-by: Shuai Liu <847807867@qq.com>
> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
> ---
> Changes in v3:
> - collect Reviewed-by tag
>
> Changes in v2:
> - drop the redundant "select GENERIC_PHY", as suggested by Loic
> Poulain; GENERIC_PHY_MIPI_DPHY selects it transitively
> ---
> drivers/media/platform/qcom/camss/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index b51745c942c9..e0cef2cdd0a1 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -7,5 +7,5 @@ config VIDEO_QCOM_CAMSS
> select VIDEO_V4L2_SUBDEV_API
> select VIDEOBUF2_DMA_SG
> select V4L2_FWNODE
> - select GENERIC_PHY
> + select GENERIC_PHY_MIPI_DPHY
> imply PHY_QCOM_MIPI_CSI2
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-11-04 13:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-02 6:58 [PATCH] media: qcom: camss: select GENERIC_PHY_MIPI_DPHY Shuai Liu
2026-11-02 8:51 ` Loic Poulain
2026-11-02 9:20 ` [PATCH v2] " Shuai Liu
2026-11-04 0:28 ` Vladimir Zapolskiy
2026-11-04 1:11 ` [PATCH v3] " Shuai Liu
2026-11-04 8:17 ` Loic Poulain
2026-11-04 13:32 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®