mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Zide" <zide.chen@intel.com>
To: Yosry Ahmed <yosry@kernel.org>
Cc: Jim Mattson <jmattson@google.com>,
	Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	kvm@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Stephane Eranian <eranian@google.com>,
	linux-kernel@vger.kernel.org, Mingwei Zhang <mizhang@google.com>,
	Das Sandipan <Sandipan.Das@amd.com>,
	Shukla Manali <Manali.Shukla@amd.com>,
	Dapeng Mi <dapeng1.mi@linux.intel.com>,
	Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH v2 11/16] KVM: x86/pmu: Emulate the GLOBAL_STATUS_SET and GLOBAL_INUSE MSRs
Date: Mon, 2 Nov 2026 22:32:51 -0600	[thread overview]
Message-ID: <5051866d-ff33-4b09-a4d0-756f305f5154@intel.com> (raw)
In-Reply-To: <CAO9r8zMvkGzxUR7jBPVFWK+Fry4wk49J3WdwFqa22bSgGaS4YQ@mail.gmail.com>



On 11/2/2026 5:37 PM, Yosry Ahmed wrote:
>>>> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
>>>> index 38c7a4fa1007..3849b3f5234a 100644
>>>> --- a/arch/x86/kvm/pmu.c
>>>> +++ b/arch/x86/kvm/pmu.c
>>>> @@ -862,6 +862,8 @@ int kvm_pmu_get_msr(struct kvm_vcpu *vcpu, struct
>>>> msr_data *msr_info)
>>>>         switch (msr) {
>>>>         case MSR_CORE_PERF_GLOBAL_STATUS:
>>>>         case MSR_AMD64_PERF_CNTR_GLOBAL_STATUS:
>>>> +               if (msr_info->host_initiated)
>>>> +                       pmu->global_status &= ~pmu->global_status_rsvd;
>>>>
>>>> The underlying issue still requires proper mutual exclusion between
>>>> Intel PT and mediated vPMU, which I think can be addressed separately.
>>>
>>> Or maybe handle the host PT while the guest is running? Not sure if
>>> that would be correct.
>>
>> Since KVM switches APIC LVTPC in guest context, it seems difficult to
>> correctly handle host PT PMIs while the guest is running.
> 
> One hacky way to do it is to make perf_guest_handle_mediated_pmi()
> handle host PT before calling into KVM. This doesn't completely stop
> the guest from seeing the bit tho. Also, I think we may have no way of
> finding out if we still need to inject a PMI into the guest for a
> different reason or not :/

Right, and the host perf subsystem doesn't know which GLOBAL_STATUS bits
it is supposed to handle.

The hardware-assisted perfmon_mask solution seems like a clean way to
avoid this problem. :)

And I think if Intel PT virtualization is re-enabled at some point,
addressing the mutual exclusion issue would probably be necessary
regardless.

>>
>> I guess Intel PT virtualization could be re-enabled sooner or later, and
>> addressing the exclusion issue would be a must at that point anyway.


  reply	other threads:[~2026-11-03  4:32 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 22:37 [PATCH] KVM: x86/pmu: Add mediated vPMU PerfMon v5 support Zide Chen
2026-08-27 22:37 ` [PATCH v2 01/16] KVM: x86/pmu: Remove redundant Perf Global Status MSR bit definitions Zide Chen
2026-09-01  2:07   ` Mi, Dapeng
2026-10-28 14:03   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 02/16] KVM: x86/pmu: Rename all_valid_pmc_idx to pmc_exists Zide Chen
2026-09-01  2:09   ` Mi, Dapeng
2026-10-28 14:04   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 03/16] KVM: x86/pmu: Rename reserved_bits to eventsel_rsvd in kvm_pmu Zide Chen
2026-09-01  2:17   ` Mi, Dapeng
2026-10-28 14:05   ` Jim Mattson
2026-11-02 13:53   ` Sandipan Das
2026-08-27 22:37 ` [PATCH v2 04/16] KVM: x86/pmu: Gate BUFFER_OVF reserved bit on guest DS Zide Chen
2026-09-01  2:30   ` Mi, Dapeng
2026-10-28 14:25   ` Jim Mattson
2026-10-28 19:05     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 05/16] KVM: x86/pmu: Add PMC bitmap accessor helpers Zide Chen
2026-09-01  2:43   ` Mi, Dapeng
2026-10-28 14:32   ` Jim Mattson
2026-10-28 17:24     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 06/16] KVM: x86/pmu: Drop nr_arch_{gp,fixed}_counters from kvm_pmu Zide Chen
2026-09-01  3:07   ` Mi, Dapeng
2026-10-28 14:49   ` Jim Mattson
2026-10-28 17:04     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 07/16] KVM: x86/pmu: Expose kvm_host_pmu to vendor modules Zide Chen
2026-09-01  3:08   ` Mi, Dapeng
2026-10-28 17:33   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 08/16] perf/x86: Plumb counter bitmap from x86_pmu to x86_pmu_cap Zide Chen
2026-10-28 17:39   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 09/16] KVM: x86/pmu: Switch to bitmask-based KVM PMU capabilities Zide Chen
2026-09-01  3:32   ` Mi, Dapeng
2026-10-28 17:57   ` Jim Mattson
2026-10-28 20:56     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 10/16] perf/x86: Remove num_counters_{gp,fixed} from x86_pmu_capability Zide Chen
2026-10-28 18:01   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 11/16] KVM: x86/pmu: Emulate the GLOBAL_STATUS_SET and GLOBAL_INUSE MSRs Zide Chen
2026-09-01  6:45   ` Mi, Dapeng
2026-09-01 14:20     ` Chen, Zide
2026-09-02  0:44       ` Mi, Dapeng
2026-10-28 21:24   ` Jim Mattson
2026-10-29 17:45     ` Chen, Zide
2026-10-30 11:55       ` Jim Mattson
2026-10-30 17:20         ` Chen, Zide
2026-10-30 18:23           ` Jim Mattson
2026-10-30 20:01             ` Chen, Zide
2026-10-30 22:13     ` Yosry Ahmed
2026-11-02 17:38       ` Chen, Zide
2026-11-02 18:32         ` Jim Mattson
2026-11-02 18:49         ` Yosry Ahmed
2026-11-02 21:29           ` Chen, Zide
2026-11-02 21:36             ` Yosry Ahmed
2026-11-02 22:13               ` Chen, Zide
2026-11-02 22:25                 ` Jim Mattson
2026-11-02 22:48                   ` Chen, Zide
2026-11-02 22:51                     ` Yosry Ahmed
2026-11-02 23:26                       ` Chen, Zide
2026-11-02 23:37                         ` Yosry Ahmed
2026-11-03  4:32                           ` Chen, Zide [this message]
2026-11-02 23:44                       ` Jim Mattson
2026-11-03  4:32                         ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 12/16] KVM: x86/pmu: Populate CPUID.0AH:ECX fixed-counter bitmap Zide Chen
2026-09-01  6:50   ` Mi, Dapeng
2026-10-28 21:29   ` Jim Mattson
2026-10-28 21:55     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 13/16] KVM: x86/pmu: Factor out fixed counter control bit calculation Zide Chen
2026-09-01  6:57   ` Mi, Dapeng
2026-10-28 21:30   ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 14/16] KVM: x86/pmu: Ignore AnyThread bit if CPUID.0AH:EDX[15] is set Zide Chen
2026-09-01  8:01   ` Mi, Dapeng
2026-10-28 21:50   ` Jim Mattson
2026-10-28 23:05     ` Chen, Zide
2026-10-28 23:09       ` Jim Mattson
2026-08-27 22:37 ` [PATCH v2 15/16] KVM: x86/pmu: Advertise PerfMon version 5 on Intel hosts Zide Chen
2026-10-28 21:59   ` Jim Mattson
2026-10-28 22:10     ` Chen, Zide
2026-08-27 22:37 ` [PATCH v2 16/16] KVM: selftests: Support fixed counters bitmap in pmu_counters_test Zide Chen
2026-08-29  9:30 ` [PATCH] KVM: x86/pmu: Add mediated vPMU PerfMon v5 support Peter Zijlstra
2026-10-19 19:15 ` [PATCH v2] " Chen, Zide

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051866d-ff33-4b09-a4d0-756f305f5154@intel.com \
    --to=zide.chen@intel.com \
    --cc=Manali.Shukla@amd.com \
    --cc=Sandipan.Das@amd.com \
    --cc=ak@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=eranian@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mizhang@google.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=xudong.hao@intel.com \
    --cc=yosry@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®