From: "NG, TZE YEE" <tze.yee.ng@altera.com>
To: "Kathpalia, Tanmay" <tanmay.kathpalia@altera.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulfh@kernel.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/4] mmc: sdhci-cadence6: add PHY settle delay after tuning DLL re-lock
Date: Wed, 30 Sep 2026 20:05:26 +0800 [thread overview]
Message-ID: <556594fa-9408-4c4c-b92e-8881c17bbba1@altera.com> (raw)
In-Reply-To: <eb04492f-fecc-4470-974c-8417613a2278@altera.com>
On 26/9/2026 6:44 pm, Kathpalia, Tanmay wrote:
>
> On 22-09-2026 16:42, tze.yee.ng@altera.com wrote:
>> From: Tze Yee Ng<tze.yee.ng@altera.com>
>>
>> After re-locking the DLL, allow the same 5 to 5.5 ms for the clock and
>> PHY signals to stabilize as sdhci_cdns6_phy_init() does. Without this
>> settle time the command issued immediately after tuning (e.g. the R1b
>> CMD6 that switches eMMC from HS200 down to HS during HS400 selection)
>> can time out.
>
> One additional concern is that the testing listed in the cover letter
> does not
> exercise the paths described here. The series reports testing SD DDR50
> and eMMC
> DDR52, but neither mode performs tuning through sdhci_cdns6_set_tune_val().
>
Correct. DDR50/DDR52 don't run execute_tuning(). This path is only hit
by eMMC HS200/HS400 and SD SDR104, so I'll rescope the cover letter.
> Please test this change with eMMC HS200 and HS400. The same function is
> also
> used during SD SDR104 tuning, so SDR104 should be covered as well.
eMMC HS200/HS400 is covered: HS400 selection runs HS200 tuning first,
and the retest goes through that path - "mmc0: new HS400 MMC card", with
the HS200->HS CMD6 that used to return -110 now passing.
Thanks,
Tze Yee
next prev parent reply other threads:[~2026-09-30 12:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 11:12 [PATCH 0/4] mmc: sdhci-cadence: SD6HC DDR50 read-path tuning and fixes tze.yee.ng
2026-09-22 11:12 ` [PATCH 1/4] mmc: sdhci-cadence6: add PHY settle delay after tuning DLL re-lock tze.yee.ng
2026-09-24 6:41 ` Adrian Hunter
2026-09-30 11:11 ` NG, TZE YEE
2026-09-24 8:49 ` Kathpalia, Tanmay
2026-09-30 11:11 ` NG, TZE YEE
2026-09-26 10:44 ` Kathpalia, Tanmay
2026-09-30 12:05 ` NG, TZE YEE [this message]
2026-09-22 11:12 ` [PATCH 2/4] mmc: sdhci-cadence6: program PHONY_DQS_TIMING for extended-read DDR tze.yee.ng
2026-09-24 6:41 ` Adrian Hunter
2026-09-26 10:45 ` Kathpalia, Tanmay
2026-09-30 10:24 ` NG, TZE YEE
2026-09-22 11:12 ` [PATCH 3/4] dt-bindings: mmc: cdns,sdhci: add SD6HC DDR50 read-path tuning tze.yee.ng
2026-09-26 10:48 ` Kathpalia, Tanmay
2026-09-30 12:31 ` NG, TZE YEE
2026-09-30 13:16 ` NG, TZE YEE
2026-09-28 8:05 ` Krzysztof Kozlowski
2026-09-30 13:13 ` NG, TZE YEE
2026-09-22 11:12 ` [PATCH 4/4] mmc: sdhci-cadence: read SD6HC DDR50 tuning from device tree tze.yee.ng
2026-09-24 6:40 ` Adrian Hunter
2026-09-30 13:24 ` NG, TZE YEE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556594fa-9408-4c4c-b92e-8881c17bbba1@altera.com \
--to=tze.yee.ng@altera.com \
--cc=adrian.hunter@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tanmay.kathpalia@altera.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®