mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
	bmc-sw@aspeedtech.com, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	jk@codeconstruct.com.au, Lee Jones <lee@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Nishanth Menon <nm@ti.com>,
	nfraprado@collabora.com, Taniya Das <quic_tdas@quicinc.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Eric Biggers <ebiggers@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/6] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range
Date: Wed, 22 Oct 2025 10:07:23 +0200	[thread overview]
Message-ID: <590aada3-4f3a-418c-804b-8ac7feb83305@kernel.org> (raw)
In-Reply-To: <20251022070543.1169173-4-ryan_chen@aspeedtech.com>

On 22/10/2025 09:05, Ryan Chen wrote:
> The #size-cells property in the Aspeed SCU binding is currently
> fixed to a constant value of 1. However, newer SoCs (ex. AST2700)
> may require two size cells to describe certain subregions or
> subdevices.
> 
> This patch updates the schema to allow #size-cells values in
> the range of 1 to 2. This makes the binding more flexible
> while maintaining compatibility with existing platforms.
> It also resolves dt-binding validation warnings reported
> by `make dt_binding_check`.
> 
> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> ---
>  Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> index da1887d7a8fe..ee7855845e97 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml
> @@ -38,7 +38,7 @@ properties:
>      maximum: 2
>  
>    '#size-cells':
> -    const: 1
> +    enum: [1, 2]
>  

I said no last time and now when we see the DTS it is visible it makes
no sense. Please reply in the DTS patch in the EXACT place where this is
being used.

NAK

Best regards,
Krzysztof

  reply	other threads:[~2025-10-22  8:07 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22  7:05 [PATCH v6 0/6] Introduce ASPEED AST2700 BMC SoC Ryan Chen
2025-10-22  7:05 ` [PATCH v6 1/6] dt-bindings: arm: aspeed: Add AST2700 board compatible Ryan Chen
2025-10-22  7:05 ` [PATCH v6 2/6] arm64: Kconfig: Add Aspeed SoC family (ast27XX) Kconfig support Ryan Chen
2025-10-22  7:05 ` [PATCH v6 3/6] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range Ryan Chen
2025-10-22  8:07   ` Krzysztof Kozlowski [this message]
2025-10-22  8:08   ` Krzysztof Kozlowski
2025-10-22  8:28     ` Ryan Chen
2025-10-22  7:05 ` [PATCH v6 4/6] arm64: dts: aspeed: Add initial AST2700 SoC device tree Ryan Chen
2025-10-22 21:29   ` Arnd Bergmann
2025-10-23  7:37     ` Ryan Chen
2025-10-23 18:28       ` Andrew Lunn
2025-10-23 20:11       ` Arnd Bergmann
2025-10-24  3:54         ` Ryan Chen
2025-10-24  7:02           ` Arnd Bergmann
2025-10-24 12:28           ` Andrew Lunn
2025-10-25  3:08             ` Ryan Chen
2025-10-27  1:43               ` Andrew Lunn
2025-10-27  2:42                 ` Ryan Chen
2025-10-27 12:01                   ` Andrew Lunn
2025-10-27 12:53                     ` Geert Uytterhoeven
2025-10-29  2:38                       ` Ryan Chen
2025-10-29  9:52                         ` Geert Uytterhoeven
2025-10-29  2:31                     ` Ryan Chen
2025-10-29  7:26                       ` Arnd Bergmann
2025-10-29  9:50                         ` Geert Uytterhoeven
2025-10-30  2:30                           ` Ryan Chen
2025-10-30  9:19                             ` Arnd Bergmann
2025-11-05  0:35                               ` Ryan Chen
2025-10-24  7:56         ` Geert Uytterhoeven
2025-10-25  3:15           ` Ryan Chen
2025-10-22  7:05 ` [PATCH v6 5/6] arm64: dts: aspeed: Add AST2700 Evaluation Board Ryan Chen
2025-10-22  7:05 ` [PATCH v6 6/6] arm64: configs: Update defconfig for AST2700 platform support Ryan Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=590aada3-4f3a-418c-804b-8ac7feb83305@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=bmc-sw@aspeedtech.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=jk@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=nm@ti.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome