From: MD Danish Anwar <danishanwar@ti.com>
To: Dong Yibo <dong100@mucse.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <corbet@lwn.net>,
<gur.stavi@huawei.com>, <maddy@linux.ibm.com>,
<mpe@ellerman.id.au>, <lee@trager.us>, <gongfan1@huawei.com>,
<lorenzo@kernel.org>, <geert+renesas@glider.be>,
<Parthiban.Veerasooran@microchip.com>, <lukas.bulwahn@redhat.com>,
<alexanderduyck@fb.com>, <richardcochran@gmail.com>
Cc: <netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 00/15] Add driver for 1Gbe network chips from MUCSE
Date: Tue, 22 Jul 2025 16:50:48 +0530 [thread overview]
Message-ID: <5bce6424-51f9-4cc1-9289-93a2c15aa0c1@ti.com> (raw)
In-Reply-To: <20250721113238.18615-1-dong100@mucse.com>
Hi Dong,
On 21/07/25 5:02 pm, Dong Yibo wrote:
> Hi maintainers,
>
> This patch series introduces support for MUCSE N500/N210 1Gbps Ethernet
> controllers. Only basic tx/rx is included, more features can be added in
> the future.
>
> The driver has been tested on the following platform:
> - Kernel version: 6.16.0-rc3
> - Intel Xeon Processor
>
> Changelog:
> v1 -> v2:
> [patch 01/15]:
> 1. Fix changed section in MAINTAINERs file by mistake.
> 2. Fix odd indentaition in 'drivers/net/ethernet/mucse/Kconfig'.
> 3. Drop pointless driver version.
> 4. Remove pr_info prints.
> 5. Remove no need 'memset' for priv after alloc_etherdev_mq.
> 6. Fix __ function names.
> 7. Fix description errors from 'kdoc summry'.
> [patch 02/15]:
> 1. Fix define by using the BIT() macro.
> 2. Remove wrong 'void *' cast.
> 3. Fix 'reverse Christmas tree' format for local variables.
> 4. Fix description errors from 'kdoc summry'.
> [patch 03/15]:
> 1. Remove inline functions in C files.
> 2. Remove use s32, use int.
> 3. Use iopoll to instead rolling own.
> 4. Fix description errors from 'kdoc summry'.
> [patch 04/15]:
> 1. Using __le32/__le16 in little endian define.
> 2. Remove all defensive code.
> 3. Remove pcie hotplug relative code.
> 4. Fix 'replace one error code with another' error.
> 5. Turn 'fw error code' to 'linux/POSIX error code'.
> 6. Fix description errors from 'kdoc summry'.
> [patch 05/15]:
> 1. Use iopoll to instead rolling own.
> 2. Use 'linux/POSIX error code'.
> 3. Use devlink to download flash.
> 4. Fix description errors from 'kdoc summry'.
> [patch 06/15] - [patch 15/15]:
> 1. Check errors similar to the patches [1-5].
> 2. Fix description errors from 'kdoc summry'.
>
> v1: Initial submission
> https://lore.kernel.org/netdev/20250703014859.210110-1-dong100@mucse.com/T/#t
>
>
> Dong Yibo (15):
> net: rnpgbe: Add build support for rnpgbe
> net: rnpgbe: Add n500/n210 chip support
> net: rnpgbe: Add basic mbx ops support
> net: rnpgbe: Add get_capability mbx_fw ops support
> net: rnpgbe: Add download firmware for n210 chip
> net: rnpgbe: Add some functions for hw->ops
> net: rnpgbe: Add get mac from hw
> net: rnpgbe: Add irq support
> net: rnpgbe: Add netdev register and init tx/rx memory
> net: rnpgbe: Add netdev irq in open
> net: rnpgbe: Add setup hw ring-vector, true up/down hw
> net: rnpgbe: Add link up handler
> net: rnpgbe: Add base tx functions
> net: rnpgbe: Add base rx function
> net: rnpgbe: Add ITR for rx
>
This series has lots of checkpatch errors / warnings.
Before posting the series please try to run checkpatch on all patches.
./scripts/checkpatch.pl --strict --codespell <PATH_TO_PATCHES>
For patches within net subsystem, for declaring variables, please follow
https://www.kernel.org/doc/html/v6.3/process/maintainer-netdev.html#local-variable-ordering-reverse-xmas-tree-rcs
You can use https://github.com/ecree-solarflare/xmastree to verify
locally before posting.
The series also has kdoc warnings, please run below script on all the
files that the series is modifying.
./scripts/kernel-doc -none -Wall
> .../device_drivers/ethernet/index.rst | 1 +
> .../device_drivers/ethernet/mucse/rnpgbe.rst | 21 +
> MAINTAINERS | 8 +
> drivers/net/ethernet/Kconfig | 1 +
> drivers/net/ethernet/Makefile | 1 +
> drivers/net/ethernet/mucse/Kconfig | 35 +
> drivers/net/ethernet/mucse/Makefile | 7 +
> drivers/net/ethernet/mucse/rnpgbe/Makefile | 13 +
> drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h | 733 ++++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c | 593 +++++
> drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h | 66 +
> .../net/ethernet/mucse/rnpgbe/rnpgbe_lib.c | 2320 +++++++++++++++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_lib.h | 175 ++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c | 901 +++++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c | 623 +++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h | 49 +
> .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 753 ++++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h | 695 +++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_sfc.c | 476 ++++
> .../net/ethernet/mucse/rnpgbe/rnpgbe_sfc.h | 30 +
> 20 files changed, 7501 insertions(+)
7.5K Lines of change is a too much for a series. It becomes very
difficult for maintainers to review a series like this.
Please try to split this into multiple series if possible.
> create mode 100644 Documentation/networking/device_drivers/ethernet/mucse/rnpgbe.rst
> create mode 100644 drivers/net/ethernet/mucse/Kconfig
> create mode 100644 drivers/net/ethernet/mucse/Makefile
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/Makefile
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_chip.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_hw.h
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_lib.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_lib.h
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_main.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_sfc.c
> create mode 100644 drivers/net/ethernet/mucse/rnpgbe/rnpgbe_sfc.h
>
--
Thanks and Regards,
Danish
next prev parent reply other threads:[~2025-07-22 11:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 11:32 Dong Yibo
2025-07-21 11:32 ` [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe Dong Yibo
2025-07-21 13:30 ` Vadim Fedorenko
2025-07-21 14:57 ` Andrew Lunn
2025-07-22 3:02 ` Yibo Dong
2025-07-22 10:17 ` Vadim Fedorenko
2025-07-22 11:05 ` Yibo Dong
2025-07-21 14:55 ` Andrew Lunn
2025-07-22 3:38 ` Yibo Dong
2025-07-22 14:58 ` Andrew Lunn
2025-07-21 21:23 ` Brett Creeley
2025-07-22 4:59 ` Yibo Dong
2025-07-22 11:29 ` Simon Horman
2025-07-23 3:01 ` Yibo Dong
2025-07-23 20:09 ` Simon Horman
2025-07-24 6:10 ` Yibo Dong
2025-07-25 9:51 ` Simon Horman
2025-07-21 11:32 ` [PATCH v2 02/15] net: rnpgbe: Add n500/n210 chip support Dong Yibo
2025-07-21 14:21 ` Vadim Fedorenko
2025-07-22 9:51 ` Yibo Dong
2025-07-22 10:26 ` Vadim Fedorenko
2025-07-22 11:09 ` Yibo Dong
2025-07-21 15:25 ` Andrew Lunn
2025-07-22 6:21 ` Yibo Dong
2025-07-22 13:56 ` Andrew Lunn
2025-07-21 11:32 ` [PATCH v2 03/15] net: rnpgbe: Add basic mbx ops support Dong Yibo
2025-07-21 14:40 ` Vadim Fedorenko
2025-07-21 15:43 ` Andrew Lunn
2025-07-22 6:45 ` Yibo Dong
2025-07-22 13:50 ` Andrew Lunn
2025-07-23 10:27 ` Yibo Dong
2025-07-21 21:54 ` Brett Creeley
2025-07-22 7:39 ` Yibo Dong
2025-07-22 11:35 ` Simon Horman
2025-07-23 3:07 ` Yibo Dong
2025-07-23 14:38 ` Andrew Lunn
2025-07-25 10:11 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 04/15] net: rnpgbe: Add get_capability mbx_fw " Dong Yibo
2025-07-21 22:08 ` Brett Creeley
2025-07-22 8:04 ` Yibo Dong
2025-07-22 13:19 ` Simon Horman
2025-07-23 3:15 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 05/15] net: rnpgbe: Add download firmware for n210 chip Dong Yibo
2025-07-21 11:32 ` [PATCH v2 06/15] net: rnpgbe: Add some functions for hw->ops Dong Yibo
2025-07-21 11:32 ` [PATCH v2 07/15] net: rnpgbe: Add get mac from hw Dong Yibo
2025-07-21 11:32 ` [PATCH v2 08/15] net: rnpgbe: Add irq support Dong Yibo
2025-07-22 13:25 ` Simon Horman
2025-07-23 3:21 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 09/15] net: rnpgbe: Add netdev register and init tx/rx memory Dong Yibo
2025-07-21 11:32 ` [PATCH v2 10/15] net: rnpgbe: Add netdev irq in open Dong Yibo
2025-07-22 14:03 ` Simon Horman
2025-07-23 6:13 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 11/15] net: rnpgbe: Add setup hw ring-vector, true up/down hw Dong Yibo
2025-07-21 11:32 ` [PATCH v2 12/15] net: rnpgbe: Add link up handler Dong Yibo
2025-07-21 15:47 ` Andrew Lunn
2025-07-22 6:48 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 13/15] net: rnpgbe: Add base tx functions Dong Yibo
2025-07-21 11:32 ` [PATCH v2 14/15] net: rnpgbe: Add base rx function Dong Yibo
2025-07-22 14:14 ` Simon Horman
2025-07-23 6:49 ` Yibo Dong
2025-07-21 11:32 ` [PATCH v2 15/15] net: rnpgbe: Add ITR for rx Dong Yibo
2025-07-22 11:20 ` MD Danish Anwar [this message]
2025-07-22 11:35 ` [PATCH v2 00/15] Add driver for 1Gbe network chips from MUCSE Yibo Dong
2025-07-22 15:07 ` Andrew Lunn
2025-07-23 10:42 ` Yibo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bce6424-51f9-4cc1-9289-93a2c15aa0c1@ti.com \
--to=danishanwar@ti.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dong100@mucse.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=gongfan1@huawei.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lee@trager.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®