Re: [PATCH v2 12/15] net: rnpgbe: Add link up handler

[Andrew Lunn <andrew@lunn.ch>]

On Mon, Jul 21, 2025 at 07:32:35PM +0800, Dong Yibo wrote:
> Initialize link status handler
> 
> Signed-off-by: Dong Yibo <dong100@mucse.com>
> ---
>  drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h    |  53 +++++
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_chip.c   |  26 +++
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_lib.c    |   7 +
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_main.c   | 139 +++++++++++++
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx.h    |   1 +
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.c | 187 ++++++++++++++++++
>  .../net/ethernet/mucse/rnpgbe/rnpgbe_mbx_fw.h |   7 +
>  7 files changed, 420 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> index 624e0eec562a..b241740d9cc5 100644
> --- a/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> +++ b/drivers/net/ethernet/mucse/rnpgbe/rnpgbe.h
> @@ -26,6 +26,15 @@ enum rnpgbe_hw_type {
>  	rnpgbe_hw_unknow
>  };
>  
> +enum speed_enum {
> +	speed_10,
> +	speed_100,
> +	speed_1000,
> +	speed_10000,
> +	speed_25000,
> +	speed_40000,

Patch 1/X says:

+config MGBE
+       tristate "Mucse(R) 1GbE PCI Express adapters support"
+       depends on PCI
+       select PAGE_POOL
+       help
+         This driver supports Mucse(R) 1GbE PCI Express family of
+         adapters.

This is a 1G NIC, so you can remove 10G, 25G and 40G from there. They
are pointless.

	Andrew