Re: [PATCH v5 13/24] iommu/amd: Program IOMMU DTE with the private IPA domain

["Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>]

On 9/22/2026 1:57 PM, Guixin Liu wrote:
>> diff --git a/drivers/iommu/amd/viommu.c b/drivers/iommu/amd/viommu.c
>> index 89d6dc520b2c..3ec907a498c2 100644
>> --- a/drivers/iommu/amd/viommu.c
>> +++ b/drivers/iommu/amd/viommu.c
>> @@ -40,11 +40,55 @@ static void __init amd_viommu_vf_vfcntl_unmap(struct amd_iommu *iommu)
>>   	}
>>   }
>>   
>> +
>> +static void viommu_free_self_dev_data(struct amd_iommu *iommu)
>> +{
>> +	struct iommu_dev_data *dev_data = iommu->viommu_dev_data;
>> +	struct dev_table_entry new = {};
>> +
>> +	if (!dev_data)
>> +		return;
>> +
>> +	amd_iommu_make_clear_dte(iommu, dev_data->devid, &new);
>> +	amd_iommu_update_dte(iommu, dev_data, &new);
> Should check viommu_cmdbuf_enabled() first? If enabled then update dte.

Right. I'll fix this in v6.

Thanks,
Suravee