From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH v2 1/3] dt-bindings: i2c: Add StarFive JHB100 I2C
Date: Thu, 28 May 2026 09:47:53 +0200 [thread overview]
Message-ID: <5e68aa84-7ce8-4405-9575-173e0a5834ca@kernel.org> (raw)
In-Reply-To: <ZQ0PR01MB12696D9B1AB14D4A3BEAEC2982092@ZQ0PR01MB1269.CHNPR01.prod.partner.outlook.cn>
On 28/05/2026 08:57, Lianfeng Ouyang wrote:
>>> + default: 400000
>>> +
>>> + i2c-sda-hold-time-ns:
>>
>> So you added a generic property - where is it documented? Generic
>> properties must be in common schema or dtschema.
>>
>> And please prove that none of the generic properties are suitable.
>>
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>
>> I don't think you tested it. And this concludes my review. I finished
>> here. Please do not send untested bindings.
>>
>>
>> Best regards,
>> Krzysztof
>
> Sorry, I didn't know I needed to run dt-binding_check before, but now I have
Every doc asks that. DTS101 slides or my earlier talks as well... Other
people talks as well... and you received that request last time at v1.
Please do not repeat the same mistakes because then we feel like our
feedback is wasted.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-28 7:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 8:50 [PATCH v2 0/3] i2c: Add Starfive JHB100 I2C master/slave support lianfeng.ouyang
2026-05-27 8:50 ` [PATCH v2 1/3] dt-bindings: i2c: Add StarFive JHB100 I2C lianfeng.ouyang
2026-05-27 13:04 ` Krzysztof Kozlowski
2026-05-28 6:57 ` 回复: " Lianfeng Ouyang
2026-05-28 7:47 ` Krzysztof Kozlowski [this message]
2026-05-28 8:30 ` 回复: " Lianfeng Ouyang
2026-05-27 8:50 ` [PATCH v2 2/3] i2c: designware: Export symbols and add __weak for Starfive I2C driver lianfeng.ouyang
2026-05-27 13:07 ` Krzysztof Kozlowski
2026-05-28 2:36 ` 回复: " Lianfeng Ouyang
2026-05-28 7:46 ` Krzysztof Kozlowski
2026-05-28 8:28 ` 回复: " Lianfeng Ouyang
2026-06-03 14:34 ` Krzysztof Kozlowski
2026-06-04 2:11 ` 回复: " Lianfeng Ouyang
2026-06-02 22:24 ` Andy Shevchenko
2026-05-27 8:50 ` [PATCH v2 3/3] i2c: starfive: Add StarFive JHB100 I2C master/slave support lianfeng.ouyang
2026-05-27 12:36 ` [PATCH v2 0/3] i2c: Add Starfive " Mika Westerberg
2026-05-28 2:41 ` 回复: " Lianfeng Ouyang
2026-06-02 22:26 ` Andy Shevchenko
2026-06-03 5:31 ` 回复: " Lianfeng Ouyang
2026-06-03 5:48 ` Andy Shevchenko
2026-06-03 6:09 ` 回复: " Lianfeng Ouyang
2026-06-03 6:39 ` Andy Shevchenko
2026-06-04 3:00 ` 回复: " Lianfeng Ouyang
2026-06-04 18:09 ` Andy Shevchenko
2026-06-08 9:48 ` 回复: " Lianfeng Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e68aa84-7ce8-4405-9575-173e0a5834ca@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome