From: Krzysztof Kozlowski <krzk@kernel.org>
To: "lianfeng.ouyang" <lianfeng.ouyang@starfivetech.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] i2c: designware: Export symbols and add __weak for Starfive I2C driver
Date: Wed, 27 May 2026 15:07:19 +0200 [thread overview]
Message-ID: <c1ae50ab-1228-45a3-b910-4564774f4198@kernel.org> (raw)
In-Reply-To: <20260527085039.44435-3-lianfeng.ouyang@starfivetech.com>
On 27/05/2026 10:50, lianfeng.ouyang wrote:
> dev->dev = device;
> dev->irq = irq;
> dev->flags = flags;
> @@ -255,6 +259,8 @@ static const struct of_device_id dw_i2c_of_match[] = {
> { .compatible = "mobileye,eyeq6lplus-i2c" },
> { .compatible = "mscc,ocelot-i2c" },
> { .compatible = "snps,designware-i2c" },
> + { .compatible = "starfive,jhb100-i2c-master" },
> + { .compatible = "starfive,jhb100-i2c-slave" },
So both devices are the same... Or you miss proper entry in ID table.
Don't sprinkle compatibles around the code - ID table match data is for
variant customization.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-27 13:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 8:50 [PATCH v2 0/3] i2c: Add Starfive JHB100 I2C master/slave support lianfeng.ouyang
2026-05-27 8:50 ` [PATCH v2 1/3] dt-bindings: i2c: Add StarFive JHB100 I2C lianfeng.ouyang
2026-05-27 13:04 ` Krzysztof Kozlowski
2026-05-28 6:57 ` 回复: " Lianfeng Ouyang
2026-05-28 7:47 ` Krzysztof Kozlowski
2026-05-28 8:30 ` 回复: " Lianfeng Ouyang
2026-05-27 8:50 ` [PATCH v2 2/3] i2c: designware: Export symbols and add __weak for Starfive I2C driver lianfeng.ouyang
2026-05-27 13:07 ` Krzysztof Kozlowski [this message]
2026-05-28 2:36 ` 回复: " Lianfeng Ouyang
2026-05-28 7:46 ` Krzysztof Kozlowski
2026-05-28 8:28 ` 回复: " Lianfeng Ouyang
2026-06-03 14:34 ` Krzysztof Kozlowski
2026-06-04 2:11 ` 回复: " Lianfeng Ouyang
2026-06-02 22:24 ` Andy Shevchenko
2026-05-27 8:50 ` [PATCH v2 3/3] i2c: starfive: Add StarFive JHB100 I2C master/slave support lianfeng.ouyang
2026-05-27 12:36 ` [PATCH v2 0/3] i2c: Add Starfive " Mika Westerberg
2026-05-28 2:41 ` 回复: " Lianfeng Ouyang
2026-06-02 22:26 ` Andy Shevchenko
2026-06-03 5:31 ` 回复: " Lianfeng Ouyang
2026-06-03 5:48 ` Andy Shevchenko
2026-06-03 6:09 ` 回复: " Lianfeng Ouyang
2026-06-03 6:39 ` Andy Shevchenko
2026-06-04 3:00 ` 回复: " Lianfeng Ouyang
2026-06-04 18:09 ` Andy Shevchenko
2026-06-08 9:48 ` 回复: " Lianfeng Ouyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1ae50ab-1228-45a3-b910-4564774f4198@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lianfeng.ouyang@starfivetech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome