From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Abhishek Sahu <absahu@codeaurora.org>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
"Imran Shaik" <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>
Subject: Re: [PATCH v2 5/6] clk: qcom: Add camera clock controller driver for SM8150
Date: Mon, 15 Jul 2024 16:06:59 +0530 [thread overview]
Message-ID: <6124f9e9-3fdf-29b1-128f-c58f5ebe1424@quicinc.com> (raw)
In-Reply-To: <f4072105-e0e2-46c8-82ed-92105b43a345@linaro.org>
On 7/11/2024 3:21 PM, Bryan O'Donoghue wrote:
> On 10/07/2024 23:10, Dmitry Baryshkov wrote:
>>>> - Why is cam_cc_gdsc_clk not modelled in the clock framework?
>>>
>>> This clock is kept enabled from probe, hence not required to be
>>> modelled
>>> explicitly.
>> Yes, I'm asking why it's kept up enabled from probe rather than via
>> clock framework?
>
> FWIW my preference is to do it as Dmitry is suggesting here.
>
> I'm not a big fan of hitting the register and leaving it as-is, would
> much prefer to move to the model of having the CCF do it - so that for
> example the clock appears in the /sys clock summary.
>
This clock is PoR ON clock and expected to be always enabled from HW
perspective, we are just re-ensuring it is ON from probe. Modelling this
clock is unnecessary, and we have been following this approach for gdsc
clock in all the recent chipsets, like for example sm8550 camcc.
> ---
> bod
next prev parent reply other threads:[~2024-07-15 10:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 15:50 [PATCH v2 0/6] clk: qcom: sm8150: Add camera clock controller support " Satya Priya Kakitapalli
2024-07-02 15:50 ` [PATCH v2 1/6] clk: qcom: alpha-pll: Fix the pll post div mask and shift Satya Priya Kakitapalli
2024-07-03 10:01 ` Dmitry Baryshkov
2024-07-02 15:50 ` [PATCH v2 2/6] clk: qcom: clk-alpha-pll: Update set_rate for Zonda PLL Satya Priya Kakitapalli
2024-07-03 10:02 ` Dmitry Baryshkov
2024-07-06 13:39 ` Konrad Dybcio
2024-07-09 10:56 ` Satya Priya Kakitapalli (Temp)
2024-07-02 15:50 ` [PATCH v2 3/6] clk: qcom: clk-alpha-pll: Add support for Regera PLL ops Satya Priya Kakitapalli
2024-07-03 10:05 ` Dmitry Baryshkov
2024-07-06 13:45 ` Konrad Dybcio
2024-07-09 10:51 ` Satya Priya Kakitapalli (Temp)
2024-07-26 8:10 ` Satya Priya Kakitapalli (Temp)
2024-07-27 10:57 ` Dmitry Baryshkov
2024-07-02 15:50 ` [PATCH v2 4/6] dt-bindings: clock: qcom: Add SM8150 camera clock controller Satya Priya Kakitapalli
2024-07-03 10:14 ` Dmitry Baryshkov
2024-07-09 10:53 ` Satya Priya Kakitapalli (Temp)
2024-07-02 15:50 ` [PATCH v2 5/6] clk: qcom: Add camera clock controller driver for SM8150 Satya Priya Kakitapalli
2024-07-03 10:20 ` Dmitry Baryshkov
2024-07-09 10:52 ` Satya Priya Kakitapalli (Temp)
2024-07-10 22:10 ` Dmitry Baryshkov
2024-07-11 9:51 ` Bryan O'Donoghue
2024-07-15 10:36 ` Satya Priya Kakitapalli (Temp) [this message]
2024-07-17 10:53 ` Bryan O'Donoghue
2024-07-17 11:08 ` Satya Priya Kakitapalli (Temp)
2024-07-15 10:22 ` Satya Priya Kakitapalli (Temp)
2024-07-15 10:38 ` Dmitry Baryshkov
2024-07-15 15:01 ` Bryan O'Donoghue
2024-07-17 6:24 ` Satya Priya Kakitapalli (Temp)
2024-07-17 11:07 ` Bryan O'Donoghue
2024-07-26 8:25 ` Satya Priya Kakitapalli (Temp)
2024-07-26 10:43 ` Dmitry Baryshkov
2024-07-02 15:50 ` [PATCH v2 6/6] arm64: dts: qcom: Add camera clock controller for sm8150 Satya Priya Kakitapalli
2024-07-03 10:08 ` [PATCH v2 0/6] clk: qcom: sm8150: Add camera clock controller support for SM8150 Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6124f9e9-3fdf-29b1-128f-c58f5ebe1424@quicinc.com \
--to=quic_skakitap@quicinc.com \
--cc=absahu@codeaurora.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®