* [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call
@ 2017-07-11 19:41 Colin King
2017-07-18 8:01 ` Juergen Gross
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-07-11 19:41 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, xen-devel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently a sock_release on map->sock will result in a null pointer
deference on map when map is null. Instead, the sock_relase sould
be on sock and not map->sock.
Detected by CoverityScan, CID#1450169 ("Dereference after null check")
Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/xen/pvcalls-back.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index d6c4c4aecb41..01b690e1e555 100644
--- a/drivers/xen/pvcalls-back.c
+++ b/drivers/xen/pvcalls-back.c
@@ -424,7 +424,7 @@ static int pvcalls_back_connect(struct xenbus_device *dev,
sock);
if (!map) {
ret = -EFAULT;
- sock_release(map->sock);
+ sock_release(sock);
}
out:
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call
2017-07-11 19:41 [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call Colin King
@ 2017-07-18 8:01 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2017-07-18 8:01 UTC (permalink / raw)
To: Colin King, Boris Ostrovsky, xen-devel; +Cc: kernel-janitors, linux-kernel
On 11/07/17 21:41, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently a sock_release on map->sock will result in a null pointer
> deference on map when map is null. Instead, the sock_relase sould
> be on sock and not map->sock.
>
> Detected by CoverityScan, CID#1450169 ("Dereference after null check")
>
> Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Committed to xen/tip for-linus-4.13
Thanks,
Juergen
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-18 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11 19:41 [PATCH][xen-next] xen/pvcalls: fix null pointer reference on sock_release call Colin King
2017-07-18 8:01 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®