From: Paul Menage <menage@google.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Ben Blum <bblum@google.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org,
lizf@cn.fujitsu.com
Subject: Re: [PATCH 6/6] Makes procs file writable to move all threads by tgid at once
Date: Mon, 3 Aug 2009 11:07:54 -0700 [thread overview]
Message-ID: <6599ad830908031107l4b924a86r423c4fedc06b0040@mail.gmail.com> (raw)
In-Reply-To: <20090803175452.GA5481@us.ibm.com>
On Mon, Aug 3, 2009 at 10:54 AM, Serge E. Hallyn<serue@us.ibm.com> wrote:
>> + if (guarantee) {
>> + /*
>> + * our caller promises us that the css_set we want already
>> + * exists, so we use find_existing_css_set directly.
>> + */
>> + struct cgroup_subsys_state *template[CGROUP_SUBSYS_COUNT];
>> + read_lock(&css_set_lock);
>> + newcg = find_existing_css_set(oldcg, cgrp, template);
>> + BUG_ON(!newcg);
>> + get_css_set(newcg);
>> + read_unlock(&css_set_lock);
>> + } else {
>> + might_sleep();
>
> So cgroup_task_migrate() might sleep, but
>
might sleep if guarantee==0
>> + retval = cgroup_task_migrate(cgrp, oldcgrp, tsk, 1);
>
> Here it is called under rcu_read_lock().
With guarantee==1
>
> What *exactly* is it we are protecting with cgroup_fork_mutex?
> 'fork' (as the name implies) is not a good answer, since we should be
> protecting data, not code. If it is solely tsk->cgroups, then perhaps
> we should in fact try switching to (s?)rcu. Then cgroup_fork() could
> just do rcu_read_lock, while cgroup_task_migrate() would make the change
> under a spinlock (to protect against concurrent cgroup_task_migrate()s),
> and using rcu_assign_pointer to let cgroup_fork() see consistent data
> either before or after the update... That might mean that any checks done
> before completing the migrate which involve the # of tasks might become
> invalidated before the migration completes?
What's being protected is the ability to move an entire thread group
to the new destination cgroup, even in the presence of concurrent
thread clone operations. New threads aren't visible to other threads
until the point when they're attached to the tasklist, so if any
concurrent do_fork() operation is somewhere between the call to
cgroup_fork() and the attachment to the tasklist when the "attach proc
to new cgroup" operation occurs, it may get left behind.
Paul
next prev parent reply other threads:[~2009-08-03 18:08 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 1:51 [PATCH v2 0/6] CGroups: cgroup memberlist enhancement+fix Ben Blum
2009-07-31 1:51 ` [PATCH 1/6] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Ben Blum
2009-07-31 1:51 ` [PATCH 2/6] Ensures correct concurrent opening/reading of pidlists across pid namespaces Ben Blum
2009-07-31 1:51 ` [PATCH 3/6] Quick vmalloc vs kmalloc fix to the case where array size is too large Ben Blum
2009-07-31 1:51 ` [PATCH 4/6] Changes css_set freeing mechanism to be under RCU Ben Blum
2009-07-31 1:51 ` [PATCH 5/6] Lets ss->can_attach and ss->attach do whole threadgroups at a time Ben Blum
2009-08-03 2:22 ` Li Zefan
2009-08-04 0:35 ` Benjamin Blum
2009-07-31 1:51 ` [PATCH 6/6] Makes procs file writable to move all threads by tgid at once Ben Blum
2009-08-03 3:00 ` Li Zefan
2009-08-04 0:56 ` Benjamin Blum
2009-08-04 1:05 ` Paul Menage
2009-08-04 1:11 ` Benjamin Blum
2009-08-04 1:09 ` Li Zefan
2009-08-04 1:19 ` Benjamin Blum
2009-08-04 1:45 ` Li Zefan
2009-08-04 1:55 ` Paul Menage
2009-08-03 17:54 ` Serge E. Hallyn
2009-08-03 18:07 ` Paul Menage [this message]
2009-08-03 18:13 ` Benjamin Blum
2009-08-03 18:55 ` Serge E. Hallyn
2009-08-03 19:45 ` Serge E. Hallyn
2009-08-03 19:55 ` Paul Menage
2009-08-04 14:01 ` Serge E. Hallyn
2009-08-04 21:40 ` Matt Helsley
2009-08-04 18:48 ` Paul Menage
2009-08-04 19:01 ` Serge E. Hallyn
2009-08-04 19:14 ` Benjamin Blum
2009-08-04 19:28 ` Paul Menage
2009-08-05 10:20 ` Louis Rilling
2009-08-05 16:11 ` Paul Menage
2009-08-05 16:42 ` Louis Rilling
2009-08-05 16:53 ` Peter Zijlstra
2009-08-06 0:01 ` Benjamin Blum
2009-08-06 9:58 ` Louis Rilling
2009-08-06 10:04 ` Louis Rilling
2009-08-06 10:28 ` Paul Menage
2009-08-06 10:34 ` Peter Zijlstra
2009-08-06 10:42 ` Paul Menage
2009-08-06 11:02 ` Peter Zijlstra
2009-08-06 11:24 ` Paul Menage
2009-08-06 11:39 ` Peter Zijlstra
2009-08-06 15:19 ` Paul E. McKenney
2009-08-06 15:24 ` Peter Zijlstra
2009-08-06 15:37 ` Paul E. McKenney
2009-08-06 11:24 ` Louis Rilling
2009-08-06 11:40 ` Paul Menage
2009-08-06 14:54 ` Louis Rilling
2009-08-08 1:41 ` Benjamin Blum
2009-08-08 1:51 ` Benjamin Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830908031107l4b924a86r423c4fedc06b0040@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@google.com \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®