* [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-02 11:49 [PATCH 0/4] drm/msm: Assorted fixes and changes Akhil P Oommen
@ 2025-09-02 11:50 ` Akhil P Oommen
2025-09-02 12:27 ` Dmitry Baryshkov
2025-09-02 15:55 ` Rob Clark
2025-09-02 11:50 ` [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser Akhil P Oommen
` (2 subsequent siblings)
3 siblings, 2 replies; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 11:50 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Akhil P Oommen
The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
drm_gem_obj.gpuva.list, which is not initialized when the drm driver
does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
is set:
[ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
[ 9.523160] Mem abort info:
[ 9.523161] ESR = 0x0000000096000006
[ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
[ 9.523165] SET = 0, FnV = 0
[ 9.523166] EA = 0, S1PTW = 0
[ 9.523167] FSC = 0x06: level 2 translation fault
[ 9.523169] Data abort info:
[ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
[ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
[ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
[ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
[ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
[ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
[ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
[ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
[ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
[ 9.763632] sp : ffff800082dab460
[ 9.763666] Call trace:
[ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
[ 9.763688] get_vma_locked+0x2c/0x128 [msm]
[ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
[ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
[ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
[ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
[ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
[ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
[ 9.763782] drm_client_register+0x58/0x9c [drm]
[ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
[ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
[ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
[ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
[ 9.763848] msm_drm_bind+0x30/0x3c [msm]
[ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
[ 9.919283] __component_add+0xa4/0x170
[ 9.919286] component_add+0x14/0x20
[ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
[ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
[ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
[ 9.919341] really_probe+0xbc/0x298
[ 9.919345] __driver_probe_device+0x78/0x12c
[ 9.919348] driver_probe_device+0x40/0x160
[ 9.919350] __driver_attach+0x94/0x19c
[ 9.919353] bus_for_each_dev+0x74/0xd4
[ 9.919355] driver_attach+0x24/0x30
[ 9.919358] bus_add_driver+0xe4/0x208
[ 9.919360] driver_register+0x60/0x128
[ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
[ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
[ 9.919370] do_one_initcall+0x6c/0x1b0
[ 9.919374] do_init_module+0x58/0x234
[ 9.919377] load_module+0x19cc/0x1bd4
[ 9.919380] init_module_from_file+0x84/0xc4
[ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
[ 9.919384] invoke_syscall+0x48/0x110
[ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
[ 9.919393] do_el0_svc+0x20/0x2c
[ 9.919396] el0_svc+0x34/0xf0
[ 9.919401] el0t_64_sync_handler+0xa0/0xe4
[ 9.919403] el0t_64_sync+0x198/0x19c
[ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
[ 9.919410] ---[ end trace 0000000000000000 ]---
Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
drivers/gpu/drm/msm/msm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097a01c2b2556608 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -826,6 +826,7 @@ static const struct file_operations fops = {
#define DRIVER_FEATURES_KMS ( \
DRIVER_GEM | \
+ DRIVER_GEM_GPUVA | \
DRIVER_ATOMIC | \
DRIVER_MODESET | \
0 )
--
2.50.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-02 11:50 ` [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Akhil P Oommen
@ 2025-09-02 12:27 ` Dmitry Baryshkov
2025-09-02 13:16 ` Akhil P Oommen
2025-09-02 15:55 ` Rob Clark
1 sibling, 1 reply; 19+ messages in thread
From: Dmitry Baryshkov @ 2025-09-02 12:27 UTC (permalink / raw)
To: Akhil P Oommen
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On Tue, Sep 02, 2025 at 05:20:00PM +0530, Akhil P Oommen wrote:
> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
> drm_gem_obj.gpuva.list, which is not initialized when the drm driver
> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
> is set:
>
> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
> [ 9.523160] Mem abort info:
> [ 9.523161] ESR = 0x0000000096000006
> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
> [ 9.523165] SET = 0, FnV = 0
> [ 9.523166] EA = 0, S1PTW = 0
> [ 9.523167] FSC = 0x06: level 2 translation fault
> [ 9.523169] Data abort info:
> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
> [ 9.763632] sp : ffff800082dab460
> [ 9.763666] Call trace:
> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
> [ 9.763688] get_vma_locked+0x2c/0x128 [msm]
> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
> [ 9.763782] drm_client_register+0x58/0x9c [drm]
> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
> [ 9.763848] msm_drm_bind+0x30/0x3c [msm]
> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
> [ 9.919283] __component_add+0xa4/0x170
> [ 9.919286] component_add+0x14/0x20
> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
> [ 9.919341] really_probe+0xbc/0x298
> [ 9.919345] __driver_probe_device+0x78/0x12c
> [ 9.919348] driver_probe_device+0x40/0x160
> [ 9.919350] __driver_attach+0x94/0x19c
> [ 9.919353] bus_for_each_dev+0x74/0xd4
> [ 9.919355] driver_attach+0x24/0x30
> [ 9.919358] bus_add_driver+0xe4/0x208
> [ 9.919360] driver_register+0x60/0x128
> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
> [ 9.919370] do_one_initcall+0x6c/0x1b0
> [ 9.919374] do_init_module+0x58/0x234
> [ 9.919377] load_module+0x19cc/0x1bd4
> [ 9.919380] init_module_from_file+0x84/0xc4
> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
> [ 9.919384] invoke_syscall+0x48/0x110
> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
> [ 9.919393] do_el0_svc+0x20/0x2c
> [ 9.919396] el0_svc+0x34/0xf0
> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4
> [ 9.919403] el0t_64_sync+0x198/0x19c
> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
> [ 9.919410] ---[ end trace 0000000000000000 ]---
Nit: usually you can drop timestamps from the kernel log.
>
> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-02 12:27 ` Dmitry Baryshkov
@ 2025-09-02 13:16 ` Akhil P Oommen
0 siblings, 0 replies; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 13:16 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On 9/2/2025 5:57 PM, Dmitry Baryshkov wrote:
> On Tue, Sep 02, 2025 at 05:20:00PM +0530, Akhil P Oommen wrote:
>> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
>> drm_gem_obj.gpuva.list, which is not initialized when the drm driver
>> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
>> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
>> is set:
>>
>> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
>> [ 9.523160] Mem abort info:
>> [ 9.523161] ESR = 0x0000000096000006
>> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
>> [ 9.523165] SET = 0, FnV = 0
>> [ 9.523166] EA = 0, S1PTW = 0
>> [ 9.523167] FSC = 0x06: level 2 translation fault
>> [ 9.523169] Data abort info:
>> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
>> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
>> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
>> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
>> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
>> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
>> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
>> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
>> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
>> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
>> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
>> [ 9.763632] sp : ffff800082dab460
>> [ 9.763666] Call trace:
>> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
>> [ 9.763688] get_vma_locked+0x2c/0x128 [msm]
>> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
>> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
>> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
>> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
>> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
>> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
>> [ 9.763782] drm_client_register+0x58/0x9c [drm]
>> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
>> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
>> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
>> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
>> [ 9.763848] msm_drm_bind+0x30/0x3c [msm]
>> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
>> [ 9.919283] __component_add+0xa4/0x170
>> [ 9.919286] component_add+0x14/0x20
>> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
>> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
>> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
>> [ 9.919341] really_probe+0xbc/0x298
>> [ 9.919345] __driver_probe_device+0x78/0x12c
>> [ 9.919348] driver_probe_device+0x40/0x160
>> [ 9.919350] __driver_attach+0x94/0x19c
>> [ 9.919353] bus_for_each_dev+0x74/0xd4
>> [ 9.919355] driver_attach+0x24/0x30
>> [ 9.919358] bus_add_driver+0xe4/0x208
>> [ 9.919360] driver_register+0x60/0x128
>> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
>> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
>> [ 9.919370] do_one_initcall+0x6c/0x1b0
>> [ 9.919374] do_init_module+0x58/0x234
>> [ 9.919377] load_module+0x19cc/0x1bd4
>> [ 9.919380] init_module_from_file+0x84/0xc4
>> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
>> [ 9.919384] invoke_syscall+0x48/0x110
>> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
>> [ 9.919393] do_el0_svc+0x20/0x2c
>> [ 9.919396] el0_svc+0x34/0xf0
>> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4
>> [ 9.919403] el0t_64_sync+0x198/0x19c
>> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
>> [ 9.919410] ---[ end trace 0000000000000000 ]---
>
> Nit: usually you can drop timestamps from the kernel log.
Missed my eyes. Will update in v2.
-Akhil.
>
>>
>> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
>> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/msm_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-02 11:50 ` [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Akhil P Oommen
2025-09-02 12:27 ` Dmitry Baryshkov
@ 2025-09-02 15:55 ` Rob Clark
2025-09-08 15:42 ` Akhil P Oommen
1 sibling, 1 reply; 19+ messages in thread
From: Rob Clark @ 2025-09-02 15:55 UTC (permalink / raw)
To: Akhil P Oommen
Cc: Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Konrad Dybcio,
Jordan Crouse, Jonathan Marek, Dmitry Baryshkov, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On Tue, Sep 2, 2025 at 4:50 AM Akhil P Oommen <akhilpo@oss.qualcomm.com> wrote:
>
> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
> drm_gem_obj.gpuva.list, which is not initialized when the drm driver
> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
> is set:
>
> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
> [ 9.523160] Mem abort info:
> [ 9.523161] ESR = 0x0000000096000006
> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
> [ 9.523165] SET = 0, FnV = 0
> [ 9.523166] EA = 0, S1PTW = 0
> [ 9.523167] FSC = 0x06: level 2 translation fault
> [ 9.523169] Data abort info:
> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
> [ 9.763632] sp : ffff800082dab460
> [ 9.763666] Call trace:
> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
> [ 9.763688] get_vma_locked+0x2c/0x128 [msm]
> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
> [ 9.763782] drm_client_register+0x58/0x9c [drm]
> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
> [ 9.763848] msm_drm_bind+0x30/0x3c [msm]
> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
> [ 9.919283] __component_add+0xa4/0x170
> [ 9.919286] component_add+0x14/0x20
> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
> [ 9.919341] really_probe+0xbc/0x298
> [ 9.919345] __driver_probe_device+0x78/0x12c
> [ 9.919348] driver_probe_device+0x40/0x160
> [ 9.919350] __driver_attach+0x94/0x19c
> [ 9.919353] bus_for_each_dev+0x74/0xd4
> [ 9.919355] driver_attach+0x24/0x30
> [ 9.919358] bus_add_driver+0xe4/0x208
> [ 9.919360] driver_register+0x60/0x128
> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
> [ 9.919370] do_one_initcall+0x6c/0x1b0
> [ 9.919374] do_init_module+0x58/0x234
> [ 9.919377] load_module+0x19cc/0x1bd4
> [ 9.919380] init_module_from_file+0x84/0xc4
> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
> [ 9.919384] invoke_syscall+0x48/0x110
> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
> [ 9.919393] do_el0_svc+0x20/0x2c
> [ 9.919396] el0_svc+0x34/0xf0
> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4
> [ 9.919403] el0t_64_sync+0x198/0x19c
> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
> [ 9.919410] ---[ end trace 0000000000000000 ]---
>
> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097a01c2b2556608 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -826,6 +826,7 @@ static const struct file_operations fops = {
>
> #define DRIVER_FEATURES_KMS ( \
> DRIVER_GEM | \
> + DRIVER_GEM_GPUVA | \
Hmm, the description of DRIVER_GEM_GPUVA is that "Driver supports user
defined GPU VA bindings for GEM objects", which isn't really true.
Fortunately the only thing that it actually seems to control currently
is the list head initialization.
Idk if it would be better to make the list head init unconditional, or
just add a comment here?
BR,
-R
> DRIVER_ATOMIC | \
> DRIVER_MODESET | \
> 0 )
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-02 15:55 ` Rob Clark
@ 2025-09-08 15:42 ` Akhil P Oommen
2025-09-08 16:19 ` Rob Clark
0 siblings, 1 reply; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-08 15:42 UTC (permalink / raw)
To: rob.clark
Cc: Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Konrad Dybcio,
Jordan Crouse, Jonathan Marek, Dmitry Baryshkov, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On 9/2/2025 9:25 PM, Rob Clark wrote:
> On Tue, Sep 2, 2025 at 4:50 AM Akhil P Oommen <akhilpo@oss.qualcomm.com> wrote:
>>
>> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
>> drm_gem_obj.gpuva.list, which is not initialized when the drm driver
>> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
>> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
>> is set:
>>
>> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
>> [ 9.523160] Mem abort info:
>> [ 9.523161] ESR = 0x0000000096000006
>> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
>> [ 9.523165] SET = 0, FnV = 0
>> [ 9.523166] EA = 0, S1PTW = 0
>> [ 9.523167] FSC = 0x06: level 2 translation fault
>> [ 9.523169] Data abort info:
>> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
>> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
>> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
>> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
>> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
>> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
>> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
>> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
>> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
>> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
>> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
>> [ 9.763632] sp : ffff800082dab460
>> [ 9.763666] Call trace:
>> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
>> [ 9.763688] get_vma_locked+0x2c/0x128 [msm]
>> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
>> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
>> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
>> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
>> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
>> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
>> [ 9.763782] drm_client_register+0x58/0x9c [drm]
>> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
>> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
>> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
>> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
>> [ 9.763848] msm_drm_bind+0x30/0x3c [msm]
>> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
>> [ 9.919283] __component_add+0xa4/0x170
>> [ 9.919286] component_add+0x14/0x20
>> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
>> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
>> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
>> [ 9.919341] really_probe+0xbc/0x298
>> [ 9.919345] __driver_probe_device+0x78/0x12c
>> [ 9.919348] driver_probe_device+0x40/0x160
>> [ 9.919350] __driver_attach+0x94/0x19c
>> [ 9.919353] bus_for_each_dev+0x74/0xd4
>> [ 9.919355] driver_attach+0x24/0x30
>> [ 9.919358] bus_add_driver+0xe4/0x208
>> [ 9.919360] driver_register+0x60/0x128
>> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
>> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
>> [ 9.919370] do_one_initcall+0x6c/0x1b0
>> [ 9.919374] do_init_module+0x58/0x234
>> [ 9.919377] load_module+0x19cc/0x1bd4
>> [ 9.919380] init_module_from_file+0x84/0xc4
>> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
>> [ 9.919384] invoke_syscall+0x48/0x110
>> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
>> [ 9.919393] do_el0_svc+0x20/0x2c
>> [ 9.919396] el0_svc+0x34/0xf0
>> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4
>> [ 9.919403] el0t_64_sync+0x198/0x19c
>> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
>> [ 9.919410] ---[ end trace 0000000000000000 ]---
>>
>> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
>> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/msm_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
>> index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097a01c2b2556608 100644
>> --- a/drivers/gpu/drm/msm/msm_drv.c
>> +++ b/drivers/gpu/drm/msm/msm_drv.c
>> @@ -826,6 +826,7 @@ static const struct file_operations fops = {
>>
>> #define DRIVER_FEATURES_KMS ( \
>> DRIVER_GEM | \
>> + DRIVER_GEM_GPUVA | \
>
> Hmm, the description of DRIVER_GEM_GPUVA is that "Driver supports user
> defined GPU VA bindings for GEM objects", which isn't really true.
> Fortunately the only thing that it actually seems to control currently
> is the list head initialization.
>
> Idk if it would be better to make the list head init unconditional, or
> just add a comment here?
But the KMS-only drm driver do use symbols related to gpuva. "struct
gpuva" for eg:. From that perspective, shouldn't we select this feature
here?
-Akhil
>
> BR,
> -R
>
>> DRIVER_ATOMIC | \
>> DRIVER_MODESET | \
>> 0 )
>>
>> --
>> 2.50.1
>>
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam
2025-09-08 15:42 ` Akhil P Oommen
@ 2025-09-08 16:19 ` Rob Clark
0 siblings, 0 replies; 19+ messages in thread
From: Rob Clark @ 2025-09-08 16:19 UTC (permalink / raw)
To: Akhil P Oommen
Cc: Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter, Konrad Dybcio,
Jordan Crouse, Jonathan Marek, Dmitry Baryshkov, linux-arm-msm,
dri-devel, freedreno, linux-kernel
On Mon, Sep 8, 2025 at 8:42 AM Akhil P Oommen <akhilpo@oss.qualcomm.com> wrote:
>
> On 9/2/2025 9:25 PM, Rob Clark wrote:
> > On Tue, Sep 2, 2025 at 4:50 AM Akhil P Oommen <akhilpo@oss.qualcomm.com> wrote:
> >>
> >> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses
> >> drm_gem_obj.gpuva.list, which is not initialized when the drm driver
> >> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms
> >> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam
> >> is set:
> >>
> >> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0
> >> [ 9.523160] Mem abort info:
> >> [ 9.523161] ESR = 0x0000000096000006
> >> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits
> >> [ 9.523165] SET = 0, FnV = 0
> >> [ 9.523166] EA = 0, S1PTW = 0
> >> [ 9.523167] FSC = 0x06: level 2 translation fault
> >> [ 9.523169] Data abort info:
> >> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000
> >> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
> >> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
> >> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000
> >> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000
> >> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP
> >> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT
> >> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024
> >> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
> >> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm]
> >> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm]
> >> [ 9.763632] sp : ffff800082dab460
> >> [ 9.763666] Call trace:
> >> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P)
> >> [ 9.763688] get_vma_locked+0x2c/0x128 [msm]
> >> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm]
> >> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm]
> >> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm]
> >> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper]
> >> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper]
> >> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib]
> >> [ 9.763782] drm_client_register+0x58/0x9c [drm]
> >> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib]
> >> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib]
> >> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm]
> >> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm]
> >> [ 9.763848] msm_drm_bind+0x30/0x3c [msm]
> >> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4
> >> [ 9.919283] __component_add+0xa4/0x170
> >> [ 9.919286] component_add+0x14/0x20
> >> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm]
> >> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm]
> >> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus]
> >> [ 9.919341] really_probe+0xbc/0x298
> >> [ 9.919345] __driver_probe_device+0x78/0x12c
> >> [ 9.919348] driver_probe_device+0x40/0x160
> >> [ 9.919350] __driver_attach+0x94/0x19c
> >> [ 9.919353] bus_for_each_dev+0x74/0xd4
> >> [ 9.919355] driver_attach+0x24/0x30
> >> [ 9.919358] bus_add_driver+0xe4/0x208
> >> [ 9.919360] driver_register+0x60/0x128
> >> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus]
> >> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20]
> >> [ 9.919370] do_one_initcall+0x6c/0x1b0
> >> [ 9.919374] do_init_module+0x58/0x234
> >> [ 9.919377] load_module+0x19cc/0x1bd4
> >> [ 9.919380] init_module_from_file+0x84/0xc4
> >> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc
> >> [ 9.919384] invoke_syscall+0x48/0x110
> >> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8
> >> [ 9.919393] do_el0_svc+0x20/0x2c
> >> [ 9.919396] el0_svc+0x34/0xf0
> >> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4
> >> [ 9.919403] el0t_64_sync+0x198/0x19c
> >> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44)
> >> [ 9.919410] ---[ end trace 0000000000000000 ]---
> >>
> >> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices")
> >> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> >> ---
> >> drivers/gpu/drm/msm/msm_drv.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> >> index 9dcc7a596a11d9342a515dab694bac93dc2805cb..7e977fec4100792394dccf59097a01c2b2556608 100644
> >> --- a/drivers/gpu/drm/msm/msm_drv.c
> >> +++ b/drivers/gpu/drm/msm/msm_drv.c
> >> @@ -826,6 +826,7 @@ static const struct file_operations fops = {
> >>
> >> #define DRIVER_FEATURES_KMS ( \
> >> DRIVER_GEM | \
> >> + DRIVER_GEM_GPUVA | \
> >
> > Hmm, the description of DRIVER_GEM_GPUVA is that "Driver supports user
> > defined GPU VA bindings for GEM objects", which isn't really true.
> > Fortunately the only thing that it actually seems to control currently
> > is the list head initialization.
> >
> > Idk if it would be better to make the list head init unconditional, or
> > just add a comment here?
>
> But the KMS-only drm driver do use symbols related to gpuva. "struct
> gpuva" for eg:. From that perspective, shouldn't we select this feature
> here?
Based on how DRIVER_GEM_GPUVA is currently used (ie. not exposed to
userspace, etc) this is fine. Maybe the comment describing
DRIVER_GEM_GPUVA should be updated to something along the lines of
"Driver uses the drm_gpuvm infrastructure" instead of "Driver supports
user defined GPU VA bindings for GEM object"
BR,
-R
> -Akhil
>
> >
> > BR,
> > -R
> >
> >> DRIVER_ATOMIC | \
> >> DRIVER_MODESET | \
> >> 0 )
> >>
> >> --
> >> 2.50.1
> >>
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser
2025-09-02 11:49 [PATCH 0/4] drm/msm: Assorted fixes and changes Akhil P Oommen
2025-09-02 11:50 ` [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Akhil P Oommen
@ 2025-09-02 11:50 ` Akhil P Oommen
2025-09-02 12:29 ` Konrad Dybcio
2025-09-02 11:50 ` [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU Akhil P Oommen
2025-09-02 11:50 ` [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe() Akhil P Oommen
3 siblings, 1 reply; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 11:50 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Akhil P Oommen
Current parser logic for GMU firmware assumes a dword aligned payload
size for every block. This is not true for all GMU firmwares. So, fix
this by using correct 'size' value in the calculation for the offset
for the next block's header.
Fixes: c6ed04f856a4 ("drm/msm/a6xx: A640/A650 GMU firmware path")
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index 28e6705c6da682c7b41c748e375dda59a6551898..ea52374c9fcd481d816ed9608e9f6eb1c2e3005a 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -758,6 +758,8 @@ static bool fw_block_mem(struct a6xx_gmu_bo *bo, const struct block_header *blk)
return true;
}
+#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + sizeof(*blk) + blk->size))
+
static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu)
{
struct a6xx_gpu *a6xx_gpu = container_of(gmu, struct a6xx_gpu, gmu);
@@ -789,7 +791,7 @@ static int a6xx_gmu_fw_load(struct a6xx_gmu *gmu)
for (blk = (const struct block_header *) fw_image->data;
(const u8*) blk < fw_image->data + fw_image->size;
- blk = (const struct block_header *) &blk->data[blk->size >> 2]) {
+ blk = NEXT_BLK(blk)) {
if (blk->size == 0)
continue;
--
2.50.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser
2025-09-02 11:50 ` [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser Akhil P Oommen
@ 2025-09-02 12:29 ` Konrad Dybcio
2025-09-02 13:21 ` Akhil P Oommen
0 siblings, 1 reply; 19+ messages in thread
From: Konrad Dybcio @ 2025-09-02 12:29 UTC (permalink / raw)
To: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> Current parser logic for GMU firmware assumes a dword aligned payload
> size for every block. This is not true for all GMU firmwares. So, fix
> this by using correct 'size' value in the calculation for the offset
> for the next block's header.
Hm, I haven't seen this in the wild - do you have any specific examples?
>
> Fixes: c6ed04f856a4 ("drm/msm/a6xx: A640/A650 GMU firmware path")
> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 28e6705c6da682c7b41c748e375dda59a6551898..ea52374c9fcd481d816ed9608e9f6eb1c2e3005a 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -758,6 +758,8 @@ static bool fw_block_mem(struct a6xx_gmu_bo *bo, const struct block_header *blk)
> return true;
> }
>
> +#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + sizeof(*blk) + blk->size))
CHECK: Macro argument 'blk' may be better as '(blk)' to avoid precedence issues
#146: FILE: drivers/gpu/drm/msm/adreno/a6xx_gmu.c:761:
+#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + sizeof(*blk) + blk->size))
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser
2025-09-02 12:29 ` Konrad Dybcio
@ 2025-09-02 13:21 ` Akhil P Oommen
0 siblings, 0 replies; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 13:21 UTC (permalink / raw)
To: Konrad Dybcio, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/2025 5:59 PM, Konrad Dybcio wrote:
> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
>> Current parser logic for GMU firmware assumes a dword aligned payload
>> size for every block. This is not true for all GMU firmwares. So, fix
>> this by using correct 'size' value in the calculation for the offset
>> for the next block's header.
>
> Hm, I haven't seen this in the wild - do you have any specific examples?
I saw this in an unreleased chipset's fw. But felt it might show up in
newer gmu fw versions of older chipsets too.
>
>>
>> Fixes: c6ed04f856a4 ("drm/msm/a6xx: A640/A650 GMU firmware path")
>> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> index 28e6705c6da682c7b41c748e375dda59a6551898..ea52374c9fcd481d816ed9608e9f6eb1c2e3005a 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>> @@ -758,6 +758,8 @@ static bool fw_block_mem(struct a6xx_gmu_bo *bo, const struct block_header *blk)
>> return true;
>> }
>>
>> +#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + sizeof(*blk) + blk->size))
>
> CHECK: Macro argument 'blk' may be better as '(blk)' to avoid precedence issues
> #146: FILE: drivers/gpu/drm/msm/adreno/a6xx_gmu.c:761:
> +#define NEXT_BLK(blk) ((const struct block_header *)((const char *)blk + sizeof(*blk) + blk->size))
Ack. Thanks.
-Akhil.
>
> Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU
2025-09-02 11:49 [PATCH 0/4] drm/msm: Assorted fixes and changes Akhil P Oommen
2025-09-02 11:50 ` [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam Akhil P Oommen
2025-09-02 11:50 ` [PATCH 2/4] drm/msm/a6xx: Fix GMU firmware parser Akhil P Oommen
@ 2025-09-02 11:50 ` Akhil P Oommen
2025-09-02 12:30 ` Konrad Dybcio
2025-09-02 11:50 ` [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe() Akhil P Oommen
3 siblings, 1 reply; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 11:50 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Akhil P Oommen
During bringup of a new GPU support, it is convenient to have knob to
quickly disable GPU, but keep the display support. This helps to
fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a
modparam to support this.
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 50945bfe9b4992118f23db3cd17ac348be9f9c9d..28f744f3caf7c59412aab06f912cd09a01e185ea 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -24,6 +24,10 @@ bool disable_acd;
MODULE_PARM_DESC(disable_acd, "Forcefully disable GPU ACD");
module_param_unsafe(disable_acd, bool, 0400);
+static bool skip_gpu;
+MODULE_PARM_DESC(no_gpu, "Disable GPU driver register (0=enable GPU driver register (default), 1=skip GPU driver register");
+module_param(skip_gpu, bool, 0400);
+
extern const struct adreno_gpulist a2xx_gpulist;
extern const struct adreno_gpulist a3xx_gpulist;
extern const struct adreno_gpulist a4xx_gpulist;
@@ -184,6 +188,9 @@ bool adreno_has_gpu(struct device_node *node)
uint32_t chip_id;
int ret;
+ if (skip_gpu)
+ return false;
+
ret = find_chipid(node, &chip_id);
if (ret)
return false;
@@ -404,10 +411,16 @@ static struct platform_driver adreno_driver = {
void __init adreno_register(void)
{
+ if (skip_gpu)
+ return;
+
platform_driver_register(&adreno_driver);
}
void __exit adreno_unregister(void)
{
+ if (skip_gpu)
+ return;
+
platform_driver_unregister(&adreno_driver);
}
--
2.50.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU
2025-09-02 11:50 ` [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU Akhil P Oommen
@ 2025-09-02 12:30 ` Konrad Dybcio
2025-09-02 13:02 ` Dmitry Baryshkov
0 siblings, 1 reply; 19+ messages in thread
From: Konrad Dybcio @ 2025-09-02 12:30 UTC (permalink / raw)
To: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> During bringup of a new GPU support, it is convenient to have knob to
> quickly disable GPU, but keep the display support. This helps to
> fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a
> modparam to support this.
I'm not entirely opposed, but slapping a // in front of the compatible
in the dt works just as well
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU
2025-09-02 12:30 ` Konrad Dybcio
@ 2025-09-02 13:02 ` Dmitry Baryshkov
2025-09-03 9:25 ` Konrad Dybcio
0 siblings, 1 reply; 19+ messages in thread
From: Dmitry Baryshkov @ 2025-09-02 13:02 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On Tue, Sep 02, 2025 at 02:30:48PM +0200, Konrad Dybcio wrote:
> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> > During bringup of a new GPU support, it is convenient to have knob to
> > quickly disable GPU, but keep the display support. This helps to
> > fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a
> > modparam to support this.
>
> I'm not entirely opposed, but slapping a // in front of the compatible
> in the dt works just as well
Which requires rebuilding and reprovisioning
>
> Konrad
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU
2025-09-02 13:02 ` Dmitry Baryshkov
@ 2025-09-03 9:25 ` Konrad Dybcio
2025-09-03 9:35 ` Dmitry Baryshkov
0 siblings, 1 reply; 19+ messages in thread
From: Konrad Dybcio @ 2025-09-03 9:25 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/25 3:02 PM, Dmitry Baryshkov wrote:
> On Tue, Sep 02, 2025 at 02:30:48PM +0200, Konrad Dybcio wrote:
>> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
>>> During bringup of a new GPU support, it is convenient to have knob to
>>> quickly disable GPU, but keep the display support. This helps to
>>> fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a
>>> modparam to support this.
>>
>> I'm not entirely opposed, but slapping a // in front of the compatible
>> in the dt works just as well
>
> Which requires rebuilding and reprovisioning
Fair
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU
2025-09-03 9:25 ` Konrad Dybcio
@ 2025-09-03 9:35 ` Dmitry Baryshkov
0 siblings, 0 replies; 19+ messages in thread
From: Dmitry Baryshkov @ 2025-09-03 9:35 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On Wed, Sep 03, 2025 at 11:25:49AM +0200, Konrad Dybcio wrote:
> On 9/2/25 3:02 PM, Dmitry Baryshkov wrote:
> > On Tue, Sep 02, 2025 at 02:30:48PM +0200, Konrad Dybcio wrote:
> >> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> >>> During bringup of a new GPU support, it is convenient to have knob to
> >>> quickly disable GPU, but keep the display support. This helps to
> >>> fallback to 'kms_swrast' in case of bootup issues due to GPU. Add a
> >>> modparam to support this.
> >>
> >> I'm not entirely opposed, but slapping a // in front of the compatible
> >> in the dt works just as well
> >
> > Which requires rebuilding and reprovisioning
>
> Fair
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe()
2025-09-02 11:49 [PATCH 0/4] drm/msm: Assorted fixes and changes Akhil P Oommen
` (2 preceding siblings ...)
2025-09-02 11:50 ` [PATCH 3/4] drm/msm/adreno: Add a modparam to skip GPU Akhil P Oommen
@ 2025-09-02 11:50 ` Akhil P Oommen
2025-09-02 12:33 ` Konrad Dybcio
3 siblings, 1 reply; 19+ messages in thread
From: Akhil P Oommen @ 2025-09-02 11:50 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Akhil P Oommen
It is not obvious why we can skip error checking of
dev_pm_opp_find_freq_exact() API. Add a comment explaining it.
Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c4c49e2bfd5dc7 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
@@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
u32 val;
freq = gmu->gpu_freqs[i];
+ /* This is unlikely to fail because we are passing back a known freq */
opp = dev_pm_opp_find_freq_exact(&gpu->pdev->dev, freq, true);
np = dev_pm_opp_get_of_node(opp);
--
2.50.1
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe()
2025-09-02 11:50 ` [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe() Akhil P Oommen
@ 2025-09-02 12:33 ` Konrad Dybcio
2025-09-02 15:57 ` Rob Clark
0 siblings, 1 reply; 19+ messages in thread
From: Konrad Dybcio @ 2025-09-02 12:33 UTC (permalink / raw)
To: Akhil P Oommen, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Konrad Dybcio, Jordan Crouse, Jonathan Marek
Cc: Dmitry Baryshkov, linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> It is not obvious why we can skip error checking of
> dev_pm_opp_find_freq_exact() API. Add a comment explaining it.
>
> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c4c49e2bfd5dc7 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
> u32 val;
>
> freq = gmu->gpu_freqs[i];
> + /* This is unlikely to fail because we are passing back a known freq */
This could probably mention that known == we just retrieved it a couple
function calls above, but I suppose the reader can come up with such
conclusions
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe()
2025-09-02 12:33 ` Konrad Dybcio
@ 2025-09-02 15:57 ` Rob Clark
2025-09-03 9:26 ` Konrad Dybcio
0 siblings, 1 reply; 19+ messages in thread
From: Rob Clark @ 2025-09-02 15:57 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek, Dmitry Baryshkov,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On Tue, Sep 2, 2025 at 5:33 AM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
> > It is not obvious why we can skip error checking of
> > dev_pm_opp_find_freq_exact() API. Add a comment explaining it.
> >
> > Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
> > ---
> > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> > index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c4c49e2bfd5dc7 100644
> > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> > @@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
> > u32 val;
> >
> > freq = gmu->gpu_freqs[i];
> > + /* This is unlikely to fail because we are passing back a known freq */
>
> This could probably mention that known == we just retrieved it a couple
> function calls above, but I suppose the reader can come up with such
> conclusions
Also, I think s/unlikely/not expected/ ? "Unlikely" implies that it
could still happen..
BR,
-R
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 4/4] drm/msm/a6xx: Add a comment to acd_probe()
2025-09-02 15:57 ` Rob Clark
@ 2025-09-03 9:26 ` Konrad Dybcio
0 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2025-09-03 9:26 UTC (permalink / raw)
To: rob.clark
Cc: Akhil P Oommen, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Konrad Dybcio, Jordan Crouse, Jonathan Marek, Dmitry Baryshkov,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 9/2/25 5:57 PM, Rob Clark wrote:
> On Tue, Sep 2, 2025 at 5:33 AM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 9/2/25 1:50 PM, Akhil P Oommen wrote:
>>> It is not obvious why we can skip error checking of
>>> dev_pm_opp_find_freq_exact() API. Add a comment explaining it.
>>>
>>> Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
>>> ---
>>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> index ea52374c9fcd481d816ed9608e9f6eb1c2e3005a..de8f7051402bf0fd931fc065b5c4c49e2bfd5dc7 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> @@ -1694,6 +1694,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
>>> u32 val;
>>>
>>> freq = gmu->gpu_freqs[i];
>>> + /* This is unlikely to fail because we are passing back a known freq */
>>
>> This could probably mention that known == we just retrieved it a couple
>> function calls above, but I suppose the reader can come up with such
>> conclusions
>
> Also, I think s/unlikely/not expected/ ? "Unlikely" implies that it
> could still happen..
Yeah, "unlikely" as in "cosmic rays" or other kinds of mem corruption
Konrad
^ permalink raw reply [flat|nested] 19+ messages in thread