[PATCH 0/2] support for RTL9607C GPIO Controller

[PATCH 0/2] support for RTL9607C GPIO Controller

[Rustam Adilov]

This patch series adds support for the GPIO controller found in
RTL9607C SoC family of MIPS CPUs.

The GPIO controller on this SoC has a reversed port order, the same as in
RTL930x but without CPU affinity settings.

Rustam Adilov (2):
  dt-bindings: gpio: realtek-otto: add rtl9607 compatible
  gpio: realtek-otto: add rtl9607 support

 Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml | 1 +
 drivers/gpio/gpio-realtek-otto.c                              | 4 ++++
 2 files changed, 5 insertions(+)

-- 
2.53.0

[PATCH 1/2] dt-bindings: gpio: realtek-otto: add rtl9607 compatible

[Rustam Adilov]

Add the "realtek,rtl9607-gpio" compatible for GPIO nodes
on the RTL9607C SoC series.

Signed-off-by: Rustam Adilov <adilov@disroot.org>
---
 Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
index 728099c65824..b18f8f0ca0ae 100644
--- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
@@ -30,6 +30,7 @@ properties:
           - realtek,rtl8390-gpio
           - realtek,rtl9300-gpio
           - realtek,rtl9310-gpio
+          - realtek,rtl9607-gpio
       - const: realtek,otto-gpio
 
   reg: true
-- 
2.53.0

[PATCH 2/2] gpio: realtek-otto: add rtl9607 support

[Rustam Adilov]

The RTL9607C SoC has support for 3 GPIO banks with 32 GPIOs each and
the port order is reversed just like in RTL930x.

Signed-off-by: Rustam Adilov <adilov@disroot.org>
---
 drivers/gpio/gpio-realtek-otto.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
index 4cf91528f547..5e3152c2e51a 100644
--- a/drivers/gpio/gpio-realtek-otto.c
+++ b/drivers/gpio/gpio-realtek-otto.c
@@ -351,6 +351,10 @@ static const struct of_device_id realtek_gpio_of_match[] = {
 	{
 		.compatible = "realtek,rtl9310-gpio",
 	},
+	{
+		.compatible = "realtek,rtl9607-gpio",
+		.data = (void *)GPIO_PORTS_REVERSED,
+	},
 	{}
 };
 MODULE_DEVICE_TABLE(of, realtek_gpio_of_match);
-- 
2.53.0

Re: [PATCH 1/2] dt-bindings: gpio: realtek-otto: add rtl9607 compatible

[Sander Vanheule]

On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:
> Add the "realtek,rtl9607-gpio" compatible for GPIO nodes
> on the RTL9607C SoC series.
> 
> Signed-off-by: Rustam Adilov <adilov@disroot.org>
> ---
>  Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> index 728099c65824..b18f8f0ca0ae 100644
> --- a/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/realtek,otto-gpio.yaml
> @@ -30,6 +30,7 @@ properties:
>            - realtek,rtl8390-gpio
>            - realtek,rtl9300-gpio
>            - realtek,rtl9310-gpio
> +          - realtek,rtl9607-gpio
>        - const: realtek,otto-gpio
>  
>    reg: true

Reviewed-by: Sander Vanheule <sander@svanheule.net>

Best,
Sander

Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support

[Sander Vanheule]

Hi,

On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:
> The RTL9607C SoC has support for 3 GPIO banks with 32 GPIOs each and
> the port order is reversed just like in RTL930x.
> 
> Signed-off-by: Rustam Adilov <adilov@disroot.org>
> ---
>  drivers/gpio/gpio-realtek-otto.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-
> otto.c
> index 4cf91528f547..5e3152c2e51a 100644
> --- a/drivers/gpio/gpio-realtek-otto.c
> +++ b/drivers/gpio/gpio-realtek-otto.c
> @@ -351,6 +351,10 @@ static const struct of_device_id realtek_gpio_of_match[]
> = {
>  	{
>  		.compatible = "realtek,rtl9310-gpio",
>  	},
> +	{
> +		.compatible = "realtek,rtl9607-gpio",
> +		.data = (void *)GPIO_PORTS_REVERSED,
> +	},
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, realtek_gpio_of_match);

If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the RTL931x SoC
series. Were you able to validate that the interrupts are functioning as
expected?

Best,
Sander

Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support

[adilov]

On 2026-03-05 19:04, Sander Vanheule wrote:
> Hi,
> 
> On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:
>> The RTL9607C SoC has support for 3 GPIO banks with 32 GPIOs each and
>> the port order is reversed just like in RTL930x.
>> 
>> Signed-off-by: Rustam Adilov <adilov@disroot.org>
>> ---
>>  drivers/gpio/gpio-realtek-otto.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>> 
>> diff --git a/drivers/gpio/gpio-realtek-otto.c 
>> b/drivers/gpio/gpio-realtek-
>> otto.c
>> index 4cf91528f547..5e3152c2e51a 100644
>> --- a/drivers/gpio/gpio-realtek-otto.c
>> +++ b/drivers/gpio/gpio-realtek-otto.c
>> @@ -351,6 +351,10 @@ static const struct of_device_id 
>> realtek_gpio_of_match[]
>> = {
>>  	{
>>  		.compatible = "realtek,rtl9310-gpio",
>>  	},
>> +	{
>> +		.compatible = "realtek,rtl9607-gpio",
>> +		.data = (void *)GPIO_PORTS_REVERSED,
>> +	},
>>  	{}
>>  };
>>  MODULE_DEVICE_TABLE(of, realtek_gpio_of_match);
> 
> If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the 
> RTL931x SoC
> series. Were you able to validate that the interrupts are functioning 
> as
> expected?
> 
> Best,
> Sander

Hi Sander,

Yes, this is correct. I played around with gpio-keys in OpenWrt (though 
it
has its own gpio-button-hotplug but it should not change things) and can
verify that button presses and releases are working. I think this should
confirm that interrupts are functional.

Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support

[Sander Vanheule]

Hi,

On Thu, 2026-03-05 at 19:54 +0000, adilov wrote:
> On 2026-03-05 19:04, Sander Vanheule wrote:
> > On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:,
> > > +	{
> > > +		.compatible = "realtek,rtl9607-gpio",
> > > +		.data = (void *)GPIO_PORTS_REVERSED,
> > > +	},
> > If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the 
> > RTL931x SoC
> > series. Were you able to validate that the interrupts are functioning 
> > as
> > expected?
> > 
> > Best,
> > Sander
> 
> Hi Sander,
> 
> Yes, this is correct. I played around with gpio-keys in OpenWrt (though 
> it
> has its own gpio-button-hotplug but it should not change things) and can
> verify that button presses and releases are working. I think this should
> confirm that interrupts are functional.

Thanks for the info. I was mainly wondering because there seemed to be some
initial confusion [1] about the port order. If you get the order wrong, you
would be getting spurious interrupts.

[1] https://forum.openwrt.org/t/240741/25

If the order is correct, you should see the key GPIO interrupt increase in
/proc/interrupts. So, assuming that's the case:

Reviewed-by: Sander Vanheule <sander@svanheule.net>

Best,
Sander

Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support

[Rustam Adilov]

On 2026-03-05 21:49, Sander Vanheule wrote:
> Hi,
> 
> On Thu, 2026-03-05 at 19:54 +0000, adilov wrote:
>> On 2026-03-05 19:04, Sander Vanheule wrote:
>> > On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:,
>> > > +	{
>> > > +		.compatible = "realtek,rtl9607-gpio",
>> > > +		.data = (void *)GPIO_PORTS_REVERSED,
>> > > +	},
>> > If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the 
>> > RTL931x SoC
>> > series. Were you able to validate that the interrupts are functioning 
>> > as
>> > expected?
>> > 
>> > Best,
>> > Sander
>> 
>> Hi Sander,
>> 
>> Yes, this is correct. I played around with gpio-keys in OpenWrt (though 
>> it
>> has its own gpio-button-hotplug but it should not change things) and can
>> verify that button presses and releases are working. I think this should
>> confirm that interrupts are functional.
> 
> Thanks for the info. I was mainly wondering because there seemed to be some
> initial confusion [1] about the port order. If you get the order wrong, you
> would be getting spurious interrupts.
> 
> [1] https://forum.openwrt.org/t/240741/25
> 
> If the order is correct, you should see the key GPIO interrupt increase in
> /proc/interrupts. So, assuming that's the case:
> 
> Reviewed-by: Sander Vanheule <sander@svanheule.net>
> 
> Best,
> Sander

Thankfully i had saved the testing image so i quickly booted up my board and
yes, i can see that interrupts increase in /proc/interrupts.

Before button press:
           CPU0       CPU1       CPU2       CPU3
....
 27:          0          0          0          0  realtek-otto-gpio   5  keys
 28:          0          0          0          0  realtek-otto-gpio   2  keys
 29:          0          0          0          0  realtek-otto-gpio   4  keys

After the button press:

 27:          0          0          0          0  realtek-otto-gpio   5  keys
 28:          2          0          0          0  realtek-otto-gpio   2  keys
 29:          0          0          0          0  realtek-otto-gpio   4  keys

It did increase by 2 which i pressume is from press and release actions.

Thank you for the review.

Best,
Rustam

Re: [PATCH 1/2] dt-bindings: gpio: realtek-otto: add rtl9607 compatible

[Linus Walleij]

On Thu, Mar 5, 2026 at 5:11 PM Rustam Adilov <adilov@disroot.org> wrote:

> Add the "realtek,rtl9607-gpio" compatible for GPIO nodes
> on the RTL9607C SoC series.
>
> Signed-off-by: Rustam Adilov <adilov@disroot.org>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH 0/2] support for RTL9607C GPIO Controller

[Bartosz Golaszewski]

On Thu, 05 Mar 2026 21:11:04 +0500, Rustam Adilov wrote:
> This patch series adds support for the GPIO controller found in
> RTL9607C SoC family of MIPS CPUs.
> 
> The GPIO controller on this SoC has a reversed port order, the same as in
> RTL930x but without CPU affinity settings.
> 
> Rustam Adilov (2):
>   dt-bindings: gpio: realtek-otto: add rtl9607 compatible
>   gpio: realtek-otto: add rtl9607 support
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: gpio: realtek-otto: add rtl9607 compatible
      https://git.kernel.org/brgl/c/49944d6ab7eb951f2aefee69341c623e13434863
[2/2] gpio: realtek-otto: add rtl9607 support
      https://git.kernel.org/brgl/c/8f0aecf2957e7dba78603544368846133bf6d22e

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>