Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18

[Aubrey <aubreylee@gmail.com>]

On 9/24/06, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Sun, 24 Sep 2006 11:35:31 +0800 Aubrey wrote:
>
> > On 9/23/06, Arnd Bergmann <arnd@arndb.de> wrote:
> > > > +static uint32_t reloc_stack_operate(unsigned int oper, struct module *mod)
> > > > +{
> > > > +     uint32_t value;
> > > > +     switch (oper) {
> > > > +     case R_add:
> > > > +             {
> > > > +                     value =
> > > > +                         reloc_stack[reloc_stack_tos - 2] +
> > > > +                         reloc_stack[reloc_stack_tos - 1];
> > > > +                     reloc_stack_tos -= 2;
> > > > +                     break;
> > > > +             }
> > >
> > > no need for the curly braces here and below
> >
> > Hmm, but we need one line < 80 columns, don't we?
>
> Yes (preferably), but:
> The braces for case R_add above simply aren't needed at all.
> And after they are removed, you can indent the remaining code
> one less tab stop.
>
Yeah, the braces for case should be removed. Done.