mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Luke Yang" <luke.adi@gmail.com>,
	linux-kernel@vger.kernel.org, "Andrew Morton" <akpm@osdl.org>
Subject: Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18
Date: Sat, 23 Sep 2006 02:50:02 -0400	[thread overview]
Message-ID: <8bd0f97a0609222350o3a9c8c36g468a6177ae7b1ea7@mail.gmail.com> (raw)
In-Reply-To: <200609230218.36894.arnd@arndb.de>

On 9/22/06, Arnd Bergmann <arnd@arndb.de> wrote:
> Use pr_debug here instead of making up your own macros

done

> static inline void

done

> It would be nice if you could use a generic way to pass this partition data
> to the kernel from the mtd medium, instead of hardcoding it here.

i often wish for such things myself :)

unfortunately, the boot loader we utilize (u-boot) isnt exactly
friendly to the idea of managing flash partitions like redboot, and
what we have here is the current standard method for defining flash
partitions with mtd

> Use C99 initializers here, like

done

> There is not much point in trying to use the same numbers as an existing
> architecture if that means that you have to leave holes like setup().
> I don't know if you still have the choice of completely changing the
> syscall numbers, but it would make it nicer in the future.

we do, fortunately, have this luxury ... so we can look forward to a
nice cleaning of our syscall interface

> What's th point of these files, can't you just remove them all?

punted

> > +#define BUG() do { \
> > +     dump_stack(); \
> > +     printk("\nkernel BUG at %s:%d!\n", __FILE__, __LINE__); \
> > +     panic("BUG!"); \
> > +} while (0)
>
> This is probably better done as an external function:

*shrug* i just did it the same way everyone else does ... i'm a sheep like that

> > diff -urN linux-2.6.18/include/asm-blackfin/mach-bf533/anomaly.h
> linux-2.6.18.patch1/include/asm-blackfin/mach-bf533/anomaly.h
> > --- linux-2.6.18/include/asm-blackfin/mach-bf533/anomaly.h    1970-01-01
> 08:00:00.000000000 +0800
> > +++ linux-2.6.18.patch1/include/asm-blackfin/mach-bf533/anomaly.h     2006-09-21
> 09:29:49.000000000 +0800
> > @@ -0,0 +1,172 @@
> > +/*
> > + * File:         include/asm-blackfin/mach-bf533/anomaly.h
>
> You seem to have lots of these machine specfic header files in include/asm.
> Please move them to the respective machine implementation directory
> if they are only used from there

these are arch specific, not machine (aka board)

this is what the blackfin family looks like (first entry is the architecture):
 - BF535
 - BF533 / BF532 / BF531
 - BF537 / BF536 / BF534
 - BF561

which is why you find the anomaly definitions in the architecture
specific header dir

> > +/* Clock and System Control (0xFFC0 0400-0xFFC0 07FF) */
> > +#define bfin_read_PLL_CTL()                  bfin_read16(PLL_CTL)
> > +#define bfin_write_PLL_CTL(val)              bfin_write16(PLL_CTL,val)
> > +#define bfin_read_PLL_STAT()                 bfin_read16(PLL_STAT)
> (and 700 more of these)
>
> What's the point, are you getting paid by lines of code? Just use
> the registers directly!

in our last submission we were doing exactly that ... and we were told
to switch to a function style method of reading/writing memory mapped
registers

> One more thing about the headers: please add a Kbuild file in there so
> 'make headers_install' works

will do

thanks for reading through that monster :)
-mike

  parent reply	other threads:[~2006-09-23  6:50 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21  3:32 Luke Yang
2006-09-21  9:59 ` Luke Yang
2006-09-23  0:18 ` Arnd Bergmann
2006-09-23  1:18   ` Randy.Dunlap
2006-09-23  1:24     ` Roland Dreier
2006-09-23  1:58       ` Mike Frysinger
2006-09-23  6:50   ` Mike Frysinger [this message]
2006-09-23 11:03     ` Arnd Bergmann
2006-09-23 11:15       ` Mike Frysinger
2006-09-23 11:29         ` Arnd Bergmann
2006-09-23 13:07         ` Arnd Bergmann
2006-09-23 11:28     ` Matthieu CASTET
2006-09-23 11:35       ` Mike Frysinger
2006-09-23 19:43     ` Arnd Bergmann
2006-09-24  3:49       ` Luke Yang
2006-09-24  3:35   ` Aubrey
2006-09-24  3:50     ` Randy Dunlap
2006-09-24  4:28       ` Aubrey
2006-09-25  6:54     ` Arnd Bergmann
2006-09-25  7:49       ` Aubrey
2006-09-25  9:26         ` Arnd Bergmann
2006-09-25  9:39           ` Luke Yang
2006-09-25  9:45           ` Aubrey
2006-09-25 15:39           ` Aubrey
2006-09-25 17:05             ` Arnd Bergmann
2006-09-26  3:42               ` Aubrey
2006-09-26  9:43                 ` Arnd Bergmann
2006-09-27 10:04               ` Aubrey
2006-09-27 11:37                 ` Arnd Bergmann
2006-09-23 21:27 ` David Woodhouse
2006-09-25 16:52 ` Randy Dunlap
2006-09-25 18:05   ` Mike Frysinger
2006-09-23 16:29 Robin Getz
2006-09-23 18:10 ` Arnd Bergmann
2006-09-23 17:57 Robin Getz
2006-09-23 23:25 Robin Getz
2006-09-24  7:29 ` David Woodhouse
2006-09-25 23:21 Robin Getz
2006-09-27 16:25 Robin Getz
2006-09-27 16:36 ` Randy Dunlap
2006-09-27 16:41 ` Arnd Bergmann
2006-09-27 17:19 ` Robin Getz
2006-09-27 20:57   ` Arnd Bergmann
2006-09-28  9:31     ` Bernd Schmidt
2006-09-28 11:04       ` Arnd Bergmann
2006-09-28 11:39         ` Bernd Schmidt
2006-09-28 12:35           ` Arnd Bergmann
2006-09-27 17:47 Robin Getz
2006-09-27 19:19 ` Jörn Engel
2006-09-27 21:22 Robin Getz
2006-09-27 21:36 ` Arnd Bergmann
2006-09-27 22:56 Robin Getz
2006-09-27 23:01 Robin Getz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bd0f97a0609222350o3a9c8c36g468a6177ae7b1ea7@mail.gmail.com \
    --to=vapier.adi@gmail.com \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®