* [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-04 13:11 ` Krzysztof Kozlowski
2025-12-06 21:40 ` David Heidelberg
2025-12-03 9:40 ` [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
` (10 subsequent siblings)
11 siblings, 2 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio, Dmitry Baryshkov
Improve adherance to style guidelines below:
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++-----------
1 file changed, 82 insertions(+), 62 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 0ee2f4b99fbd..b8ab64a8de1c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -38,11 +38,6 @@ reserved-memory {
#size-cells = <2>;
ranges;
- qseecom_mem: memory@b2000000 {
- reg = <0 0xb2000000 0 0x1800000>;
- no-map;
- };
-
gpu_mem: memory@8c415000 {
reg = <0 0x8c415000 0 0x2000>;
no-map;
@@ -99,7 +94,12 @@ memory@9d400000 {
no-map;
};
- rmtfs_mem: rmtfs-region@f0800000 {
+ qseecom_mem: memory@b2000000 {
+ reg = <0 0xb2000000 0 0x1800000>;
+ no-map;
+ };
+
+ rmtfs_mem: memory@f0801000 {
compatible = "qcom,rmtfs-mem";
reg = <0 0xf0800000 0 0x202000>;
qcom,use-guard-pages;
@@ -467,14 +467,22 @@ &mss_pil {
status = "okay";
};
+&pm8998_gpios {
+ vol_up_pin_a: vol-up-active-state {
+ pins = "gpio6";
+ function = "normal";
+ input-enable;
+ bias-pull-up;
+ qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
+ };
+};
+
&pm8998_resin {
linux,code = <KEY_VOLUMEDOWN>;
status = "okay";
};
&sdhc_2 {
- status = "okay";
-
cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
pinctrl-names = "default";
@@ -482,26 +490,70 @@ &sdhc_2 {
vmmc-supply = <&vreg_l21a_2p95>;
vqmmc-supply = <&vddpx_2>;
+
+ status = "okay";
};
-/*
- * UFS works partially and only with clk_ignore_unused.
- * Sometimes it crashes with I/O errors.
- */
-&ufs_mem_hc {
+/* PINCTRL - additions to nodes defined in sdm845.dtsi */
+
+&tlmm {
+ gpio-reserved-ranges = <28 4>, <81 4>;
+
+ sdc2_clk: sdc2-clk-state {
+ pins = "sdc2_clk";
+ bias-disable;
+
+ /*
+ * It seems that mmc_test reports errors if drive
+ * strength is not 16 on clk, cmd, and data pins.
+ *
+ * TODO: copy-pasted from mtp, try other values
+ * on these devices.
+ */
+ drive-strength = <16>;
+ };
+
+ sdc2_cmd: sdc2-cmd-state {
+ pins = "sdc2_cmd";
+ bias-pull-up;
+ drive-strength = <16>;
+ };
+
+ sdc2_data: sdc2-data-state {
+ pins = "sdc2_data";
+ bias-pull-up;
+ drive-strength = <16>;
+ };
+
+ sd_card_det_n: sd-card-det-n-state {
+ pins = "gpio126";
+ function = "gpio";
+ bias-pull-up;
+ };
+};
+
+&qupv3_id_0 {
status = "okay";
+};
+&qupv3_id_1 {
+ status = "okay";
+};
+
+&ufs_mem_hc {
reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
vcc-supply = <&vreg_l20a_2p95>;
vcc-max-microamp = <600000>;
-};
-&ufs_mem_phy {
status = "okay";
+};
+&ufs_mem_phy {
vdda-phy-supply = <&vdda_ufs1_core>;
vdda-pll-supply = <&vdda_ufs1_1p2>;
+
+ status = "okay";
};
&usb_1 {
@@ -514,8 +566,6 @@ &usb_1_dwc3 {
};
&usb_1_hsphy {
- status = "okay";
-
vdd-supply = <&vdda_usb1_ss_core>;
vdda-pll-supply = <&vdda_qusb_hs0_1p8>;
vdda-phy-dpdm-supply = <&vdda_qusb_hs0_3p1>;
@@ -524,59 +574,29 @@ &usb_1_hsphy {
qcom,hstx-trim-value = <QUSB2_V2_HSTX_TRIM_21_6_MA>;
qcom,preemphasis-level = <QUSB2_V2_PREEMPHASIS_5_PERCENT>;
qcom,preemphasis-width = <QUSB2_V2_PREEMPHASIS_WIDTH_HALF_BIT>;
-};
-&usb_1_qmpphy {
status = "okay";
+};
+&usb_1_qmpphy {
vdda-phy-supply = <&vdda_usb1_ss_1p2>;
vdda-pll-supply = <&vdda_usb1_ss_core>;
-};
-
-/* PINCTRL - additions to nodes defined in sdm845.dtsi */
-
-&tlmm {
- gpio-reserved-ranges = <28 4>, <81 4>;
-
- sdc2_clk: sdc2-clk-state {
- pins = "sdc2_clk";
- bias-disable;
- /*
- * It seems that mmc_test reports errors if drive
- * strength is not 16 on clk, cmd, and data pins.
- *
- * TODO: copy-pasted from mtp, try other values
- * on these devices.
- */
- drive-strength = <16>;
- };
+ status = "okay";
+};
- sdc2_cmd: sdc2-cmd-state {
- pins = "sdc2_cmd";
- bias-pull-up;
- drive-strength = <16>;
- };
+&venus {
+ status = "okay";
+};
- sdc2_data: sdc2-data-state {
- pins = "sdc2_data";
- bias-pull-up;
- drive-strength = <16>;
- };
+&wifi {
+ vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+ vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+ vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+ vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
- sd_card_det_n: sd-card-det-n-state {
- pins = "gpio126";
- function = "gpio";
- bias-pull-up;
- };
-};
+ qcom,snoc-host-cap-skip-quirk;
-&pm8998_gpios {
- vol_up_pin_a: vol-up-active-state {
- pins = "gpio6";
- function = "normal";
- input-enable;
- bias-pull-up;
- qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>;
- };
+ status = "okay";
};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
2025-12-03 9:40 ` [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
@ 2025-12-04 13:11 ` Krzysztof Kozlowski
2025-12-04 13:27 ` Konrad Dybcio
2025-12-06 21:40 ` David Heidelberg
1 sibling, 1 reply; 29+ messages in thread
From: Krzysztof Kozlowski @ 2025-12-04 13:11 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Konrad Dybcio, Dmitry Baryshkov
On 03/12/2025 10:40, Paul Sajna wrote:
> Improve adherance to style guidelines below:
> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++-----------
> 1 file changed, 82 insertions(+), 62 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 0ee2f4b99fbd..b8ab64a8de1c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -38,11 +38,6 @@ reserved-memory {
> #size-cells = <2>;
> ranges;
>
> - qseecom_mem: memory@b2000000 {
> - reg = <0 0xb2000000 0 0x1800000>;
> - no-map;
> - };
> -
> gpu_mem: memory@8c415000 {
> reg = <0 0x8c415000 0 0x2000>;
> no-map;
> @@ -99,7 +94,12 @@ memory@9d400000 {
> no-map;
> };
>
> - rmtfs_mem: rmtfs-region@f0800000 {
Why?
> + qseecom_mem: memory@b2000000 {
> + reg = <0 0xb2000000 0 0x1800000>;
> + no-map;
> + };
> +
> + rmtfs_mem: memory@f0801000 {
No, you are doing much more then sorting. You are changing names to
incorrect ones and maybe (tricky to say) change also unit address to
buggy one.
@Konrad,
Why are we started resorting the addresses BEFORE we came up with proper
linter? Why the rule suddenly changed?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
2025-12-04 13:11 ` Krzysztof Kozlowski
@ 2025-12-04 13:27 ` Konrad Dybcio
0 siblings, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-12-04 13:27 UTC (permalink / raw)
To: Krzysztof Kozlowski, Paul Sajna, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Dmitry Baryshkov
On 12/4/25 2:11 PM, Krzysztof Kozlowski wrote:
> On 03/12/2025 10:40, Paul Sajna wrote:
>> Improve adherance to style guidelines below:
>> https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 144 ++++++++++++++-----------
>> 1 file changed, 82 insertions(+), 62 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> index 0ee2f4b99fbd..b8ab64a8de1c 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> @@ -38,11 +38,6 @@ reserved-memory {
>> #size-cells = <2>;
>> ranges;
>>
>> - qseecom_mem: memory@b2000000 {
>> - reg = <0 0xb2000000 0 0x1800000>;
>> - no-map;
>> - };
>> -
>> gpu_mem: memory@8c415000 {
>> reg = <0 0x8c415000 0 0x2000>;
>> no-map;
>> @@ -99,7 +94,12 @@ memory@9d400000 {
>> no-map;
>> };
>>
>> - rmtfs_mem: rmtfs-region@f0800000 {
>
> Why?
>
>> + qseecom_mem: memory@b2000000 {
>> + reg = <0 0xb2000000 0 0x1800000>;
>> + no-map;
>> + };
>> +
>> + rmtfs_mem: memory@f0801000 {
>
> No, you are doing much more then sorting. You are changing names to
> incorrect ones and maybe (tricky to say) change also unit address to
> buggy one.
>
> @Konrad,
> Why are we started resorting the addresses BEFORE we came up with proper
> linter? Why the rule suddenly changed?
I don't really mind small cleanups that are done as part of bigger
feature additions, as opposed to fixing a single file for the sake
of it
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread
* Re: [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties
2025-12-03 9:40 ` [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
2025-12-04 13:11 ` Krzysztof Kozlowski
@ 2025-12-06 21:40 ` David Heidelberg
1 sibling, 0 replies; 29+ messages in thread
From: David Heidelberg @ 2025-12-06 21:40 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Konrad Dybcio, Dmitry Baryshkov
On 03/12/2025 10:40, Paul Sajna wrote:
[...]
> - rmtfs_mem: rmtfs-region@f0800000 {
this is a correct region f0800000
> + qseecom_mem: memory@b2000000 {
> + reg = <0 0xb2000000 0 0x1800000>;
> + no-map;
> + };
> +
> + rmtfs_mem: memory@f0801000 {
this is f0801000 (+1000) offset from old sdm845 downstream with boundaries.
[...]
I noticed this when I tried apply your changes on top of sdm845-next repo.
If you need testing, this repo should help you (as all phone-related
patches should be applied on top of recent -next and work)
David
--
David Heidelberg
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-12-03 9:40 ` [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 13:44 ` David Heidelberg
2025-12-03 9:40 ` [PATCH v5 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger Paul Sajna
` (9 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Dmitry Baryshkov
uart9 is debug serial on USB SBU1/2
UART RX is SBU1 and UART TX is SBU2 of the USB-C port).
1.8V Logic Level
Tested using pololu usb07a https://www.pololu.com/product/2585
and CH340 USB-UART
uart6 is bluetooth
Bluetooth: hci0: setting up wcn399x
Bluetooth: hci0: QCA Product ID :0x0000000a
Bluetooth: hci0: QCA SOC Version :0x40010214
Bluetooth: hci0: QCA ROM Version :0x00000201
Bluetooth: hci0: QCA Patch Version:0x00000001
Bluetooth: hci0: QCA controller version 0x02140201
Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv
Bluetooth: hci0: QCA Downloading qca/judyln/crnv21.bin
Bluetooth: hci0: QCA setup on UART is completed
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 39 ++++++++++++++++++++++++--
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 8 ++++++
2 files changed, 45 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index b8ab64a8de1c..cbd57eee6ffc 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -27,10 +27,17 @@
/delete-node/ &wlan_msa_mem;
/ {
+ aliases {
+ serial0 = &uart9;
+ serial1 = &uart6;
+ };
+
chosen {
#address-cells = <2>;
#size-cells = <2>;
ranges;
+
+ stdout-path = "serial0:115200n8";
};
reserved-memory {
@@ -540,6 +547,36 @@ &qupv3_id_1 {
status = "okay";
};
+&qup_uart9_rx {
+ drive-strength = <2>;
+ bias-pull-up;
+};
+
+&qup_uart9_tx {
+ drive-strength = <2>;
+ bias-disable;
+};
+
+&uart6 {
+ pinctrl-0 = <&qup_uart6_4pin>;
+
+ status = "okay";
+
+ bluetooth: bluetooth {
+ compatible = "qcom,wcn3990-bt";
+
+ vddio-supply = <&vreg_s4a_1p8>;
+ vddxo-supply = <&vreg_l7a_1p8>;
+ vddrf-supply = <&vreg_l17a_1p3>;
+ vddch0-supply = <&vreg_l25a_3p3>;
+ max-speed = <3200000>;
+ };
+};
+
+&uart9 {
+ status = "okay";
+};
+
&ufs_mem_hc {
reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
@@ -597,6 +634,4 @@ &wifi {
vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
qcom,snoc-host-cap-skip-quirk;
-
- status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 09bfcef42402..e530a08f5e27 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -43,6 +43,14 @@ &adsp_pas {
firmware-name = "qcom/sdm845/judyln/adsp.mbn";
};
+&bluetooth {
+ /*
+ * This path is relative to the qca/
+ * subdir under lib/firmware.
+ */
+ firmware-name = "judyln/crnv21.bin";
+};
+
&cdsp_pas {
firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth
2025-12-03 9:40 ` [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
@ 2025-12-03 13:44 ` David Heidelberg
0 siblings, 0 replies; 29+ messages in thread
From: David Heidelberg @ 2025-12-03 13:44 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Dmitry Baryshkov
On 03/12/2025 10:40, Paul Sajna wrote:
> uart9 is debug serial on USB SBU1/2
>
> UART RX is SBU1 and UART TX is SBU2 of the USB-C port).
> 1.8V Logic Level
> Tested using pololu usb07a https://www.pololu.com/product/2585
> and CH340 USB-UART
>
> uart6 is bluetooth
>
> Bluetooth: hci0: setting up wcn399x
> Bluetooth: hci0: QCA Product ID :0x0000000a
> Bluetooth: hci0: QCA SOC Version :0x40010214
> Bluetooth: hci0: QCA ROM Version :0x00000201
> Bluetooth: hci0: QCA Patch Version:0x00000001
> Bluetooth: hci0: QCA controller version 0x02140201
> Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv
> Bluetooth: hci0: QCA Downloading qca/judyln/crnv21.bin
> Bluetooth: hci0: QCA setup on UART is completed
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 39 ++++++++++++++++++++++++--
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 8 ++++++
> 2 files changed, 45 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index b8ab64a8de1c..cbd57eee6ffc 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -27,10 +27,17 @@
> /delete-node/ &wlan_msa_mem;
>
> / {
> + aliases {
> + serial0 = &uart9;
> + serial1 = &uart6;
> + };
> +
> chosen {
> #address-cells = <2>;
> #size-cells = <2>;
> ranges;
> +
> + stdout-path = "serial0:115200n8";
> };
>
> reserved-memory {
> @@ -540,6 +547,36 @@ &qupv3_id_1 {
> status = "okay";
> };
>
> +&qup_uart9_rx {
> + drive-strength = <2>;
> + bias-pull-up;
> +};
> +
> +&qup_uart9_tx {
> + drive-strength = <2>;
> + bias-disable;
> +};
> +
> +&uart6 {
> + pinctrl-0 = <&qup_uart6_4pin>;
> +
> + status = "okay";
> +
> + bluetooth: bluetooth {
> + compatible = "qcom,wcn3990-bt";
> +
> + vddio-supply = <&vreg_s4a_1p8>;
> + vddxo-supply = <&vreg_l7a_1p8>;
> + vddrf-supply = <&vreg_l17a_1p3>;
> + vddch0-supply = <&vreg_l25a_3p3>;
> + max-speed = <3200000>;
> + };
> +};
> +
> +&uart9 {
> + status = "okay";
> +};
> +
> &ufs_mem_hc {
> reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;
>
> @@ -597,6 +634,4 @@ &wifi {
> vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>
> qcom,snoc-host-cap-skip-quirk;
> -
> - status = "okay";
> };
I'll not make you happy, but in the first patch [v5 01/12], you
accidentally introducing the wifi node, and here you removing part of it..
You need to rebase again :(
I recommend doing `git rebase -i next-202512XX` and go patch by patch
and check it really do what it's meant to be..
rebasing is sometimes pain when larger changes are done.
David
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 09bfcef42402..e530a08f5e27 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -43,6 +43,14 @@ &adsp_pas {
> firmware-name = "qcom/sdm845/judyln/adsp.mbn";
> };
>
> +&bluetooth {
> + /*
> + * This path is relative to the qca/
> + * subdir under lib/firmware.
> + */
> + firmware-name = "judyln/crnv21.bin";
> +};
> +
> &cdsp_pas {
> firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
> };
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
2025-12-03 9:40 ` [PATCH v5 01/12] arm64: dts: qcom: sdm845-lg-common: Sort nodes and properties Paul Sajna
2025-12-03 9:40 ` [PATCH v5 02/12] arm64: dts: qcom: sdm845-lg-common: Add uarts and Bluetooth Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 9:40 ` [PATCH v5 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs Paul Sajna
` (8 subsequent siblings)
11 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio
From: Christopher Brown <crispybrown@gmail.com>
Values based on lineageos kernel
https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-battery/LGE_BLT39_LGC_3000mAh.dtsi
Signed-off-by: Christopher Brown <crispybrown@gmail.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index e530a08f5e27..55bfddab3afd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -37,6 +37,14 @@ key-thinq {
interrupts = <89 IRQ_TYPE_LEVEL_LOW>;
};
};
+
+ battery: battery {
+ compatible = "simple-battery";
+
+ charge-full-design-microamp-hours = <3000000>;
+ voltage-min-design-microvolt = <3200000>;
+ voltage-max-design-microvolt = <4400000>;
+ };
};
&adsp_pas {
@@ -63,6 +71,12 @@ &mss_pil {
firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
};
+&pmi8998_charger {
+ monitored-battery = <&battery>;
+
+ status = "okay";
+};
+
&tlmm {
thinq_key_default: thinq-key-default-state {
pins = "gpio89";
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* [PATCH v5 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (2 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 03/12] arm64: dts: qcom: sdm845-lg-judyln: Add battery and charger Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 9:40 ` [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
` (7 subsequent siblings)
11 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Amir Dahan, Pavel Machek, Konrad Dybcio
From: Amir Dahan <system64fumo@protonmail.com>
Add the multicolor status LED in the phone's notch.
Signed-off-by: Amir Dahan <system64fumo@tuta.io>
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 28 ++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index cbd57eee6ffc..165523db4d49 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -6,6 +6,7 @@
*/
#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
@@ -489,6 +490,33 @@ &pm8998_resin {
status = "okay";
};
+&pmi8998_lpg {
+ status = "okay";
+
+ multi-led {
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_STATUS;
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@3 {
+ reg = <3>;
+ color = <LED_COLOR_ID_BLUE>;
+ };
+
+ led@4 {
+ reg = <4>;
+ color = <LED_COLOR_ID_GREEN>;
+ };
+
+ led@5 {
+ reg = <5>;
+ color = <LED_COLOR_ID_RED>;
+ };
+ };
+};
+
&sdhc_2 {
cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (3 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 04/12] arm64: dts: qcom: sdm845-lg-common: Add LEDs Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-06 2:09 ` Dmitry Baryshkov
2025-12-03 9:40 ` [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
` (6 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio
Also include other supporting msm drm nodes, including backlight
Co-developed-by: Amir Dahan <system64fumo@tuta.io>
Signed-off-by: Amir Dahan <system64fumo@tuta.io>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 8 +--
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 75 +++++++++++++++++++++-----
2 files changed, 66 insertions(+), 17 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 165523db4d49..50921af83a51 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -450,10 +450,6 @@ &cdsp_pas {
status = "okay";
};
-&dispcc {
- status = "disabled";
-};
-
&gcc {
protected-clocks = <GCC_QSPI_CORE_CLK>,
<GCC_QSPI_CORE_CLK_SRC>,
@@ -517,6 +513,10 @@ led@5 {
};
};
+&pmi8998_wled {
+ status = "okay";
+};
+
&sdhc_2 {
cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 55bfddab3afd..506e6fe8e798 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -13,19 +13,6 @@ / {
model = "LG G7 ThinQ";
compatible = "lg,judyln", "qcom,sdm845";
- chosen {
- framebuffer@9d400000 {
- compatible = "simple-framebuffer";
- reg = <0x0 0x9d400000 0x0 (1440 * 3120 * 4)>;
- width = <1440>;
- height = <3120>;
- stride = <(1440 * 4)>;
- format = "a8r8g8b8";
- lab-supply = <&lab>;
- ibb-supply = <&ibb>;
- };
- };
-
/* Additional ThinQ key */
gpio-keys {
pinctrl-0 = <&vol_up_pin_a &thinq_key_default>;
@@ -67,6 +54,47 @@ &gpu_zap_shader {
firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
};
+&mdss {
+ status = "okay";
+};
+
+&mdss_dsi0 {
+ vdda-supply = <&vdda_mipi_dsi0_1p2>;
+
+ status = "okay";
+
+ display_panel: panel@0 {
+ reg = <0>;
+ compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
+
+ backlight = <&pmi8998_wled>;
+ reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+ width-mm = <65>;
+ height-mm = <140>;
+
+ pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>;
+ pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>;
+ pinctrl-names = "default", "sleep";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+};
+
+&mdss_dsi0_phy {
+ vdds-supply = <&vdda_mipi_dsi0_pll>;
+
+ status = "okay";
+};
+
+&mdss_dsi0_out {
+ remote-endpoint = <&panel_in>;
+ data-lanes = <0 1 2 3>;
+};
+
&mss_pil {
firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
};
@@ -85,4 +113,25 @@ thinq_key_default: thinq-key-default-state {
drive-strength = <2>;
bias-pull-up;
};
+
+ sde_dsi_active: sde-dsi-active-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <8>;
+ bias-disable;
+ };
+
+ sde_dsi_sleep: sde-dsi-sleep-state {
+ pins = "gpio6";
+ function = "gpio";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ sde_te_active_sleep: sde-te-active-sleep-state {
+ pins = "gpio10";
+ function = "mdp_vsync";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-12-03 9:40 ` [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
@ 2025-12-06 2:09 ` Dmitry Baryshkov
2025-12-06 12:37 ` David Heidelberg
0 siblings, 1 reply; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-12-06 2:09 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown, Konrad Dybcio
On Wed, Dec 03, 2025 at 01:40:54AM -0800, Paul Sajna wrote:
> Also include other supporting msm drm nodes, including backlight
>
> Co-developed-by: Amir Dahan <system64fumo@tuta.io>
> Signed-off-by: Amir Dahan <system64fumo@tuta.io>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 8 +--
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 75 +++++++++++++++++++++-----
> 2 files changed, 66 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> index 165523db4d49..50921af83a51 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
> @@ -450,10 +450,6 @@ &cdsp_pas {
> status = "okay";
> };
>
> -&dispcc {
> - status = "disabled";
> -};
> -
> &gcc {
> protected-clocks = <GCC_QSPI_CORE_CLK>,
> <GCC_QSPI_CORE_CLK_SRC>,
> @@ -517,6 +513,10 @@ led@5 {
> };
> };
>
> +&pmi8998_wled {
> + status = "okay";
> +};
> +
> &sdhc_2 {
> cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 55bfddab3afd..506e6fe8e798 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -13,19 +13,6 @@ / {
> model = "LG G7 ThinQ";
> compatible = "lg,judyln", "qcom,sdm845";
>
> - chosen {
> - framebuffer@9d400000 {
> - compatible = "simple-framebuffer";
> - reg = <0x0 0x9d400000 0x0 (1440 * 3120 * 4)>;
> - width = <1440>;
> - height = <3120>;
> - stride = <(1440 * 4)>;
> - format = "a8r8g8b8";
> - lab-supply = <&lab>;
> - ibb-supply = <&ibb>;
> - };
> - };
I think, you can leave simple-fb in place. MSM driver should be able to
replace it once it is loaded.
> -
> /* Additional ThinQ key */
> gpio-keys {
> pinctrl-0 = <&vol_up_pin_a &thinq_key_default>;
> @@ -67,6 +54,47 @@ &gpu_zap_shader {
> firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
> };
>
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_dsi0 {
> + vdda-supply = <&vdda_mipi_dsi0_1p2>;
> +
> + status = "okay";
> +
> + display_panel: panel@0 {
> + reg = <0>;
> + compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
> +
> + backlight = <&pmi8998_wled>;
> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
> + width-mm = <65>;
> + height-mm = <140>;
> +
> + pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>;
> + pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>;
> + pinctrl-names = "default", "sleep";
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&mdss_dsi0_out>;
> + };
> + };
> + };
> +};
> +
> +&mdss_dsi0_phy {
> + vdds-supply = <&vdda_mipi_dsi0_pll>;
> +
> + status = "okay";
> +};
> +
> +&mdss_dsi0_out {
> + remote-endpoint = <&panel_in>;
> + data-lanes = <0 1 2 3>;
> +};
> +
> &mss_pil {
> firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
> };
> @@ -85,4 +113,25 @@ thinq_key_default: thinq-key-default-state {
> drive-strength = <2>;
> bias-pull-up;
> };
> +
> + sde_dsi_active: sde-dsi-active-state {
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-disable;
> + };
> +
> + sde_dsi_sleep: sde-dsi-sleep-state {
> + pins = "gpio6";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + sde_te_active_sleep: sde-te-active-sleep-state {
> + pins = "gpio10";
> + function = "mdp_vsync";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> };
>
> --
> 2.52.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-12-06 2:09 ` Dmitry Baryshkov
@ 2025-12-06 12:37 ` David Heidelberg
2025-12-06 17:53 ` David Heidelberg
0 siblings, 1 reply; 29+ messages in thread
From: David Heidelberg @ 2025-12-06 12:37 UTC (permalink / raw)
To: Dmitry Baryshkov, Paul Sajna, Sam Day
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown, Konrad Dybcio
On 06/12/2025 03:09, Dmitry Baryshkov wrote:
> On Wed, Dec 03, 2025 at 01:40:54AM -0800, Paul Sajna wrote:
>> Also include other supporting msm drm nodes, including backlight
>>
>> Co-developed-by: Amir Dahan <system64fumo@tuta.io>
>> Signed-off-by: Amir Dahan <system64fumo@tuta.io>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 8 +--
>> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 75 +++++++++++++++++++++-----
>> 2 files changed, 66 insertions(+), 17 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> index 165523db4d49..50921af83a51 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>> @@ -450,10 +450,6 @@ &cdsp_pas {
>> status = "okay";
>> };
>>
>> -&dispcc {
>> - status = "disabled";
>> -};
>> -
>> &gcc {
>> protected-clocks = <GCC_QSPI_CORE_CLK>,
>> <GCC_QSPI_CORE_CLK_SRC>,
>> @@ -517,6 +513,10 @@ led@5 {
>> };
>> };
>>
>> +&pmi8998_wled {
>> + status = "okay";
>> +};
>> +
>> &sdhc_2 {
>> cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>> index 55bfddab3afd..506e6fe8e798 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>> @@ -13,19 +13,6 @@ / {
>> model = "LG G7 ThinQ";
>> compatible = "lg,judyln", "qcom,sdm845";
>>
>> - chosen {
>> - framebuffer@9d400000 {
>> - compatible = "simple-framebuffer";
>> - reg = <0x0 0x9d400000 0x0 (1440 * 3120 * 4)>;
>> - width = <1440>;
>> - height = <3120>;
>> - stride = <(1440 * 4)>;
>> - format = "a8r8g8b8";
>> - lab-supply = <&lab>;
>> - ibb-supply = <&ibb>;
>> - };
>> - };
>
> I think, you can leave simple-fb in place. MSM driver should be able to
> replace it once it is loaded.
Any chance, do you know if the issue OnePlus had is then resolved?
===
/**
* HACK:
* Fake panel node for simple-framebuffer to calculate DPI from. Only
* needs width & height specified. This allows us to break device link
* from simplefb to mdss (implicitly via panel->mdp->mdss) to fix drm
* device probe ordering. Without this, simpledrm would probe second
* after msm-drm, and confuse userspace with 2 GPUs in /dev/dri.
* Alternative workaround is to boot with kernel parameter
* `fw_devlink=permissive`, which is worse, because it can hide other
* issues with device dependencies.
*/
panel = <&fb_panel>;
fb_panel: fb-panel {
width-mm = <68>;
height-mm = <145>;
};
===
Ref:
https://gitlab.com/sdm845/sdm845-next/-/commit/6a0a09c4dddc1b973209f5ffea086eb7a3fc24b9
Add Sam into CC.
David
>
>> -
>> /* Additional ThinQ key */
>> gpio-keys {
>> pinctrl-0 = <&vol_up_pin_a &thinq_key_default>;
>> @@ -67,6 +54,47 @@ &gpu_zap_shader {
>> firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
>> };
>>
>> +&mdss {
>> + status = "okay";
>> +};
>> +
>> +&mdss_dsi0 {
>> + vdda-supply = <&vdda_mipi_dsi0_1p2>;
>> +
>> + status = "okay";
>> +
>> + display_panel: panel@0 {
>> + reg = <0>;
>> + compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
>> +
>> + backlight = <&pmi8998_wled>;
>> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
>> + width-mm = <65>;
>> + height-mm = <140>;
>> +
>> + pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>;
>> + pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>;
>> + pinctrl-names = "default", "sleep";
>> +
>> + port {
>> + panel_in: endpoint {
>> + remote-endpoint = <&mdss_dsi0_out>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&mdss_dsi0_phy {
>> + vdds-supply = <&vdda_mipi_dsi0_pll>;
>> +
>> + status = "okay";
>> +};
>> +
>> +&mdss_dsi0_out {
>> + remote-endpoint = <&panel_in>;
>> + data-lanes = <0 1 2 3>;
>> +};
>> +
>> &mss_pil {
>> firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
>> };
>> @@ -85,4 +113,25 @@ thinq_key_default: thinq-key-default-state {
>> drive-strength = <2>;
>> bias-pull-up;
>> };
>> +
>> + sde_dsi_active: sde-dsi-active-state {
>> + pins = "gpio6";
>> + function = "gpio";
>> + drive-strength = <8>;
>> + bias-disable;
>> + };
>> +
>> + sde_dsi_sleep: sde-dsi-sleep-state {
>> + pins = "gpio6";
>> + function = "gpio";
>> + drive-strength = <2>;
>> + bias-pull-down;
>> + };
>> +
>> + sde_te_active_sleep: sde-te-active-sleep-state {
>> + pins = "gpio10";
>> + function = "mdp_vsync";
>> + drive-strength = <2>;
>> + bias-pull-down;
>> + };
>> };
>>
>> --
>> 2.52.0
>>
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel
2025-12-06 12:37 ` David Heidelberg
@ 2025-12-06 17:53 ` David Heidelberg
0 siblings, 0 replies; 29+ messages in thread
From: David Heidelberg @ 2025-12-06 17:53 UTC (permalink / raw)
To: Dmitry Baryshkov, Paul Sajna, Sam Day, Alexey Minnekhanov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown, Konrad Dybcio
On 06/12/2025 13:37, David Heidelberg wrote:
> On 06/12/2025 03:09, Dmitry Baryshkov wrote:
>> On Wed, Dec 03, 2025 at 01:40:54AM -0800, Paul Sajna wrote:
>>> Also include other supporting msm drm nodes, including backlight
>>>
>>> Co-developed-by: Amir Dahan <system64fumo@tuta.io>
>>> Signed-off-by: Amir Dahan <system64fumo@tuta.io>
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 8 +--
>>> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 75 +++++++++++++++
>>> ++++++-----
>>> 2 files changed, 66 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/
>>> arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>>> index 165523db4d49..50921af83a51 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
>>> @@ -450,10 +450,6 @@ &cdsp_pas {
>>> status = "okay";
>>> };
>>> -&dispcc {
>>> - status = "disabled";
>>> -};
>>> -
>>> &gcc {
>>> protected-clocks = <GCC_QSPI_CORE_CLK>,
>>> <GCC_QSPI_CORE_CLK_SRC>,
>>> @@ -517,6 +513,10 @@ led@5 {
>>> };
>>> };
>>> +&pmi8998_wled {
>>> + status = "okay";
>>> +};
>>> +
>>> &sdhc_2 {
>>> cd-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/
>>> arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> index 55bfddab3afd..506e6fe8e798 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> @@ -13,19 +13,6 @@ / {
>>> model = "LG G7 ThinQ";
>>> compatible = "lg,judyln", "qcom,sdm845";
>>> - chosen {
>>> - framebuffer@9d400000 {
>>> - compatible = "simple-framebuffer";
>>> - reg = <0x0 0x9d400000 0x0 (1440 * 3120 * 4)>;
>>> - width = <1440>;
>>> - height = <3120>;
>>> - stride = <(1440 * 4)>;
>>> - format = "a8r8g8b8";
>>> - lab-supply = <&lab>;
>>> - ibb-supply = <&ibb>;
>>> - };
>>> - };
>>
>> I think, you can leave simple-fb in place. MSM driver should be able to
>> replace it once it is loaded.
>
> Any chance, do you know if the issue OnePlus had is then resolved?
>
> ===
> /**
> * HACK:
> * Fake panel node for simple-framebuffer to calculate DPI from. Only
> * needs width & height specified. This allows us to break device link
> * from simplefb to mdss (implicitly via panel->mdp->mdss) to fix drm
> * device probe ordering. Without this, simpledrm would probe second
> * after msm-drm, and confuse userspace with 2 GPUs in /dev/dri.
> * Alternative workaround is to boot with kernel parameter
> * `fw_devlink=permissive`, which is worse, because it can hide other
> * issues with device dependencies.
> */
> panel = <&fb_panel>;
>
> fb_panel: fb-panel {
> width-mm = <68>;
> height-mm = <145>;
> };
> ===
>
> Ref: https://gitlab.com/sdm845/sdm845-next/-/
> commit/6a0a09c4dddc1b973209f5ffea086eb7a3fc24b9
>
> Add Sam into CC.
Okay, I did some testing without the hack on sdm845 and OnePlus 6.
Ut seems there is no longer regression, wrong sequence or errors in
dmesg nor any problems when using the device, so i assume this hack is
no longer needed.
Sorry about the noise, if it's still relevant, please let me know.
David
>
> David
>
>
>>
>>> -
>>> /* Additional ThinQ key */
>>> gpio-keys {
>>> pinctrl-0 = <&vol_up_pin_a &thinq_key_default>;
>>> @@ -67,6 +54,47 @@ &gpu_zap_shader {
>>> firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
>>> };
>>> +&mdss {
>>> + status = "okay";
>>> +};
>>> +
>>> +&mdss_dsi0 {
>>> + vdda-supply = <&vdda_mipi_dsi0_1p2>;
>>> +
>>> + status = "okay";
>>> +
>>> + display_panel: panel@0 {
>>> + reg = <0>;
>>> + compatible = "lg,sw49410-lh609qh1", "lg,sw49410";
>>> +
>>> + backlight = <&pmi8998_wled>;
>>> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
>>> + width-mm = <65>;
>>> + height-mm = <140>;
>>> +
>>> + pinctrl-0 = <&sde_dsi_active &sde_te_active_sleep>;
>>> + pinctrl-1 = <&sde_dsi_sleep &sde_te_active_sleep>;
>>> + pinctrl-names = "default", "sleep";
>>> +
>>> + port {
>>> + panel_in: endpoint {
>>> + remote-endpoint = <&mdss_dsi0_out>;
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&mdss_dsi0_phy {
>>> + vdds-supply = <&vdda_mipi_dsi0_pll>;
>>> +
>>> + status = "okay";
>>> +};
>>> +
>>> +&mdss_dsi0_out {
>>> + remote-endpoint = <&panel_in>;
>>> + data-lanes = <0 1 2 3>;
>>> +};
>>> +
>>> &mss_pil {
>>> firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/
>>> judyln/modem.mbn";
>>> };
>>> @@ -85,4 +113,25 @@ thinq_key_default: thinq-key-default-state {
>>> drive-strength = <2>;
>>> bias-pull-up;
>>> };
>>> +
>>> + sde_dsi_active: sde-dsi-active-state {
>>> + pins = "gpio6";
>>> + function = "gpio";
>>> + drive-strength = <8>;
>>> + bias-disable;
>>> + };
>>> +
>>> + sde_dsi_sleep: sde-dsi-sleep-state {
>>> + pins = "gpio6";
>>> + function = "gpio";
>>> + drive-strength = <2>;
>>> + bias-pull-down;
>>> + };
>>> +
>>> + sde_te_active_sleep: sde-te-active-sleep-state {
>>> + pins = "gpio10";
>>> + function = "mdp_vsync";
>>> + drive-strength = <2>;
>>> + bias-pull-down;
>>> + };
>>> };
>>>
>>> --
>>> 2.52.0
>>>
>>
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (4 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 05/12] arm64: dts: qcom: sdm845-lg-judyln: Add display panel Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 13:47 ` David Heidelberg
2025-12-06 2:11 ` Dmitry Baryshkov
2025-12-03 9:40 ` [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
` (5 subsequent siblings)
11 siblings, 2 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna
Add paths for Qualcomm firmware, including:
ipa, modem, bluetooth, venus, gpu
Enable adsp and cdsp nodes since their firmware is present
GPU and bluetooth are confirmed working, others may need more
testing/fixes
But regardless they will need the firmware paths specified here
and firmware added upstream before they will work, so might as well
get started on it now.
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 20 +++++++++++++++-----
2 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 50921af83a51..315fdc5dc392 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -162,6 +162,10 @@ &adsp_pas {
status = "okay";
};
+&cdsp_pas {
+ status = "okay";
+};
+
&apps_rsc {
regulators-0 {
compatible = "qcom,pm8998-rpmh-regulators";
@@ -464,6 +468,8 @@ &gpu {
&ipa {
qcom,gsi-loader = "modem";
+ memory-region = <&ipa_fw_mem>;
+
status = "okay";
};
@@ -663,3 +669,7 @@ &wifi {
qcom,snoc-host-cap-skip-quirk;
};
+
+&venus {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 506e6fe8e798..49d285c3e6b2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -35,7 +35,7 @@ battery: battery {
};
&adsp_pas {
- firmware-name = "qcom/sdm845/judyln/adsp.mbn";
+ firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
};
&bluetooth {
@@ -47,11 +47,17 @@ &bluetooth {
};
&cdsp_pas {
- firmware-name = "qcom/sdm845/judyln/cdsp.mbn";
+ firmware-name = "qcom/sdm845/lg/judyln/cdsp.mbn";
};
-&gpu_zap_shader {
- firmware-name = "qcom/sdm845/judyln/a630_zap.mbn";
+&gpu {
+ zap-shader {
+ firmware-name = "qcom/sdm845/lg/judyln/a630_zap.mbn";
+ };
+};
+
+&ipa {
+ firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
};
&mdss {
@@ -96,7 +102,7 @@ &mdss_dsi0_out {
};
&mss_pil {
- firmware-name = "qcom/sdm845/judyln/mba.mbn", "qcom/sdm845/judyln/modem.mbn";
+ firmware-name = "qcom/sdm845/lg/judyln/mba.mbn", "qcom/sdm845/lg/judyln/modem.mbn";
};
&pmi8998_charger {
@@ -135,3 +141,7 @@ sde_te_active_sleep: sde-te-active-sleep-state {
bias-pull-down;
};
};
+
+&venus {
+ firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
+};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
2025-12-03 9:40 ` [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
@ 2025-12-03 13:47 ` David Heidelberg
2025-12-06 2:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 29+ messages in thread
From: David Heidelberg @ 2025-12-03 13:47 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
On 03/12/2025 10:40, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
>
> Enable adsp and cdsp nodes since their firmware is present
>
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
>
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 20 +++++++++++++++-----
> 2 files changed, 25 insertions(+), 5 deletions(-)
>
[...]
> &adsp_pas {
> - firmware-name = "qcom/sdm845/judyln/adsp.mbn";
> + firmware-name = "qcom/sdm845/lg/judyln/adsp.mbn";
> };
>
Since you'll be rebasing again anyway, the current recommendation is using
sdm845/Vendor/codename, thus in case of LG being whole in uppercase I
would say it should look like:
sdm845/LG/judyln/...
David
[...]
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path
2025-12-03 9:40 ` [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
2025-12-03 13:47 ` David Heidelberg
@ 2025-12-06 2:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-12-06 2:11 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown
On Wed, Dec 03, 2025 at 01:40:55AM -0800, Paul Sajna wrote:
> Add paths for Qualcomm firmware, including:
> ipa, modem, bluetooth, venus, gpu
>
> Enable adsp and cdsp nodes since their firmware is present
>
> GPU and bluetooth are confirmed working, others may need more
> testing/fixes
>
> But regardless they will need the firmware paths specified here
> and firmware added upstream before they will work, so might as well
> get started on it now.
Two separate commits, please.
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 10 ++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 20 +++++++++++++++-----
> 2 files changed, 25 insertions(+), 5 deletions(-)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (5 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 06/12] arm64: dts: qcom: sdm845-lg-judyln: Add firmware nodes, change path Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-06 2:12 ` Dmitry Baryshkov
2025-12-03 9:40 ` [PATCH v5 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
` (4 subsequent siblings)
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio
Wi-Fi now works with this patch and relevant firmware
ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
ath10k_snoc 18800000.wifi: qmi fw_version 0x20060285 fw_build_timestamp 2020-10-12 23:35 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c4-00645-QCAHLSWMTPLZ-1.336037.2
ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 1 tracing 0 dfs 0 testmode 0
ath10k_snoc 18800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
ath10k_snoc 18800000.wifi: htt-ver 3.83 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 12 ++++++++++++
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 4 ++++
2 files changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 315fdc5dc392..f12e785db893 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -673,3 +673,15 @@ &wifi {
&venus {
status = "okay";
};
+
+&wifi {
+ vdd-0.8-cx-mx-supply = <&vreg_l5a_0p8>;
+ vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
+ vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
+ vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
+
+ qcom,snoc-host-cap-skip-quirk;
+
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 49d285c3e6b2..8b88f75b36af 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -145,3 +145,7 @@ sde_te_active_sleep: sde-te-active-sleep-state {
&venus {
firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
};
+
+&wifi {
+ qcom,calibration-variant = "lg_judyln";
+};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node
2025-12-03 9:40 ` [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
@ 2025-12-06 2:12 ` Dmitry Baryshkov
2026-03-24 3:07 ` Paul Sajna
0 siblings, 1 reply; 29+ messages in thread
From: Dmitry Baryshkov @ 2025-12-06 2:12 UTC (permalink / raw)
To: Paul Sajna
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown, Konrad Dybcio
On Wed, Dec 03, 2025 at 01:40:56AM -0800, Paul Sajna wrote:
> Wi-Fi now works with this patch and relevant firmware
>
> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001
> ath10k_snoc 18800000.wifi: qmi fw_version 0x20060285 fw_build_timestamp 2020-10-12 23:35 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0.c4-00645-QCAHLSWMTPLZ-1.336037.2
> ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
> ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 1 tracing 0 dfs 0 testmode 0
> ath10k_snoc 18800000.wifi: firmware ver api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
> ath10k_snoc 18800000.wifi: htt-ver 3.83 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
> ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 12 ++++++++++++
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 4 ++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 49d285c3e6b2..8b88f75b36af 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -145,3 +145,7 @@ sde_te_active_sleep: sde-te-active-sleep-state {
> &venus {
> firmware-name = "qcom/sdm845/lg/judyln/venus.mbn";
> };
> +
> +&wifi {
> + qcom,calibration-variant = "lg_judyln";
Please submit the bdf file to ath10k: https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> +};
>
> --
> 2.52.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node
2025-12-06 2:12 ` Dmitry Baryshkov
@ 2026-03-24 3:07 ` Paul Sajna
0 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2026-03-24 3:07 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, phone-devel, ~postmarketos/upstreaming, Amir Dahan,
Christopher Brown, Konrad Dybcio
> Please submit the bdf file to ath10k: https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
> >
> > +};
> >
> > --
> > 2.52.0
> >
> --
> With best wishes
> Dmitry
>
Sent (a while ago) https://lore.kernel.org/ath10k/c4ae548c-468d-4451-87dd-460b4e72945d@postmarketos.org/
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (6 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 07/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Add wifi node Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 9:40 ` [PATCH v5 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
` (3 subsequent siblings)
11 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio, Dmitry Baryshkov
The sdm845-lg devices are all phones, therefore handset chassis
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index f12e785db893..93b9a0246510 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -28,6 +28,8 @@
/delete-node/ &wlan_msa_mem;
/ {
+ chassis-type = "handset";
+
aliases {
serial0 = &uart9;
serial1 = &uart6;
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* [PATCH v5 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (7 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 08/12] arm64: dts: qcom: sdm845-lg-common: Add chassis-type Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-03 9:40 ` [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
` (2 subsequent siblings)
11 siblings, 0 replies; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna, Konrad Dybcio
Camera doesn't work yet (imx351), but we can use the flash as a flashlight.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 93b9a0246510..1a80921ff744 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -494,6 +494,19 @@ &pm8998_resin {
status = "okay";
};
+&pmi8998_flash {
+ status = "okay";
+
+ led-0 {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ led-sources = <2>;
+ led-max-microamp = <100000>;
+ flash-max-microamp = <500000>;
+ flash-max-timeout-us = <500000>;
+ };
+};
+
&pmi8998_lpg {
status = "okay";
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (8 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 09/12] arm64: dts: qcom: sdm845-lg-common: Add camera flash Paul Sajna
@ 2025-12-03 9:40 ` Paul Sajna
2025-12-04 12:50 ` Konrad Dybcio
2025-12-03 9:41 ` [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
2025-12-03 9:41 ` [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem Paul Sajna
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna
These regulators are required for the LCD
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
index 8b88f75b36af..cdaf84de5e6c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
@@ -56,10 +56,27 @@ zap-shader {
};
};
+&ibb {
+ regulator-min-microvolt = <5500000>;
+ regulator-max-microvolt = <5700000>;
+ regulator-over-current-protection;
+ regulator-pull-down;
+ regulator-soft-start;
+ qcom,discharge-resistor-kohms = <300>;
+};
+
&ipa {
firmware-name = "qcom/sdm845/lg/judyln/ipa_fws.mbn";
};
+&lab {
+ regulator-min-microvolt = <5500000>;
+ regulator-max-microvolt = <5700000>;
+ regulator-over-current-protection;
+ regulator-pull-down;
+ regulator-soft-start;
+};
+
&mdss {
status = "okay";
};
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
2025-12-03 9:40 ` [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
@ 2025-12-04 12:50 ` Konrad Dybcio
2025-12-04 18:47 ` Paul Sajna
0 siblings, 1 reply; 29+ messages in thread
From: Konrad Dybcio @ 2025-12-04 12:50 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
On 12/3/25 10:40 AM, Paul Sajna wrote:
> These regulators are required for the LCD
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> index 8b88f75b36af..cdaf84de5e6c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> @@ -56,10 +56,27 @@ zap-shader {
> };
> };
>
> +&ibb {
> + regulator-min-microvolt = <5500000>;
> + regulator-max-microvolt = <5700000>;
These ranges seem much more reasonable, although I would still
expect there's a single operational voltage - unless the panel driver
is supposed to call regulator_set_voltage() in some different power
modes?
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
2025-12-04 12:50 ` Konrad Dybcio
@ 2025-12-04 18:47 ` Paul Sajna
2025-12-05 10:35 ` Konrad Dybcio
0 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-04 18:47 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
December 4, 2025 at 12:50 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>
> On 12/3/25 10:40 AM, Paul Sajna wrote:
>
> >
> > These regulators are required for the LCD
> >
> > Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > index 8b88f75b36af..cdaf84de5e6c 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
> > @@ -56,10 +56,27 @@ zap-shader {
> > };
> > };
> >
> > +&ibb {
> > + regulator-min-microvolt = <5500000>;
> > + regulator-max-microvolt = <5700000>;
> >
> These ranges seem much more reasonable, although I would still
> expect there's a single operational voltage - unless the panel driver
> is supposed to call regulator_set_voltage() in some different power
> modes?
>
> Konrad
>
So min/max both 55? Or is there another property I should use?
I wasn't sure if that would be physically hard for the regulator to maintain such precision, so I cross-referenced some other DTs in the qcom folder and found this 200mv allowance in one of the sony devices.
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb
2025-12-04 18:47 ` Paul Sajna
@ 2025-12-05 10:35 ` Konrad Dybcio
0 siblings, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-12-05 10:35 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
On 12/4/25 7:47 PM, Paul Sajna wrote:
> December 4, 2025 at 12:50 PM, "Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com mailto:konrad.dybcio@oss.qualcomm.com?to=%22Konrad%20Dybcio%22%20%3Ckonrad.dybcio%40oss.qualcomm.com%3E > wrote:
>
>
>>
>> On 12/3/25 10:40 AM, Paul Sajna wrote:
>>
>>>
>>> These regulators are required for the LCD
>>>
>>> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts | 17 +++++++++++++++++
>>> 1 file changed, 17 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> index 8b88f75b36af..cdaf84de5e6c 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845-lg-judyln.dts
>>> @@ -56,10 +56,27 @@ zap-shader {
>>> };
>>> };
>>>
>>> +&ibb {
>>> + regulator-min-microvolt = <5500000>;
>>> + regulator-max-microvolt = <5700000>;
>>>
>> These ranges seem much more reasonable, although I would still
>> expect there's a single operational voltage - unless the panel driver
>> is supposed to call regulator_set_voltage() in some different power
>> modes?
>>
>> Konrad
>>
>
> So min/max both 55? Or is there another property I should use?
> I wasn't sure if that would be physically hard for the regulator to maintain such precision, so I cross-referenced some other DTs in the qcom folder and found this 200mv allowance in one of the sony devices.
These regulators are very accurate - set it to 5.5
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self'
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (9 preceding siblings ...)
2025-12-03 9:40 ` [PATCH v5 10/12] arm64: dts: qcom: sdm845-lg-judyln: Add lab/ibb Paul Sajna
@ 2025-12-03 9:41 ` Paul Sajna
2025-12-04 9:22 ` Konrad Dybcio
2025-12-03 9:41 ` [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem Paul Sajna
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna
This lets modem get a bit closer to working
ipa 1e40000.ipa: channel 4 limited to 256 TREs
ipa 1e40000.ipa: IPA driver initialized
ipa 1e40000.ipa: received modem starting event
ipa 1e40000.ipa: received modem running event
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index 1a80921ff744..bfa0ecec82fd 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -469,7 +469,7 @@ &gpu {
};
&ipa {
- qcom,gsi-loader = "modem";
+ qcom,gsi-loader = "self";
memory-region = <&ipa_fw_mem>;
status = "okay";
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self'
2025-12-03 9:41 ` [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
@ 2025-12-04 9:22 ` Konrad Dybcio
0 siblings, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-12-04 9:22 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
On 12/3/25 10:41 AM, Paul Sajna wrote:
> This lets modem get a bit closer to working
>
> ipa 1e40000.ipa: channel 4 limited to 256 TREs
> ipa 1e40000.ipa: IPA driver initialized
> ipa 1e40000.ipa: received modem starting event
> ipa 1e40000.ipa: received modem running event
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
"The modem firmware for this device doesn't preload the IPA firmware
and requires the OS handles that instead. Set qcom,gsi-loader = "self"
to reflect that."
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread
* [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem
2025-12-03 9:40 [PATCH v5 00/12] arm64: dts: qcom: sdm845-lg-{common, judyln}: Improve HW support in dts Paul Sajna
` (10 preceding siblings ...)
2025-12-03 9:41 ` [PATCH v5 11/12] arm64: dts: qcom: sdm845-lg-common: Change ipa gsi-loader to 'self' Paul Sajna
@ 2025-12-03 9:41 ` Paul Sajna
2025-12-04 9:23 ` Konrad Dybcio
11 siblings, 1 reply; 29+ messages in thread
From: Paul Sajna @ 2025-12-03 9:41 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown,
Paul Sajna
It causes this warning
[ 0.000000] OF: reserved mem: OVERLAP DETECTED!
framebuffer@9d400000
(0x000000009d400000--0x000000009f800000) overlaps with
memory@9d400000 (0x000000009d400000--0x000000009f800000)
Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
---
arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
index bfa0ecec82fd..5946d1e60b6e 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi
@@ -98,12 +98,6 @@ spss_mem: memory@99000000 {
no-map;
};
- /* Framebuffer region */
- memory@9d400000 {
- reg = <0x0 0x9d400000 0x0 0x2400000>;
- no-map;
- };
-
qseecom_mem: memory@b2000000 {
reg = <0 0xb2000000 0 0x1800000>;
no-map;
--
2.52.0
^ permalink raw reply [flat|nested] 29+ messages in thread* Re: [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem
2025-12-03 9:41 ` [PATCH v5 12/12] arm64: dts: qcom: sdm845-lg-common: remove framebuffer reserved-mem Paul Sajna
@ 2025-12-04 9:23 ` Konrad Dybcio
0 siblings, 0 replies; 29+ messages in thread
From: Konrad Dybcio @ 2025-12-04 9:23 UTC (permalink / raw)
To: Paul Sajna, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, David Heidelberg
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
~postmarketos/upstreaming, Amir Dahan, Christopher Brown
On 12/3/25 10:41 AM, Paul Sajna wrote:
> It causes this warning
>
> [ 0.000000] OF: reserved mem: OVERLAP DETECTED!
> framebuffer@9d400000
> (0x000000009d400000--0x000000009f800000) overlaps with
> memory@9d400000 (0x000000009d400000--0x000000009f800000)
>
> Signed-off-by: Paul Sajna <sajattack@postmarketos.org>
> ---
I think we concluded this doesn't really apply on -next
Konrad
^ permalink raw reply [flat|nested] 29+ messages in thread