[PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Marek Vasut]

Update drm_of_get_data_lanes_count_ep() return value documentation
to match the drm_of_get_data_lanes_count() return value documentation.
The drm_of_get_data_lanes_count_ep() is only a wrapper around the
drm_of_get_data_lanes_count() and therefore returns the same error
codes.

Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: David Airlie <airlied@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
 drivers/gpu/drm/drm_of.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index 4f65ce729a473..cfd0518174de8 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
  *
  * Return:
  * * min..max - positive integer count of "data-lanes" elements
- * * -EINVAL - the "data-mapping" property is unsupported
- * * -ENODEV - the "data-mapping" property is missing
+ * * -ve - the "data-lanes" property is missing or invalid
+ * * -EINVAL - the "data-lanes" property is unsupported
  */
 int drm_of_get_data_lanes_count_ep(const struct device_node *port,
 				   int port_reg, int reg,
-- 
2.51.0

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Marek Vasut]

On 1/15/26 3:45 AM, Marek Vasut wrote:
> Update drm_of_get_data_lanes_count_ep() return value documentation
> to match the drm_of_get_data_lanes_count() return value documentation.
> The drm_of_get_data_lanes_count_ep() is only a wrapper around the
> drm_of_get_data_lanes_count() and therefore returns the same error
> codes.
> 
> Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>   drivers/gpu/drm/drm_of.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 4f65ce729a473..cfd0518174de8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
>    *
>    * Return:
>    * * min..max - positive integer count of "data-lanes" elements
> - * * -EINVAL - the "data-mapping" property is unsupported
> - * * -ENODEV - the "data-mapping" property is missing
> + * * -ve - the "data-lanes" property is missing or invalid
> + * * -EINVAL - the "data-lanes" property is unsupported
>    */
>   int drm_of_get_data_lanes_count_ep(const struct device_node *port,
>   				   int port_reg, int reg,


Is anything missing here or can this be applied ?

Thank you

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Marek Vasut]

On 2/6/26 12:49 PM, Marek Vasut wrote:
> On 1/15/26 3:45 AM, Marek Vasut wrote:
>> Update drm_of_get_data_lanes_count_ep() return value documentation
>> to match the drm_of_get_data_lanes_count() return value documentation.
>> The drm_of_get_data_lanes_count_ep() is only a wrapper around the
>> drm_of_get_data_lanes_count() and therefore returns the same error
>> codes.
>>
>> Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and 
>> drm_of_get_data_lanes_ep")
>> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: David Airlie <airlied@gmail.com>
>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> Cc: Simona Vetter <simona@ffwll.ch>
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: dri-devel@lists.freedesktop.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>>   drivers/gpu/drm/drm_of.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>> index 4f65ce729a473..cfd0518174de8 100644
>> --- a/drivers/gpu/drm/drm_of.c
>> +++ b/drivers/gpu/drm/drm_of.c
>> @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
>>    *
>>    * Return:
>>    * * min..max - positive integer count of "data-lanes" elements
>> - * * -EINVAL - the "data-mapping" property is unsupported
>> - * * -ENODEV - the "data-mapping" property is missing
>> + * * -ve - the "data-lanes" property is missing or invalid
>> + * * -EINVAL - the "data-lanes" property is unsupported
>>    */
>>   int drm_of_get_data_lanes_count_ep(const struct device_node *port,
>>                      int port_reg, int reg,
> 
> 
> Is anything missing here or can this be applied ?

Can this be applied now ?

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
> Update drm_of_get_data_lanes_count_ep() return value documentation
> to match the drm_of_get_data_lanes_count() return value documentation.
> The drm_of_get_data_lanes_count_ep() is only a wrapper around the
> drm_of_get_data_lanes_count() and therefore returns the same error
> codes.
> 
> Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: David Airlie <airlied@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Simona Vetter <simona@ffwll.ch>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>  drivers/gpu/drm/drm_of.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index 4f65ce729a473..cfd0518174de8 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
>   *
>   * Return:
>   * * min..max - positive integer count of "data-lanes" elements
> - * * -EINVAL - the "data-mapping" property is unsupported
> - * * -ENODEV - the "data-mapping" property is missing
> + * * -ve - the "data-lanes" property is missing or invalid

I have no idea what "ve" means in that context. We should rephrase or
pick something more obvious.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Geert Uytterhoeven]

Hi Maxime,

On Tue, 3 Mar 2026 at 09:07, Maxime Ripard <mripard@kernel.org> wrote:
> On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
> > Update drm_of_get_data_lanes_count_ep() return value documentation
> > to match the drm_of_get_data_lanes_count() return value documentation.
> > The drm_of_get_data_lanes_count_ep() is only a wrapper around the
> > drm_of_get_data_lanes_count() and therefore returns the same error
> > codes.
> >
> > Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
> > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
> >   *
> >   * Return:
> >   * * min..max - positive integer count of "data-lanes" elements
> > - * * -EINVAL - the "data-mapping" property is unsupported
> > - * * -ENODEV - the "data-mapping" property is missing
> > + * * -ve - the "data-lanes" property is missing or invalid
>
> I have no idea what "ve" means in that context. We should rephrase or
> pick something more obvious.

"-ve" = negative, "+ve" = positive.

git grep "\s[-+]ve\>"

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

On Tue, Mar 03, 2026 at 09:14:53AM +0100, Geert Uytterhoeven wrote:
> Hi Maxime,
> 
> On Tue, 3 Mar 2026 at 09:07, Maxime Ripard <mripard@kernel.org> wrote:
> > On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
> > > Update drm_of_get_data_lanes_count_ep() return value documentation
> > > to match the drm_of_get_data_lanes_count() return value documentation.
> > > The drm_of_get_data_lanes_count_ep() is only a wrapper around the
> > > drm_of_get_data_lanes_count() and therefore returns the same error
> > > codes.
> > >
> > > Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> 
> > > --- a/drivers/gpu/drm/drm_of.c
> > > +++ b/drivers/gpu/drm/drm_of.c
> > > @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
> > >   *
> > >   * Return:
> > >   * * min..max - positive integer count of "data-lanes" elements
> > > - * * -EINVAL - the "data-mapping" property is unsupported
> > > - * * -ENODEV - the "data-mapping" property is missing
> > > + * * -ve - the "data-lanes" property is missing or invalid
> >
> > I have no idea what "ve" means in that context. We should rephrase or
> > pick something more obvious.
> 
> "-ve" = negative, "+ve" = positive.

Thanks!

My point still stands though.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Luca Ceresoli]

Hello,

On Tue Mar 3, 2026 at 9:39 AM CET, Maxime Ripard wrote:
> On Tue, Mar 03, 2026 at 09:14:53AM +0100, Geert Uytterhoeven wrote:
>> Hi Maxime,
>>
>> On Tue, 3 Mar 2026 at 09:07, Maxime Ripard <mripard@kernel.org> wrote:
>> > On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
>> > > Update drm_of_get_data_lanes_count_ep() return value documentation
>> > > to match the drm_of_get_data_lanes_count() return value documentation.
>> > > The drm_of_get_data_lanes_count_ep() is only a wrapper around the
>> > > drm_of_get_data_lanes_count() and therefore returns the same error
>> > > codes.
>> > >
>> > > Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
>> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>
>> > > --- a/drivers/gpu/drm/drm_of.c
>> > > +++ b/drivers/gpu/drm/drm_of.c
>> > > @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
>> > >   *
>> > >   * Return:
>> > >   * * min..max - positive integer count of "data-lanes" elements
>> > > - * * -EINVAL - the "data-mapping" property is unsupported
>> > > - * * -ENODEV - the "data-mapping" property is missing
>> > > + * * -ve - the "data-lanes" property is missing or invalid
>> >
>> > I have no idea what "ve" means in that context. We should rephrase or
>> > pick something more obvious.
>>
>> "-ve" = negative, "+ve" = positive.
>
> Thanks!
>
> My point still stands though.

I also stared at "-ve" cluelessly, so I vote for plain English too.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Marek Vasut]

On 3/3/26 9:39 AM, Maxime Ripard wrote:
> On Tue, Mar 03, 2026 at 09:14:53AM +0100, Geert Uytterhoeven wrote:
>> Hi Maxime,
>>
>> On Tue, 3 Mar 2026 at 09:07, Maxime Ripard <mripard@kernel.org> wrote:
>>> On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
>>>> Update drm_of_get_data_lanes_count_ep() return value documentation
>>>> to match the drm_of_get_data_lanes_count() return value documentation.
>>>> The drm_of_get_data_lanes_count_ep() is only a wrapper around the
>>>> drm_of_get_data_lanes_count() and therefore returns the same error
>>>> codes.
>>>>
>>>> Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
>>>> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>
>>>> --- a/drivers/gpu/drm/drm_of.c
>>>> +++ b/drivers/gpu/drm/drm_of.c
>>>> @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
>>>>    *
>>>>    * Return:
>>>>    * * min..max - positive integer count of "data-lanes" elements
>>>> - * * -EINVAL - the "data-mapping" property is unsupported
>>>> - * * -ENODEV - the "data-mapping" property is missing
>>>> + * * -ve - the "data-lanes" property is missing or invalid
>>>
>>> I have no idea what "ve" means in that context. We should rephrase or
>>> pick something more obvious.
>>
>> "-ve" = negative, "+ve" = positive.
> 
> Thanks!
> 
> My point still stands though.
What would you recommend ?

Note that the documentation for this function is aligned with 
documentation for drm_of_get_data_lanes_count() by this fix, and 
drm_of_get_data_lanes_count() also uses -ve to denote negative error value.