mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>, <linux-kernel@vger.kernel.org>
Cc: <frederic@kernel.org>, <jstultz@google.com>,
	<juri.lelli@redhat.com>, <meted@linux.ibm.com>,
	<mingo@redhat.com>, <peterz@infradead.org>,
	<sshegde@linux.ibm.com>, <tglx@linutronix.de>,
	<vincent.guittot@linaro.org>, <vschneid@redhat.com>
Subject: Re: [PATCH v2 0/6] sched: dynamic: Simplify PREEMPT_DYNAMIC
Date: Thu, 3 Sep 2026 09:30:35 +0800	[thread overview]
Message-ID: <6f4a009f-4261-4cce-88b6-1dec5ecc3a53@huawei.com> (raw)
In-Reply-To: <c1b65ff3-4982-49f9-9d4a-c05ed9d903b1@huawei.com>



在 2026/8/7 11:11, Jinjie Ruan 写道:
> 
> 
> 在 2026/8/4 3:17, Mark Rutland 写道:
>> All architectures which currently suppoort PREEMPT_DYNAMIC select
>> ARCH_HAS_PREEMPT_LAZY.  On architectures which select
>> ARCH_HAS_PREEMPT_LAZY, it has not been possible to select the NONE and
>> VOLUNTARY preemption models since v7.0 due to commit:
>>
>>   7dadeaa6e851 ("sched: Further restrict the preemption modes")
>>
>> Hence in practice PREEMPT_DYNAMIC no longer supports the NONE or
>> VOLUNTARY preemption models.
>>
>> This series makes the de-facto situation official by making
>> PREEMPT_DYNAMIC depend on ARCH_HAS_PREEMPT_LAZY, and removing redundant
>> code.
>>
>> Since v1, I've had to rebase atop v7.2-rc4 to avoid a conflict with
>> commit:
>>
>>   a2c02aa0c6ca ("powerpc: Remove dead non-preemption code")
>>
>> Given this is now late in the cycle, and given the tip:sched/core branch
>> is based on v7.2-rc1, I suspect tip folk might not want to queue this
>> now. Please let me know what you'd prefer; I'm happy to rebase and
>> resend after v7.3-rc1.
>>
>> Since v1:
>> * Rebase to v7.2-rc4
>> * Apply Revied-by tags.
>> * Fix typos in commit messages.
>> * Add patch to cleanup accessors (per Shrikanth's comment)
>>
>> Mark.
>>
>> Mark Rutland (6):
>>   sched: dynamic: Make PREEMPT_DYNAMIC depend on ARCH_HAS_PREEMPT_LAZY
>>   sched: dynamic: Simplify {cond,might}_resched()
> 
> 
> Hi Mark,
> 
> We also need to update the Doc.
> 
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5410,8 +5410,6 @@ Kernel parameters
> 
>         preempt=        [KNL]
>                         Select preemption mode if you have
> CONFIG_PREEMPT_DYNAMIC
> -                       none - Limited to cond_resched() calls
> -                       voluntary - Limited to cond_resched() and
> might_sleep() calls
>                         full - Any section that isn't explicitly preempt
> disabled
>                                can be preempted anytime.  Tasks will
> also yield
>                                contended spinlocks (if the critical

Hi Mark,

What do you think?


> section isn't
> 
> Best regards,
> Jinjie
> 
>>   sched: dynamic: Simplify preempt_schedule{,_notrace}()
>>   sched: dynamic: Simplify irqentry_exit_cond_resched()
>>   sched: dynamic: Remove HAVE_PREEMPT_DYNAMIC_{CALL,KEY}
>>   sched: dynamic: Simplify preempt model accessors
>>
>>  arch/Kconfig                     |  38 -------
>>  arch/arm64/Kconfig               |   1 -
>>  arch/arm64/include/asm/preempt.h |  10 --
>>  arch/loongarch/Kconfig           |   1 -
>>  arch/powerpc/Kconfig             |   1 -
>>  arch/riscv/Kconfig               |   1 -
>>  arch/s390/Kconfig                |   1 -
>>  arch/s390/include/asm/preempt.h  |  11 --
>>  arch/x86/Kconfig                 |   1 -
>>  arch/x86/include/asm/preempt.h   |  28 -----
>>  include/asm-generic/preempt.h    |  10 --
>>  include/linux/irq-entry-common.h |  17 +--
>>  include/linux/kernel.h           |  20 ----
>>  include/linux/preempt.h          |  20 ++--
>>  include/linux/sched.h            |  31 +-----
>>  kernel/Kconfig.preempt           |   9 +-
>>  kernel/entry/common.c            |  17 +--
>>  kernel/sched/core.c              | 180 +------------------------------
>>  18 files changed, 23 insertions(+), 374 deletions(-)
>>
> 


  reply	other threads:[~2026-09-03  1:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 19:17 Mark Rutland
2026-08-03 19:17 ` [PATCH v2 1/6] sched: dynamic: Make PREEMPT_DYNAMIC depend on ARCH_HAS_PREEMPT_LAZY Mark Rutland
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-03 19:17 ` [PATCH v2 2/6] sched: dynamic: Simplify {cond,might}_resched() Mark Rutland
2026-08-05 10:08   ` Jinjie Ruan
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-03 19:17 ` [PATCH v2 3/6] sched: dynamic: Simplify preempt_schedule{,_notrace}() Mark Rutland
2026-08-06 13:23   ` Jinjie Ruan
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-03 19:17 ` [PATCH v2 4/6] sched: dynamic: Simplify irqentry_exit_cond_resched() Mark Rutland
2026-08-07  1:35   ` Jinjie Ruan
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-03 19:17 ` [PATCH v2 5/6] sched: dynamic: Remove HAVE_PREEMPT_DYNAMIC_{CALL,KEY} Mark Rutland
2026-08-07  1:54   ` Jinjie Ruan
2026-09-01 15:26     ` Mark Rutland
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-03 19:17 ` [PATCH v2 6/6] sched: dynamic: Simplify preempt model accessors Mark Rutland
2026-08-07  2:00   ` Jinjie Ruan
2026-09-01 16:03     ` Mark Rutland
2026-09-02  7:54   ` [tip: sched/core] " tip-bot2 for Mark Rutland
2026-08-05  9:52 ` [PATCH v2 0/6] sched: dynamic: Simplify PREEMPT_DYNAMIC Mete Durlu
2026-08-06 12:15 ` Shrikanth Hegde
2026-08-07  3:11 ` Jinjie Ruan
2026-09-03  1:30   ` Jinjie Ruan [this message]
2026-08-07  3:33 ` Jinjie Ruan
2026-09-01 16:04   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f4a009f-4261-4cce-88b6-1dec5ecc3a53@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=frederic@kernel.org \
    --cc=jstultz@google.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=meted@linux.ibm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®