[PATCH 0/2] clk: qcom: Mark the GPU CX GDSC as votable for Glymur and Kaanapali

[PATCH 0/2] clk: qcom: Mark the GPU CX GDSC as votable for Glymur and Kaanapali

[Taniya Das]

The GPU CX GDSC on both Glymur and Kaanapali is a votable power
domain, but it was configured with POLL_CFG_GDSCR instead of VOTABLE
when the respective GPUCC drivers were added. Fix both drivers to set
the VOTABLE flag so the GDSC driver correctly treats collapse requests
as always successful, matching other platforms with a votable GPU CX
GDSC (e.g. SM8750, Milos).

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
Taniya Das (2):
      clk: qcom: gpucc-glymur: Mark the GPU CX GDSC as votable
      clk: qcom: gpucc-kaanapali: Mark the GPU CX GDSC as votable

 drivers/clk/qcom/gpucc-glymur.c    | 2 +-
 drivers/clk/qcom/gpucc-kaanapali.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
base-commit: 415606a7be939835db9b0d6b711887586646346d
change-id: 20260801-kaanapali-gpu-voteable-458e7fb07c91

Best regards,
-- 
Taniya Das <taniya.das@oss.qualcomm.com>

[PATCH 1/2] clk: qcom: gpucc-glymur: Mark the GPU CX GDSC as votable

[Taniya Das]

The GPU CX GDSC on Glymur is a votable power domain and hence should
not be polled for power-off status during GDSC disable. Also, its
power-on status should be read from the GDS hardware control register.

Accommodate this by removing POLL_CFG_GDSCR and adding the VOTABLE
flag for the GPU CX GDSC, similar to other platforms (e.g. SM8750 and
Milos).

Fixes: 67e645285dd0 ("clk: qcom: Add support for GPUCC and GXCLK for Glymur")
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 drivers/clk/qcom/gpucc-glymur.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gpucc-glymur.c b/drivers/clk/qcom/gpucc-glymur.c
index 001b2454786a0c0d63370b3ff385ed5a2bff1b07..cac51de20b2950733d6d48ceb14e60d6181665ab 100644
--- a/drivers/clk/qcom/gpucc-glymur.c
+++ b/drivers/clk/qcom/gpucc-glymur.c
@@ -510,7 +510,7 @@ static struct gdsc gpu_cc_cx_gdsc = {
 		.name = "gpu_cc_cx_gdsc",
 	},
 	.pwrsts = PWRSTS_OFF_ON,
-	.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
+	.flags = RETAIN_FF_ENABLE | VOTABLE,
 };
 
 static struct clk_regmap *gpu_cc_glymur_clocks[] = {

-- 
2.34.1

Re: [PATCH 1/2] clk: qcom: gpucc-glymur: Mark the GPU CX GDSC as votable

[Jagadeesh Kona]

On 8/1/2026 11:01 PM, Taniya Das wrote:
> The GPU CX GDSC on Glymur is a votable power domain and hence should
> not be polled for power-off status during GDSC disable. Also, its
> power-on status should be read from the GDS hardware control register.
> 
> Accommodate this by removing POLL_CFG_GDSCR and adding the VOTABLE
> flag for the GPU CX GDSC, similar to other platforms (e.g. SM8750 and
> Milos).
> 

Reviewed-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

Thanks,
Jagadeesh

[PATCH 2/2] clk: qcom: gpucc-kaanapali: Mark the GPU CX GDSC as votable

[Taniya Das]

The GPU CX GDSC on Kaanapali is a votable power domain and hence
should not be polled for power-off status during GDSC disable. Also,
its power-on status should be read from the GDS hardware control
register.

Accommodate this by removing POLL_CFG_GDSCR and adding the VOTABLE
flag for the GPU CX GDSC, similar to other platforms (e.g. SM8750 and
Milos).

Fixes: 685ec348339b ("clk: qcom: Add support for GPUCC and GXCLK for Kaanapali")
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 drivers/clk/qcom/gpucc-kaanapali.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/gpucc-kaanapali.c b/drivers/clk/qcom/gpucc-kaanapali.c
index ae5563e516f6770adfcd52252a1712dde2c80b9a..f75f2caa2205c4720f7510c9226b4f91a5403d52 100644
--- a/drivers/clk/qcom/gpucc-kaanapali.c
+++ b/drivers/clk/qcom/gpucc-kaanapali.c
@@ -380,7 +380,7 @@ static struct gdsc gpu_cc_cx_gdsc = {
 		.name = "gpu_cc_cx_gdsc",
 	},
 	.pwrsts = PWRSTS_OFF_ON,
-	.flags = POLL_CFG_GDSCR | RETAIN_FF_ENABLE,
+	.flags = RETAIN_FF_ENABLE | VOTABLE,
 };
 
 static struct clk_regmap *gpu_cc_kaanapali_clocks[] = {

-- 
2.34.1

Re: [PATCH 2/2] clk: qcom: gpucc-kaanapali: Mark the GPU CX GDSC as votable

[Jagadeesh Kona]

On 8/1/2026 11:01 PM, Taniya Das wrote:
> The GPU CX GDSC on Kaanapali is a votable power domain and hence
> should not be polled for power-off status during GDSC disable. Also,
> its power-on status should be read from the GDS hardware control
> register.
> 
> Accommodate this by removing POLL_CFG_GDSCR and adding the VOTABLE
> flag for the GPU CX GDSC, similar to other platforms (e.g. SM8750 and
> Milos).
> 
> Fixes: 685ec348339b ("clk: qcom: Add support for GPUCC and GXCLK for Kaanapali")
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/gpucc-kaanapali.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

Thanks,
Jagadeesh

Re: [PATCH 0/2] clk: qcom: Mark the GPU CX GDSC as votable for Glymur and Kaanapali

[Bjorn Andersson]

On Sat, 01 Aug 2026 23:01:16 +0530, Taniya Das wrote:
> The GPU CX GDSC on both Glymur and Kaanapali is a votable power
> domain, but it was configured with POLL_CFG_GDSCR instead of VOTABLE
> when the respective GPUCC drivers were added. Fix both drivers to set
> the VOTABLE flag so the GDSC driver correctly treats collapse requests
> as always successful, matching other platforms with a votable GPU CX
> GDSC (e.g. SM8750, Milos).
> 
> [...]

Applied, thanks!

[1/2] clk: qcom: gpucc-glymur: Mark the GPU CX GDSC as votable
      commit: 370520c31b0f78d56d39d754b7e137c20b2fd625
[2/2] clk: qcom: gpucc-kaanapali: Mark the GPU CX GDSC as votable
      commit: 882c1a7721ea299008489953994b468c3171c249

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 0/2] clk: qcom: Mark the GPU CX GDSC as votable for Glymur and Kaanapali

[Bjorn Andersson]

On Sat, 01 Aug 2026 23:01:16 +0530, Taniya Das wrote:
> The GPU CX GDSC on both Glymur and Kaanapali is a votable power
> domain, but it was configured with POLL_CFG_GDSCR instead of VOTABLE
> when the respective GPUCC drivers were added. Fix both drivers to set
> the VOTABLE flag so the GDSC driver correctly treats collapse requests
> as always successful, matching other platforms with a votable GPU CX
> GDSC (e.g. SM8750, Milos).
> 
> [...]

Applied, thanks!

[1/2] clk: qcom: gpucc-glymur: Mark the GPU CX GDSC as votable
      commit: 8f3f88309fa4e975ac27368ee945c2c202251a7c
[2/2] clk: qcom: gpucc-kaanapali: Mark the GPU CX GDSC as votable
      commit: 55981579b27b6541aeeab81c768f248dba0491ac

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>