mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	"markgross@kernel.org" <markgross@kernel.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] platform/x86: think-lmi: Correct NVME password handling
Date: Mon, 29 May 2023 10:58:08 -0400	[thread overview]
Message-ID: <709df78f-4313-460a-87da-f4d302ed8912@app.fastmail.com> (raw)
In-Reply-To: <a52f69f-2dc4-fe76-9f89-e1c143d2bb27@linux.intel.com>

Thanks Ilpo

On Mon, May 29, 2023, at 8:03 AM, Ilpo Järvinen wrote:
> On Fri, 26 May 2023, Mark Pearson wrote:
>
>> NVME passwords identifier have been standardised across the Lenovo
>> systems and now use udrp and adrp (user and admin level) instead of
>> unvp and mnvp.
>> 
>> This should apparently be backwards compatible.
>> 
>> Also cleaned up so the index is set to a default of 1 rather than 0
>> as this just makes more sense (there is no device 0).
>
> These two sound entirely separate changes. If that's the case, please 
> make own patch from the send change.

Ack. It was all related to the index setting and seemed trivial so I lumped together but I can split.
This patch series is turning into a good learning exercise for my git skills :) (which are limited)

>
> Hmm, index_store() still allows 0, is that also related here? Please check 
> also ABI documentation as index default seems to be mentioned there as 
> well.
>

I'd rather not limit it so 0 isn't allowed in case our BIOS team does something weird in the future; but right now 1 is the default so it makes more sense.

Well spotted on the ABI documentation - I had completely missed that. I will address that as well.

> -- 
>  i.

Thanks for the review
Mark

  reply	other threads:[~2023-05-29 14:58 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-26 17:16 [PATCH v3 1/5] platform/x86: think-lmi: Enable opcode support on BIOS settings Mark Pearson
2023-05-26 17:16 ` [PATCH v3 2/5] platform/x86: think-lmi: Correct System password interface Mark Pearson
2023-05-29 11:36   ` Ilpo Järvinen
2023-05-29 14:44     ` Mark Pearson
2023-05-29 15:50       ` Ilpo Järvinen
2023-05-29 16:10         ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 3/5] platform/x86: think-lmi: Correct NVME password handling Mark Pearson
2023-05-29 12:03   ` Ilpo Järvinen
2023-05-29 14:58     ` Mark Pearson [this message]
2023-05-29 15:41       ` Ilpo Järvinen
2023-05-29 16:06         ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 4/5] platform/x86: think-lmi: Don't display unnecessary authentication settings Mark Pearson
2023-05-29 12:05   ` Ilpo Järvinen
2023-05-29 14:50     ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 5/5] platform/x86: think-lmi: mutex protection around multiple WMI calls Mark Pearson
2023-05-29 12:23   ` Ilpo Järvinen
2023-05-29 14:03     ` Mark Pearson
2023-05-29 11:51 ` [PATCH v3 1/5] platform/x86: think-lmi: Enable opcode support on BIOS settings Ilpo Järvinen
2023-05-29 14:49   ` Mark Pearson
2023-05-29 15:36     ` Ilpo Järvinen
2023-05-29 16:06       ` Mark Pearson
2023-05-30 10:54 ` Hans de Goede
2023-05-30 13:08   ` Mark Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=709df78f-4313-460a-87da-f4d302ed8912@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®