From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: "markgross@kernel.org" <markgross@kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] platform/x86: think-lmi: Enable opcode support on BIOS settings
Date: Tue, 30 May 2023 09:08:49 -0400 [thread overview]
Message-ID: <b9b98752-da3d-4cac-b010-fb13c90bb2f5@app.fastmail.com> (raw)
In-Reply-To: <2ca9ef5d-2a24-c6b7-06fc-5b9919a2aaee@redhat.com>
Hi Hans
On Tue, May 30, 2023, at 6:54 AM, Hans de Goede wrote:
> Hi Mark,
>
> On 5/26/23 19:16, Mark Pearson wrote:
>> Whilst reviewing some documentation from the FW team on using WMI on
>> Lenovo system I noticed that we weren't using Opcode support when
>> changing BIOS settings in the thinkLMI driver.
>>
>> We should be doing this to ensure we're future proof as the old
>> non-opcode mechanism has been deprecated.
>>
>> Tested on X1 Carbon G10 and G11.
>>
>> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>
> Thank you for this new version. Please prepare a v4 addressing Ilpo's
> review remarks.
Will do
>
> About the aligning function arguments on the next line to the '('
> of the function call start at the previous line, checkpatch also
> checks for this.
>
> It is always a good idea to run checkpatch before submitting patches.
I always do - and checkpatch isn't complaining about the alignment here.
Mark
prev parent reply other threads:[~2023-05-30 13:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 17:16 Mark Pearson
2023-05-26 17:16 ` [PATCH v3 2/5] platform/x86: think-lmi: Correct System password interface Mark Pearson
2023-05-29 11:36 ` Ilpo Järvinen
2023-05-29 14:44 ` Mark Pearson
2023-05-29 15:50 ` Ilpo Järvinen
2023-05-29 16:10 ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 3/5] platform/x86: think-lmi: Correct NVME password handling Mark Pearson
2023-05-29 12:03 ` Ilpo Järvinen
2023-05-29 14:58 ` Mark Pearson
2023-05-29 15:41 ` Ilpo Järvinen
2023-05-29 16:06 ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 4/5] platform/x86: think-lmi: Don't display unnecessary authentication settings Mark Pearson
2023-05-29 12:05 ` Ilpo Järvinen
2023-05-29 14:50 ` Mark Pearson
2023-05-26 17:16 ` [PATCH v3 5/5] platform/x86: think-lmi: mutex protection around multiple WMI calls Mark Pearson
2023-05-29 12:23 ` Ilpo Järvinen
2023-05-29 14:03 ` Mark Pearson
2023-05-29 11:51 ` [PATCH v3 1/5] platform/x86: think-lmi: Enable opcode support on BIOS settings Ilpo Järvinen
2023-05-29 14:49 ` Mark Pearson
2023-05-29 15:36 ` Ilpo Järvinen
2023-05-29 16:06 ` Mark Pearson
2023-05-30 10:54 ` Hans de Goede
2023-05-30 13:08 ` Mark Pearson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9b98752-da3d-4cac-b010-fb13c90bb2f5@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®