mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Genes Lists <lists@sapience.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	andrew@lunn.ch,  hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org,  pabeni@redhat.com,
	johanneswueller@gmail.com,
	Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: 6.9.3 Hung tasks
Date: Thu, 30 May 2024 12:23:48 -0400	[thread overview]
Message-ID: <73d37ff63ee7cd88772fc0767f4474317b56a0a8.camel@sapience.com> (raw)
In-Reply-To: <ZliHhebSGQYZ/0S0@shell.armlinux.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 932 bytes --]

On Thu, 2024-05-30 at 15:04 +0100, Russell King (Oracle) wrote:
> ...
> And then we get to pid 858. This is in set_device_name(), which
> was called from led_trigger_set() and led_trigger_register().
> We know from pid 663 that led_trigger_register() can take a read
> on leds_list_lock, and indeed it does and then calls
> led_match_default_trigger(), which then goes on to call
> led_trigger_set(). Bingo, this is why pid 666 is blocked, which
> then blocks pid 663. pid 663 takes the rtnl lock, which blocks
> everything else _and_ also blocks pid 858 in set_device_name().
> 
> Lockdep would've found this... this is a classic AB-BA deadlock
> between the leds_list_lock rwsem and the rtnl mutex.
> 
> I haven't checked to see how that deadlock got introduced, that's
> for someone else to do.
> 


Thank you for the analysis - hopefully someone can track down the
culprit.

cc:  thorsten

-- 
Gene


[-- Attachment #1.2: Type: text/html, Size: 1781 bytes --]

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2024-05-30 16:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 12:53 Genes Lists
2024-05-30 13:36 ` Genes Lists
2024-05-30 14:04   ` Russell King (Oracle)
2024-05-30 16:23     ` Genes Lists [this message]
2024-05-31  8:39     ` Hung tasks due to a AB-BA deadlock between the leds_list_lock rwsem and the rtnl mutex (was: 6.9.3 Hung tasks) Linux regression tracking (Thorsten Leemhuis)
2024-05-31  9:50       ` Hung tasks due to a AB-BA deadlock between the leds_list_lock rwsem and the rtnl mutex Hans de Goede
2024-05-31 10:22         ` Hans de Goede
2024-06-01 20:05           ` Hans de Goede
2024-05-31 11:55         ` Genes Lists
2024-05-31 12:54         ` Andrew Lunn
2024-05-31 13:11           ` Hans de Goede
2024-05-31 13:29             ` Andrew Lunn
2024-05-31 13:36               ` Hans de Goede
2024-06-06 12:01           ` Hans de Goede
2024-06-06 13:12             ` Andrew Lunn
2024-06-06 13:39               ` Jakub Kicinski
2024-06-06 14:25                 ` Genes Lists
2024-06-07 10:22                   ` Hans de Goede
2024-06-07 11:27                     ` Genes Lists
2024-06-07 10:19                 ` Hans de Goede
2024-06-24 19:57           ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d37ff63ee7cd88772fc0767f4474317b56a0a8.camel@sapience.com \
    --to=lists@sapience.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=johanneswueller@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linux@leemhuis.info \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®