From: Andrew Lunn <andrew@lunn.ch>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Linux LEDs <linux-leds@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, johanneswueller@gmail.com,
"Russell King (Oracle)" <linux@armlinux.org.uk>,
Genes Lists <lists@sapience.com>
Subject: Re: Hung tasks due to a AB-BA deadlock between the leds_list_lock rwsem and the rtnl mutex
Date: Fri, 31 May 2024 15:29:09 +0200 [thread overview]
Message-ID: <e6800715-6bc0-49a0-bd00-5a75b852ea9d@lunn.ch> (raw)
In-Reply-To: <2a6045e2-031a-46b6-9943-eaae21d85e37@redhat.com>
> > drivers/net/ethernet/realtek/r8169_leds.c: led_cdev->hw_control_trigger = "netdev";
> > drivers/net/ethernet/realtek/r8169_leds.c: led_cdev->hw_control_trigger = "netdev";
> > drivers/net/ethernet/intel/igc/igc_leds.c: led_cdev->hw_control_trigger = "netdev";
> > drivers/net/dsa/qca/qca8k-leds.c: port_led->cdev.hw_control_trigger = "netdev";
> > drivers/net/phy/phy_device.c: cdev->hw_control_trigger = "netdev";
>
> Well those drivers combined, esp. with the generic phy_device in there
> does mean that the ledtrig-netdev module now gets loaded on a whole lot
> of x86 machines where before it would not.
phy_device will only do something if there is the needed Device Tree
properties. Given that very few systems use DT on x86, that should not
be an issue. So only x86 systems with r8169 and igc should have the
trigger module loaded because of this. It would be good to understand
why other systems have the trigger loaded. However, as you say, this
will not fix the underlying deadlock, it will just limit it to systems with r8169
and igc...
Andrew
next prev parent reply other threads:[~2024-05-31 13:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 12:53 6.9.3 Hung tasks Genes Lists
2024-05-30 13:36 ` Genes Lists
2024-05-30 14:04 ` Russell King (Oracle)
2024-05-30 16:23 ` Genes Lists
2024-05-31 8:39 ` Hung tasks due to a AB-BA deadlock between the leds_list_lock rwsem and the rtnl mutex (was: 6.9.3 Hung tasks) Linux regression tracking (Thorsten Leemhuis)
2024-05-31 9:50 ` Hung tasks due to a AB-BA deadlock between the leds_list_lock rwsem and the rtnl mutex Hans de Goede
2024-05-31 10:22 ` Hans de Goede
2024-06-01 20:05 ` Hans de Goede
2024-05-31 11:55 ` Genes Lists
2024-05-31 12:54 ` Andrew Lunn
2024-05-31 13:11 ` Hans de Goede
2024-05-31 13:29 ` Andrew Lunn [this message]
2024-05-31 13:36 ` Hans de Goede
2024-06-06 12:01 ` Hans de Goede
2024-06-06 13:12 ` Andrew Lunn
2024-06-06 13:39 ` Jakub Kicinski
2024-06-06 14:25 ` Genes Lists
2024-06-07 10:22 ` Hans de Goede
2024-06-07 11:27 ` Genes Lists
2024-06-07 10:19 ` Hans de Goede
2024-06-24 19:57 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6800715-6bc0-49a0-bd00-5a75b852ea9d@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=johanneswueller@gmail.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lists@sapience.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®