mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Zide" <zide.chen@intel.com>
To: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>,
	Jim Mattson <jmattson@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mingwei Zhang <mizhang@google.com>,
	Das Sandipan <Sandipan.Das@amd.com>,
	Shukla Manali <Manali.Shukla@amd.com>,
	Falcon Thomas <thomas.falcon@intel.com>,
	Xudong Hao <xudong.hao@intel.com>
Subject: Re: [PATCH v6 8/8] KVM: selftests: Add PERF_METRICS and fixed counter 3 tests
Date: Fri, 10 Jul 2026 09:52:41 -0500	[thread overview]
Message-ID: <75a229a6-66b8-4127-b97a-b3861a6528de@intel.com> (raw)
In-Reply-To: <5760cb18-739c-4907-b582-60933d11a72d@linux.intel.com>



On 7/10/2026 3:08 AM, Mi, Dapeng wrote:
> 
> On 7/9/2026 8:35 PM, Jim Mattson wrote:
>> On Mon, Jun 29, 2026 at 7:36 PM Mi, Dapeng <dapeng1.mi@linux.intel.com> wrote:
>>>
>>> On 6/30/2026 7:19 AM, Zide Chen wrote:
>>>> Add a test case to exercise IA32_PERF_METRICS, i.e. architectural
>>>> support for Topdown (TMA) Level 1 metrics, enumerated by
>>>> IA32_PERF_CAPABILITIES[15].
>>>>
>>>> Only check for non-zero metrics, as they are derived and depend on
>>>> the workload, CPU model, and host scheduling, making precise
>>>> expectations fragile.
>>>>
>>>> Extend the PMU selftest to cover Intel fixed counter 3 by bumping
>>>> MAX_NR_FIXED_COUNTERS to 4 and validating basic functionality.
>>>>
>>>> Signed-off-by: Zide Chen <zide.chen@intel.com>
>>>> ---
>>>> ...
>>>> +static void __guest_test_perf_metrics(void)
>>>> +{
>>>> +     int retiring, bad_spec, fe_bound, be_bound, sum;
>>>> +     u64 global_ctrl, metrics;
>>>> +
>>>> +     if ((guest_get_pmu_version() < 2) ||    /* Does guest have GLOBAL_CTRL? */
>>>> +         !this_cpu_has(X86_FEATURE_PDCM) ||
>>>> +         !(rdmsr(MSR_IA32_PERF_CAPABILITIES) & PERF_CAP_PERF_METRICS))
>>>> +             return;
>>>> +
>>>> +     wrmsr(MSR_CORE_PERF_GLOBAL_CTRL, 0);
>>>> +     wrmsr(MSR_CORE_PERF_FIXED_CTR3, 0);
>>>> +     wrmsr(MSR_PERF_METRICS, 0);
>>>> +
>>>> +     /* Enable fixed ctr3 (TOPDOWN.SLOTS) and PERF_METRICS. */
>>>> +     wrmsr(MSR_CORE_PERF_FIXED_CTR_CTRL, FIXED_PMC_CTRL(3, FIXED_PMC_KERNEL));
>>>> +     global_ctrl = FIXED_PMC_GLOBAL_CTRL_ENABLE(3) |
>>>> +                   PERF_METRICS_GLOBAL_CTRL_ENABLE;
>>>> +
>>>> +     GUEST_RUN_PAYLOAD(MSR_CORE_PERF_GLOBAL_CTRL, global_ctrl, "");
>>>> +
>>>> +     /* Check test results. */
>>>> +     metrics = rdmsr(MSR_PERF_METRICS);
>>> Could we use rdpmc instead of rdmsr here? rdpmc is a preferred way to read
>>> counter value.
>> This is in-guest code, so the unintercepted RDMSR will be much faster
>> than the emulated RDPMC.
>>
>> Should we rethink that preference, or add hardware support for
>> selective RDPMC intercepts?
> 
> Hmm, in current most cases, rdpmc and rdmsr should share consistent
> interception configuration for PERF_METRICS except host and guest have
> different counters bitmap.
> 
> Considering this is a test case, the test coverage should be more important
> than the performance, there should be at least a place to call rdpmc
> against the PERF_METRICS, otherwise, that path won't be validated. 

How about keeping rdmsr() in __guest_test_perf_metrics(), and using
RDPMC in the sanity test?

@@ -369,7 +371,7 @@ static void __guest_test_perf_metrics(void)
        GUEST_ASSERT_EQ(rdmsr(MSR_PERF_METRICS), metrics);
        wrmsr(MSR_PERF_METRICS, 0xdeaddead);

-       GUEST_ASSERT_EQ(rdmsr(MSR_PERF_METRICS), 0xdeaddead);
+       guest_test_rdpmc(INTEL_RDPMC_METRICS, true, 0xdeaddead);
 }

> 


  reply	other threads:[~2026-07-10 14:52 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 23:19 [PATCH V6 0/8] KVM: x86/pmu: Add hardware Topdown metrics support Zide Chen
2026-06-29 23:19 ` [PATCH v6 1/8] KVM: x86/pmu: Do not map fixed counters >= 3 to generic perf events Zide Chen
2026-06-30  2:13   ` Mi, Dapeng
2026-07-22 21:51   ` Jim Mattson
2026-06-29 23:19 ` [PATCH v6 2/8] KVM: x86/pmu: Support Intel fixed counter 3 on mediated vPMU Zide Chen
2026-06-30  2:16   ` Mi, Dapeng
2026-07-22 22:17   ` Jim Mattson
2026-07-23 15:36     ` Chen, Zide
2026-07-23 19:19       ` Jim Mattson
2026-06-29 23:19 ` [PATCH v6 3/8] KVM: x86/pmu: Rename and move vcpu_get_perf_capabilities() to pmu.h Zide Chen
2026-06-30  2:18   ` Mi, Dapeng
2026-07-22 22:47   ` Jim Mattson
2026-06-29 23:19 ` [PATCH v6 4/8] KVM: x86/pmu: Snapshot host IA32_PERF_CAPABILITIES in kvm_host Zide Chen
2026-06-30  2:19   ` Mi, Dapeng
2026-07-22 22:58   ` Jim Mattson
2026-06-29 23:19 ` [PATCH v6 5/8] KVM: x86/pmu: Support PERF_METRICS MSR in mediated vPMU Zide Chen
2026-06-30  2:20   ` Mi, Dapeng
2026-07-22 23:05   ` Jim Mattson
2026-07-23 16:30   ` Chen, Zide
2026-07-23 17:59   ` Jim Mattson
2026-07-23 23:44     ` Chen, Zide
2026-07-24  3:15       ` Jim Mattson
2026-07-24 20:47         ` Chen, Zide
2026-07-24 21:37           ` Jim Mattson
2026-07-24 22:59             ` Chen, Zide
2026-07-26 15:49   ` Jim Mattson
2026-07-27 15:34     ` Chen, Zide
2026-06-29 23:19 ` [PATCH v6 6/8] KVM: x86/pmu: Move RDPMC emulation into per-vendor callbacks Zide Chen
2026-06-30  2:23   ` Mi, Dapeng
2026-07-22 23:19   ` Jim Mattson
2026-06-29 23:19 ` [PATCH v6 7/8] KVM: x86/pmu: Emulate RDPMC on performance metrics Zide Chen
2026-06-30  2:23   ` Mi, Dapeng
2026-07-23  0:02   ` Jim Mattson
2026-07-23  1:44     ` Mi, Dapeng
2026-07-23  2:25       ` Jim Mattson
2026-07-23  2:52         ` Mi, Dapeng
2026-07-23  3:10           ` Jim Mattson
2026-07-23  5:47             ` Mi, Dapeng
2026-07-23 16:33             ` Chen, Zide
2026-07-23 19:08             ` Chen, Zide
2026-06-29 23:19 ` [PATCH v6 8/8] KVM: selftests: Add PERF_METRICS and fixed counter 3 tests Zide Chen
2026-06-30  2:36   ` Mi, Dapeng
2026-07-09 12:35     ` Jim Mattson
2026-07-10  8:08       ` Mi, Dapeng
2026-07-10 14:52         ` Chen, Zide [this message]
2026-07-13  6:57           ` Mi, Dapeng
2026-07-10 15:22         ` Jim Mattson
2026-07-13  7:11           ` Mi, Dapeng
2026-07-14  5:11             ` Jim Mattson
2026-07-14  5:28               ` Mi, Dapeng
2026-07-14 17:06                 ` Jim Mattson
2026-07-21 19:17                   ` Chen, Zide
2026-07-21 19:48                     ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a229a6-66b8-4127-b97a-b3861a6528de@intel.com \
    --to=zide.chen@intel.com \
    --cc=Manali.Shukla@amd.com \
    --cc=Sandipan.Das@amd.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mizhang@google.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=thomas.falcon@intel.com \
    --cc=xudong.hao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®