help for driver porting - missing member preset_chandef in struct wireless_dev

help for driver porting - missing member preset_chandef in struct wireless_dev

[Frank Wunderlich]

hi,

i'm working on porting an old/huge wireless driver (mt6625l) [2] to linux 6.0 [1]

i hang on missing member preset_chandef in struct wireless_dev

	struct wireless_dev *wdev = dev->ieee80211_ptr;
	struct cfg80211_chan_def *chandef = &wdev->preset_chandef;

it looks like this member is moved from the wdev into some mesh structure...my driver does not support mesh. any chance to fix this?

i looked through the commit which drops the member from the wireless_dev struct [3], but have no clue how i can adapt the changes in my driver

can anybody help me with this?

Thanks

regards Frank

[1] https://github.com/frank-w/BPI-R2-4.14/commits/6.0-rc
[2] https://github.com/frank-w/BPI-R2-4.14/blob/6.0-rc/drivers/misc/mediatek/connectivity/wlan/gen2/os/linux/gl_p2p_cfg80211.c#L582
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7b0a0e3c3a88260b6fcb017e49f198463aa62ed1

Re: help for driver porting - missing member preset_chandef in struct wireless_dev

[Johannes Berg]

On Mon, 2022-08-22 at 16:04 +0200, Frank Wunderlich wrote:
> hi,
> 
> i'm working on porting an old/huge wireless driver (mt6625l) [2] to linux 6.0 [1]
> 
> i hang on missing member preset_chandef in struct wireless_dev
> 
> 	struct wireless_dev *wdev = dev->ieee80211_ptr;
> 	struct cfg80211_chan_def *chandef = &wdev->preset_chandef;
> 
> it looks like this member is moved from the wdev into some mesh structure...my driver does not support mesh. any chance to fix this?
> 

Yes. Make sure the driver doesn't access it, it should get stuff through
other APIs.

johannes

Aw: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

[Frank Wunderlich]

> Gesendet: Montag, 22. August 2022 um 17:02 Uhr
> Von: "Johannes Berg" <johannes@sipsolutions.net>

> Yes. Make sure the driver doesn't access it, it should get stuff through
> other APIs.

thanks for response, commented out the use of the member and the wdev assignment as it was then unused
can you tell me which api-call this should be?
i just want to make sure this is really done as i up-ported the driver from 4.9, so if the api-call was introduced later it is maybe missing.

> johannes

regards Frank

Re: Aw: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

[Johannes Berg]

On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 17:02 Uhr
> > Von: "Johannes Berg" <johannes@sipsolutions.net>
> 
> > Yes. Make sure the driver doesn't access it, it should get stuff
> > through
> > other APIs.
> 
> thanks for response, commented out the use of the member and the wdev
> assignment as it was then unused
> can you tell me which api-call this should be?
> i just want to make sure this is really done as i up-ported the driver
> from 4.9, so if the api-call was introduced later it is maybe missing.

No sorry, I don't know how the driver was/is using it, so I can't tell
you how to replace it.

johannes

Aw: Re: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

[Frank Wunderlich]

> Gesendet: Montag, 22. August 2022 um 18:43 Uhr
> Von: "Johannes Berg" <johannes@sipsolutions.net>

> On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:

> > thanks for response, commented out the use of the member and the wdev
> > assignment as it was then unused
> > can you tell me which api-call this should be?
> > i just want to make sure this is really done as i up-ported the driver
> > from 4.9, so if the api-call was introduced later it is maybe missing.
>
> No sorry, I don't know how the driver was/is using it, so I can't tell
> you how to replace it.

can you give me possible calls (if there are multiple candidates) which may set the channel (without mesh)
for me to check or maybe implement?

> johannes

Frank

Re: Aw: Re: Re: help for driver porting - missing member preset_chandef in struct wireless_dev

[Johannes Berg]

On Mon, 2022-08-22 at 18:59 +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 22. August 2022 um 18:43 Uhr
> > Von: "Johannes Berg" <johannes@sipsolutions.net>
> 
> > On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote:
> 
> > > thanks for response, commented out the use of the member and the
> > > wdev
> > > assignment as it was then unused
> > > can you tell me which api-call this should be?
> > > i just want to make sure this is really done as i up-ported the
> > > driver
> > > from 4.9, so if the api-call was introduced later it is maybe
> > > missing.
> > 
> > No sorry, I don't know how the driver was/is using it, so I can't
> > tell
> > you how to replace it.
> 
> can you give me possible calls (if there are multiple candidates)
> which may set the channel (without mesh)
> for me to check or maybe implement?

Well it seems to access it inside the start_ap callback, so it should
just check the configuration instea