From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>,
Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com,
dmitry.baryshkov@oss.qualcomm.com
Cc: prasad.sodagudi@oss.qualcomm.com,
mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com,
aniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v2 1/4] spi: geni-qcom: Improve target mode allocation by using proper allocation functions
Date: Wed, 4 Feb 2026 17:38:36 +0100 [thread overview]
Message-ID: <8119913b-c7bf-4de3-b731-dec128e65a7d@oss.qualcomm.com> (raw)
In-Reply-To: <20260204162854.1206323-2-praveen.talari@oss.qualcomm.com>
On 2/4/26 5:28 PM, Praveen Talari wrote:
> The current implementation always allocates a host controller and sets the
> target flag later when the "spi-slave" device tree property is present.
> This approach is suboptimal as it doesn't utilize the dedicated allocation
> functions designed for target mode.
>
> Use devm_spi_alloc_target() when "spi-slave" device tree property is
> present, otherwise use devm_spi_alloc_host(). This replaces the previous
> approach of always allocating a host controller and setting target flag
> later.
>
> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-02-04 16:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 16:28 [PATCH v2 0/4] Improve SPI target mode support and error handling Praveen Talari
2026-02-04 16:28 ` [PATCH v2 1/4] spi: geni-qcom: Improve target mode allocation by using proper allocation functions Praveen Talari
2026-02-04 16:38 ` Konrad Dybcio [this message]
2026-02-04 16:28 ` [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for serial engine errors Praveen Talari
2026-02-04 17:02 ` Konrad Dybcio
2026-02-04 16:28 ` [PATCH v2 3/4] spi: qcom-geni: Drop unused msg parameter from timeout handlers Praveen Talari
2026-02-04 16:38 ` Konrad Dybcio
2026-02-04 16:28 ` [PATCH v2 4/4] spi: geni-qcom: Add target abort support Praveen Talari
2026-02-04 16:41 ` Konrad Dybcio
2026-02-04 16:57 ` Mark Brown
2026-02-04 17:01 ` Konrad Dybcio
2026-02-04 22:12 ` [PATCH v2 0/4] Improve SPI target mode support and error handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8119913b-c7bf-4de3-b731-dec128e65a7d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=aniket.randive@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=prasad.sodagudi@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=quic_vtanuku@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®