From: Mark Brown <broonie@kernel.org>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Praveen Talari <praveen.talari@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com,
dmitry.baryshkov@oss.qualcomm.com,
prasad.sodagudi@oss.qualcomm.com,
mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com,
aniket.randive@oss.qualcomm.com,
chandana.chiluveru@oss.qualcomm.com,
jyothi.seerapu@oss.qualcomm.com
Subject: Re: [PATCH v2 4/4] spi: geni-qcom: Add target abort support
Date: Wed, 4 Feb 2026 16:57:47 +0000 [thread overview]
Message-ID: <d8415a8f-81f2-4f14-bc2b-23f90879efaa@sirena.org.uk> (raw)
In-Reply-To: <68908c06-390e-4717-bab2-708de7f5cec4@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Wed, Feb 04, 2026 at 05:41:46PM +0100, Konrad Dybcio wrote:
> On 2/4/26 5:28 PM, Praveen Talari wrote:
> > + if (spi->target)
> > + spi->target_abort = spi_geni_target_abort;
> The same check is made in core:
> spi_target_abort()
> -> spi_controller_is_target()
> So I'm assuming the intention was to allow assigning the func pointer
> indiscriminately. Other drivers seem to do it both ways.
> Mark, any specific preference?
Not really TBH, it's redundant in the driver but if the people working
on the driver find having the check there saves them having to check
that the core does the right thing that's fine. It's not like this is a
fast path.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-02-04 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 16:28 [PATCH v2 0/4] Improve SPI target mode support and error handling Praveen Talari
2026-02-04 16:28 ` [PATCH v2 1/4] spi: geni-qcom: Improve target mode allocation by using proper allocation functions Praveen Talari
2026-02-04 16:38 ` Konrad Dybcio
2026-02-04 16:28 ` [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for serial engine errors Praveen Talari
2026-02-04 17:02 ` Konrad Dybcio
2026-02-04 16:28 ` [PATCH v2 3/4] spi: qcom-geni: Drop unused msg parameter from timeout handlers Praveen Talari
2026-02-04 16:38 ` Konrad Dybcio
2026-02-04 16:28 ` [PATCH v2 4/4] spi: geni-qcom: Add target abort support Praveen Talari
2026-02-04 16:41 ` Konrad Dybcio
2026-02-04 16:57 ` Mark Brown [this message]
2026-02-04 17:01 ` Konrad Dybcio
2026-02-04 22:12 ` [PATCH v2 0/4] Improve SPI target mode support and error handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8415a8f-81f2-4f14-bc2b-23f90879efaa@sirena.org.uk \
--to=broonie@kernel.org \
--cc=aniket.randive@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=chandana.chiluveru@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jyothi.seerapu@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=prasad.sodagudi@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=quic_vtanuku@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®