From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
axboe@kernel.dk, akpm@linux-foundation.org, ming.lei@redhat.com,
yang.yang@vivo.com, osandov@fb.com, paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth
Date: Thu, 19 Dec 2024 11:25:25 -0800 [thread overview]
Message-ID: <818ca8e9-d691-421f-9b66-f13c76f523f3@acm.org> (raw)
In-Reply-To: <ff6b1360-2cc8-d700-df88-130fa15de1c7@huaweicloud.com>
On 12/18/24 5:21 PM, Yu Kuai wrote:
> Hi,
>
> 在 2024/12/19 2:00, Bart Van Assche 写道:
>> On 12/17/24 5:14 PM, Yu Kuai wrote:
>>> I can't make this read-write, because set lower value will cause
>>> problems for existing elevator, because wake_batch has to be
>>> updated as well.
>>
>> Should the request queue perhaps be frozen before wake_batch is updated?
>
> Yes, we should. The good thing is for now it's frozen already:
> - update nr_requests context;
> - switch elevator;
>
> However, if you mean do this while writing async_depth, freeze queue
> is not enough, we have to ping all the hctx as well by q->sysfs_lock,
> which is not possible.
>
> Or if you mean do this while write the new min_async_depth, then we have
> to update wat_batch for all the queues in the system, too crazy for
> me...
Should min_async_depth perhaps be a request queue attribute instead of
an mq-deadline I/O scheduler attribute?
Thanks,
Bart.
next prev parent reply other threads:[~2024-12-19 19:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 2:40 [PATCH RFC v2 0/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17 2:40 ` [PATCH RFC v2 1/4] block/mq-deadline: Revert "block/mq-deadline: Fix the tag reservation code" Yu Kuai
2024-12-17 21:39 ` Bart Van Assche
2024-12-18 1:16 ` Yu Kuai
2024-12-17 2:40 ` [PATCH v2 RFC 2/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17 21:47 ` Bart Van Assche
2024-12-18 1:18 ` Yu Kuai
2024-12-17 2:40 ` [PATCH v2 3/4] block/elevator: choose none elevator for high IO concurrency ability disk Yu Kuai
2024-12-17 21:50 ` Bart Van Assche
2024-12-18 1:28 ` Yu Kuai
2024-12-17 2:40 ` [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth Yu Kuai
2024-12-17 22:13 ` Bart Van Assche
2024-12-18 1:12 ` Yu Kuai
2024-12-18 1:14 ` Yu Kuai
2024-12-18 18:00 ` Bart Van Assche
2024-12-19 1:21 ` Yu Kuai
2024-12-19 19:25 ` Bart Van Assche [this message]
2024-12-20 6:08 ` Yu Kuai
2024-12-18 18:06 ` Bart Van Assche
2024-12-19 1:54 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=818ca8e9-d691-421f-9b66-f13c76f523f3@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=paolo.valente@linaro.org \
--cc=yang.yang@vivo.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®