mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	axboe@kernel.dk, akpm@linux-foundation.org, ming.lei@redhat.com,
	yang.yang@vivo.com, osandov@fb.com, paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth
Date: Tue, 17 Dec 2024 14:13:06 -0800	[thread overview]
Message-ID: <da924dc3-a2e5-4bfe-afb6-5fbc55bc25a3@acm.org> (raw)
In-Reply-To: <20241217024047.1091893-5-yukuai1@huaweicloud.com>

On 12/16/24 6:40 PM, Yu Kuai wrote:
> +static unsigned int min_async_depth = 64;
> +module_param(min_async_depth, int, 0444);
> +MODULE_PARM_DESC(min_async_depth, "The minimal number of tags available for asynchronous requests");

Users may not like it that this parameter is read-only.

> @@ -513,9 +523,12 @@ static void dd_depth_updated(struct blk_mq_hw_ctx *hctx)
>   	struct deadline_data *dd = q->elevator->elevator_data;
>   	struct blk_mq_tags *tags = hctx->sched_tags;
>   
> -	dd->async_depth = max(1UL, 3 * q->nr_requests / 4);

Shouldn't this assignment be retained instead of removing it? 
Additionally, some time ago a user requested to initialize 
dd->async_depth to q->nr_requests instead of 3/4 of that value because
the lower value introduced a performance regression.

Thanks,

Bart.


  reply	other threads:[~2024-12-17 22:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  2:40 [PATCH RFC v2 0/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17  2:40 ` [PATCH RFC v2 1/4] block/mq-deadline: Revert "block/mq-deadline: Fix the tag reservation code" Yu Kuai
2024-12-17 21:39   ` Bart Van Assche
2024-12-18  1:16     ` Yu Kuai
2024-12-17  2:40 ` [PATCH v2 RFC 2/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17 21:47   ` Bart Van Assche
2024-12-18  1:18     ` Yu Kuai
2024-12-17  2:40 ` [PATCH v2 3/4] block/elevator: choose none elevator for high IO concurrency ability disk Yu Kuai
2024-12-17 21:50   ` Bart Van Assche
2024-12-18  1:28     ` Yu Kuai
2024-12-17  2:40 ` [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth Yu Kuai
2024-12-17 22:13   ` Bart Van Assche [this message]
2024-12-18  1:12     ` Yu Kuai
2024-12-18  1:14       ` Yu Kuai
2024-12-18 18:00         ` Bart Van Assche
2024-12-19  1:21           ` Yu Kuai
2024-12-19 19:25             ` Bart Van Assche
2024-12-20  6:08               ` Yu Kuai
2024-12-18 18:06       ` Bart Van Assche
2024-12-19  1:54         ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da924dc3-a2e5-4bfe-afb6-5fbc55bc25a3@acm.org \
    --to=bvanassche@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=osandov@fb.com \
    --cc=paolo.valente@linaro.org \
    --cc=yang.yang@vivo.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®