mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
	axboe@kernel.dk, akpm@linux-foundation.org, ming.lei@redhat.com,
	yang.yang@vivo.com, osandov@fb.com, paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth
Date: Wed, 18 Dec 2024 10:06:53 -0800	[thread overview]
Message-ID: <95d352cd-b52f-4cc8-9014-302763f401aa@acm.org> (raw)
In-Reply-To: <8fa8c620-22ff-0963-d1ee-c6fe6f13b49c@huaweicloud.com>

On 12/17/24 5:12 PM, Yu Kuai wrote:
> dd->async_depth is initialized to 0 now, functionally I think
> it's the same as q->nr_requests. And I do explain this in commit
> message, maybe it's not clear?

It would be good to add a comment in the source code that explains that
__blk_mq_get_tag() does not restrict tag allocation if dd->async_depth
is zero because that causes data->shallow_depth to be zero.

Thanks,

Bart.

  parent reply	other threads:[~2024-12-18 18:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-17  2:40 [PATCH RFC v2 0/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17  2:40 ` [PATCH RFC v2 1/4] block/mq-deadline: Revert "block/mq-deadline: Fix the tag reservation code" Yu Kuai
2024-12-17 21:39   ` Bart Van Assche
2024-12-18  1:16     ` Yu Kuai
2024-12-17  2:40 ` [PATCH v2 RFC 2/4] lib/sbitmap: fix shallow_depth tag allocation Yu Kuai
2024-12-17 21:47   ` Bart Van Assche
2024-12-18  1:18     ` Yu Kuai
2024-12-17  2:40 ` [PATCH v2 3/4] block/elevator: choose none elevator for high IO concurrency ability disk Yu Kuai
2024-12-17 21:50   ` Bart Van Assche
2024-12-18  1:28     ` Yu Kuai
2024-12-17  2:40 ` [PATCH RFC v2 4/4] block/mq-deadline: introduce min_async_depth Yu Kuai
2024-12-17 22:13   ` Bart Van Assche
2024-12-18  1:12     ` Yu Kuai
2024-12-18  1:14       ` Yu Kuai
2024-12-18 18:00         ` Bart Van Assche
2024-12-19  1:21           ` Yu Kuai
2024-12-19 19:25             ` Bart Van Assche
2024-12-20  6:08               ` Yu Kuai
2024-12-18 18:06       ` Bart Van Assche [this message]
2024-12-19  1:54         ` Yu Kuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95d352cd-b52f-4cc8-9014-302763f401aa@acm.org \
    --to=bvanassche@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=osandov@fb.com \
    --cc=paolo.valente@linaro.org \
    --cc=yang.yang@vivo.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®