Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

["André Apitzsch" <git@apitzsch.eu>]

Hi,

Am Dienstag, dem 10.12.2024 um 12:34 +0000 schrieb Sakari Ailus:
> On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado
> wrote:
> > > > +               state =
> > > > v4l2_subdev_get_locked_active_state(&imx214->sd);
> > > 
> > > Sakari, I see that other drivers assume that the active is locked
> > > in
> > > set_ctrl. Is this correct?
> > 
> > imx214->sd.state_lock = imx214->ctrls.lock;
> > 
> > So I guess it is fine :)
> 
> Yes, it is.
> 
> Please also run this on the set:
> 
> $ ./scripts/checkpatch.pl --strict --max-line-length=80
> 

there are a few lines that exceed 80 columns:

WARNING: line length of 85 exceeds 80 columns
#163: FILE: drivers/media/i2c/imx214.c:576:
+	imx214_update_pad_format(imx214, mode, &format->format, format->format.code);
--
WARNING: line length of 81 exceeds 80 columns
#88: FILE: drivers/media/i2c/imx214.c:983:
+		return dev_err_probe(dev, ret, "failed to set xclk frequency\n");
--
WARNING: line length of 82 exceeds 80 columns
#138: FILE: drivers/media/i2c/imx214.c:1039:
+		dev_err_probe(dev, ret, "failed to register sensor sub-device\n");
--
WARNING: line length of 86 exceeds 80 columns
#491: FILE: drivers/media/i2c/imx214.c:359:
+	{ IMX214_REG_EXCK_FREQ, IMX214_EXCK_FREQ(IMX214_DEFAULT_CLK_FREQ / 1000000) },
--
WARNING: line length of 83 exceeds 80 columns
#177: FILE: drivers/media/i2c/imx214.c:730:
+		exposure_max = format->height + ctrl->val - IMX214_EXPOSURE_OFFSET;
--
WARNING: line length of 85 exceeds 80 columns
#85: FILE: drivers/media/i2c/imx214.c:1231:
+		if (bus_cfg.link_frequencies[i] == IMX214_DEFAULT_LINK_FREQ_LEGACY) {


Is the strict 80 columns limit really necessary, as it would decrease
readability?

Best regards,
André