From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Ricardo Ribalda Delgado <ribalda@kernel.org>
Cc: git@apitzsch.eu, Mauro Carvalho Chehab <mchehab@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Vincent Knecht <vincent.knecht@mailoo.org>
Subject: Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls
Date: Tue, 10 Dec 2024 12:34:49 +0000 [thread overview]
Message-ID: <Z1g1afPM1RRwD_EH@kekkonen.localdomain> (raw)
In-Reply-To: <CAPybu_0Nk+p1rikH_t_zpEHx=KGnXfG+npr-XEnwtA4EnfJjuQ@mail.gmail.com>
On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado wrote:
> > > + state = v4l2_subdev_get_locked_active_state(&imx214->sd);
> >
> > Sakari, I see that other drivers assume that the active is locked in
> > set_ctrl. Is this correct?
>
> imx214->sd.state_lock = imx214->ctrls.lock;
>
> So I guess it is fine :)
Yes, it is.
Please also run this on the set:
$ ./scripts/checkpatch.pl --strict --max-line-length=80
--
Sakari Ailus
next prev parent reply other threads:[~2024-12-10 12:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 20:47 [PATCH v3 00/12] media: i2c: imx214: Miscellaneous cleanups and improvements André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 01/12] media: i2c: imx214: Use subdev active state André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 02/12] media: i2c: imx214: Simplify with dev_err_probe() André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 03/12] media: i2c: imx214: Convert to CCI register access helpers André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 04/12] media: i2c: imx214: Replace register addresses with macros André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 05/12] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 06/12] media: i2c: imx214: Check number of lanes from device tree André Apitzsch via B4 Relay
2024-12-08 21:07 ` Ricardo Ribalda Delgado
2024-12-10 12:35 ` Sakari Ailus
2024-12-07 20:47 ` [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls André Apitzsch via B4 Relay
2024-12-08 20:59 ` Ricardo Ribalda Delgado
2024-12-08 21:19 ` Ricardo Ribalda Delgado
2024-12-10 12:34 ` Sakari Ailus [this message]
2024-12-14 22:45 ` André Apitzsch
2024-12-15 12:10 ` Sakari Ailus
2024-12-08 21:35 ` André Apitzsch
2024-12-08 21:47 ` Ricardo Ribalda Delgado
2024-12-15 22:35 ` André Apitzsch
2024-12-16 13:00 ` Ricardo Ribalda Delgado
2024-12-17 7:17 ` Sakari Ailus
2024-12-07 20:47 ` [PATCH v3 08/12] media: i2c: imx214: Implement vflip/hflip controls André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 09/12] media: i2c: imx214: Add analogue/digital gain control André Apitzsch via B4 Relay
2024-12-07 20:47 ` [PATCH v3 10/12] media: i2c: imx214: Verify chip ID André Apitzsch via B4 Relay
2024-12-10 12:40 ` Sakari Ailus
2024-12-07 20:48 ` [PATCH v3 11/12] media: i2c: imx214: Add test pattern control André Apitzsch via B4 Relay
2024-12-07 20:48 ` [PATCH v3 12/12] media: i2c: imx214: Fix link frequency André Apitzsch via B4 Relay
2024-12-08 21:05 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1g1afPM1RRwD_EH@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=git@apitzsch.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=ribalda@kernel.org \
--cc=vincent.knecht@mailoo.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®