* [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
@ 2018-06-26 14:37 Laurentiu Tudor
2018-06-26 14:56 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Laurentiu Tudor @ 2018-06-26 14:37 UTC (permalink / raw)
To: tglx, jason, marc.zyngier, linux-kernel
Cc: Minghuan.Lian, Zhiqiang.Hou, Laurentiu Tudor
Update the effective affinity mask to fix this warning issued by the
generic irq handling code:
"genirq: irq_chip MSI did not update eff. affinity mask of irq x"
Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
---
drivers/irqchip/irq-ls-scfg-msi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
index 1ec3bfe56693..d81d5b016438 100644
--- a/drivers/irqchip/irq-ls-scfg-msi.c
+++ b/drivers/irqchip/irq-ls-scfg-msi.c
@@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
}
cpumask_copy(irq_data->common->affinity, mask);
+ irq_data_update_effective_affinity(irq_data, mask);
return IRQ_SET_MASK_OK;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
2018-06-26 14:37 [PATCH] irqchip/ls-scfg-msi: update effective affinity mask Laurentiu Tudor
@ 2018-06-26 14:56 ` Marc Zyngier
2018-06-26 15:21 ` Laurentiu Tudor
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2018-06-26 14:56 UTC (permalink / raw)
To: Laurentiu Tudor; +Cc: tglx, jason, linux-kernel, Minghuan.Lian, Zhiqiang.Hou
On Tue, 26 Jun 2018 15:37:12 +0100,
Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
>
> Update the effective affinity mask to fix this warning issued by the
> generic irq handling code:
>
> "genirq: irq_chip MSI did not update eff. affinity mask of irq x"
>
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> ---
> drivers/irqchip/irq-ls-scfg-msi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
> index 1ec3bfe56693..d81d5b016438 100644
> --- a/drivers/irqchip/irq-ls-scfg-msi.c
> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
> }
>
> cpumask_copy(irq_data->common->affinity, mask);
> + irq_data_update_effective_affinity(irq_data, mask);
>
> return IRQ_SET_MASK_OK;
> }
It has already been addressed here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=893fbfff976cd069f2e60c3b186dbe3f85504db2
Thanks,
M.
--
Jazz is not dead, it just smell funny.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
2018-06-26 14:56 ` Marc Zyngier
@ 2018-06-26 15:21 ` Laurentiu Tudor
0 siblings, 0 replies; 3+ messages in thread
From: Laurentiu Tudor @ 2018-06-26 15:21 UTC (permalink / raw)
To: Marc Zyngier; +Cc: tglx, jason, linux-kernel, M.h. Lian, Z.q. Hou
Hi Marc,
On 26.06.2018 17:56, Marc Zyngier wrote:
> On Tue, 26 Jun 2018 15:37:12 +0100,
> Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
>>
>> Update the effective affinity mask to fix this warning issued by the
>> generic irq handling code:
>>
>> "genirq: irq_chip MSI did not update eff. affinity mask of irq x"
>>
>> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>> ---
>> drivers/irqchip/irq-ls-scfg-msi.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
>> index 1ec3bfe56693..d81d5b016438 100644
>> --- a/drivers/irqchip/irq-ls-scfg-msi.c
>> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
>> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
>> }
>>
>> cpumask_copy(irq_data->common->affinity, mask);
>> + irq_data_update_effective_affinity(irq_data, mask);
>>
>> return IRQ_SET_MASK_OK;
>> }
>
> It has already been addressed here:
>
Thanks for the obviously much better & complete fix.
Will take care to keep my local repo more up-to-date.
---
Best Regards, Laurentiu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-26 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-26 14:37 [PATCH] irqchip/ls-scfg-msi: update effective affinity mask Laurentiu Tudor
2018-06-26 14:56 ` Marc Zyngier
2018-06-26 15:21 ` Laurentiu Tudor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®