[PATCH] userns: Allow init_user_ns to be used from non-gpl modules

[PATCH] userns: Allow init_user_ns to be used from non-gpl modules

[Nikolay Borisov]

This patch changes the export attributes of the init_user_ns from
GPL-only to any modules. This needed so that non-gpl modules, such as
ZFS, utilize functions like i_(uid|gid)_(read|write).

Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>
---
 kernel/user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/user.c b/kernel/user.c
index b069ccbfb0b0..8bbd4e628b6e 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -60,7 +60,7 @@ struct user_namespace init_user_ns = {
 	__RWSEM_INITIALIZER(init_user_ns.persistent_keyring_register_sem),
 #endif
 };
-EXPORT_SYMBOL_GPL(init_user_ns);
+EXPORT_SYMBOL(init_user_ns);
 
 /*
  * UID task count cache, to get fast user lookup in "alloc_uid"
-- 
2.7.4

Re: [PATCH] userns: Allow init_user_ns to be used from non-gpl modules

[Serge Hallyn]

Quoting Nikolay Borisov (n.borisov.lkml@gmail.com):
> This patch changes the export attributes of the init_user_ns from
> GPL-only to any modules. This needed so that non-gpl modules, such as
> ZFS, utilize functions like i_(uid|gid)_(read|write).
> 
> Signed-off-by: Nikolay Borisov <n.borisov.lkml@gmail.com>

Seems reasonable to me,

Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>

but it seems clear the decision belongs to Eric.

thanks,
-serge

> ---
>  kernel/user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/user.c b/kernel/user.c
> index b069ccbfb0b0..8bbd4e628b6e 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -60,7 +60,7 @@ struct user_namespace init_user_ns = {
>  	__RWSEM_INITIALIZER(init_user_ns.persistent_keyring_register_sem),
>  #endif
>  };
> -EXPORT_SYMBOL_GPL(init_user_ns);
> +EXPORT_SYMBOL(init_user_ns);
>  
>  /*
>   * UID task count cache, to get fast user lookup in "alloc_uid"
> -- 
> 2.7.4
> 

Re: [PATCH] userns: Allow init_user_ns to be used from non-gpl modules

[Eric W. Biederman]

Nikolay Borisov <n.borisov.lkml@gmail.com> writes:

> This patch changes the export attributes of the init_user_ns from
> GPL-only to any modules. This needed so that non-gpl modules, such as
> ZFS, utilize functions like i_(uid|gid)_(read|write).

It is my belief that linux kernel modules are of necessity derivatives
of the linux kernel and as such need to be covered under the GPLv2 or a
compatible license.

As such I will not accept any patches whose purpose is to facilitate a
different understanding of the license of the linux kernel.

Eric