* [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read()
@ 2016-08-25 9:17 SF Markus Elfring
2016-08-25 11:33 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2016-08-25 9:17 UTC (permalink / raw)
To: linux-edac, x86, Borislav Petkov, H. Peter Anvin, Ingo Molnar,
Thomas Gleixner, Tony Luck
Cc: LKML, kernel-janitors, Julia Lawall, Paolo Bonzini
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 25 Aug 2016 11:00:05 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus reuse the corresponding function "kmalloc_array".
This issue was detected by using the Coccinelle software.
* Replace the specification of a data type by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 79d8ec8..0bc831d 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1901,7 +1901,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
unsigned prev, next;
int i, err;
- cpu_tsc = kmalloc(nr_cpu_ids * sizeof(long), GFP_KERNEL);
+ cpu_tsc = kmalloc_array(nr_cpu_ids, sizeof(*cpu_tsc), GFP_KERNEL);
if (!cpu_tsc)
return -ENOMEM;
--
2.9.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read()
2016-08-25 9:17 [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() SF Markus Elfring
@ 2016-08-25 11:33 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-08-25 11:33 UTC (permalink / raw)
To: SF Markus Elfring, linux-edac, x86, Borislav Petkov,
H. Peter Anvin, Ingo Molnar, Thomas Gleixner, Tony Luck
Cc: LKML, kernel-janitors, Julia Lawall
On 25/08/2016 11:17, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 25 Aug 2016 11:00:05 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus reuse the corresponding function "kmalloc_array".
>
> This issue was detected by using the Coccinelle software.
>
> * Replace the specification of a data type by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index 79d8ec8..0bc831d 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -1901,7 +1901,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf,
> unsigned prev, next;
> int i, err;
>
> - cpu_tsc = kmalloc(nr_cpu_ids * sizeof(long), GFP_KERNEL);
> + cpu_tsc = kmalloc_array(nr_cpu_ids, sizeof(*cpu_tsc), GFP_KERNEL);
> if (!cpu_tsc)
> return -ENOMEM;
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
I think you can post the patches with a larger granularity (e.g. one for
all of arch/x86/kernel).
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-25 11:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25 9:17 [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() SF Markus Elfring
2016-08-25 11:33 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®