OSS sound core optionalization has __init/__exit mismatches

OSS sound core optionalization has __init/__exit mismatches

[Mike Frysinger]

this commit:
commit 1be95f401657e75984871c369d774d507e462939
Author: Tejun Heo <tj@kernel.org>
Date:   Thu Aug 28 16:42:51 2008 +0200
sound: make OSS sound core optional

results in this failure:
WARNING: vmlinux.o(.init.text+0xfbf0): Section mismatch in reference
from the function _init_soundcore() to the function
.exit.text:_cleanup_oss_soundcore()
The function __init _init_soundcore() references
a function __exit _cleanup_oss_soundcore().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __exit annotation of
_cleanup_oss_soundcore() so it may be used outside an exit section.

and can easily be seen in sound/sound_core.c:
...
static int __init init_soundcore(void)
{
...
               cleanup_oss_soundcore();
...
}
...
static void __exit cleanup_oss_soundcore(void)
{
...
}
...
-mike

Re: OSS sound core optionalization has __init/__exit mismatches

[Takashi Iwai]

At Fri, 12 Sep 2008 11:22:21 -0400,
Mike Frysinger wrote:
> 
> this commit:
> commit 1be95f401657e75984871c369d774d507e462939
> Author: Tejun Heo <tj@kernel.org>
> Date:   Thu Aug 28 16:42:51 2008 +0200
> sound: make OSS sound core optional
> 
> results in this failure:
> WARNING: vmlinux.o(.init.text+0xfbf0): Section mismatch in reference
> from the function _init_soundcore() to the function
> .exit.text:_cleanup_oss_soundcore()
> The function __init _init_soundcore() references
> a function __exit _cleanup_oss_soundcore().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> _cleanup_oss_soundcore() so it may be used outside an exit section.
> 
> and can easily be seen in sound/sound_core.c:
> ...
> static int __init init_soundcore(void)
> {
> ...
>                cleanup_oss_soundcore();
> ...
> }
> ...
> static void __exit cleanup_oss_soundcore(void)
> {
> ...
> }
> ...
> -mike

Thanks for reporting.  It was already fixed on my sound-2.6.git.


Takashi