From: Yu Kuai <yukuai1@huaweicloud.com>
To: Hannes Reinecke <hare@suse.de>, Yu Kuai <yukuai1@huaweicloud.com>,
hch@infradead.org, jack@suse.cz, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH -next RFC 2/3] block: factor out the setting of GD_NEED_PART_SCAN
Date: Mon, 13 Feb 2023 10:41:32 +0800 [thread overview]
Message-ID: <8eeacd36-6f35-230c-1c93-074c63eee08f@huaweicloud.com> (raw)
In-Reply-To: <9b0b9059-c0f6-df5b-863a-987970f3567d@suse.de>
Hi,
在 2023/02/12 19:36, Hannes Reinecke 写道:
> On 2/12/23 10:26, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> In order to prevent scan partition for a device that is opened
>> exclusively by someone else, new conditions will be added to
>> disk_scan_partitions() in the next patch. Hence if device is opened
>> exclusively between bdev_add() and disk_scan_partitions(), the first
>> partition scan will fail unexpected. This patch factor out the setting
>> of GD_NEED_PART_SCAN to prevent the problem.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>> block/genhd.c | 2 +-
>> block/ioctl.c | 1 +
>> 2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/genhd.c b/block/genhd.c
>> index 075d8da284f5..c0d1220bd798 100644
>> --- a/block/genhd.c
>> +++ b/block/genhd.c
>> @@ -367,7 +367,6 @@ int disk_scan_partitions(struct gendisk *disk,
>> fmode_t mode)
>> if (disk->open_partitions)
>> return -EBUSY;
>> - set_bit(GD_NEED_PART_SCAN, &disk->state);
>> bdev = blkdev_get_by_dev(disk_devt(disk), mode, NULL);
>> if (IS_ERR(bdev))
>> return PTR_ERR(bdev);
>> @@ -493,6 +492,7 @@ int __must_check device_add_disk(struct device
>> *parent, struct gendisk *disk,
>> if (ret)
>> goto out_unregister_bdi;
>> + set_bit(GD_NEED_PART_SCAN, &disk->state);
>> bdev_add(disk->part0, ddev->devt);
>> if (get_capacity(disk))
>> disk_scan_partitions(disk, FMODE_READ);
> Usual caveat:
> What happens if the flag is already set here?
> Wouldn't that imply that another scan is underway?
I think this is not true, currently set the state just means we're going
to scan, and if some checking failed, the state will be left. I don't
have a good idea how to fix this yet...
Thanks,
Kuai
> And wouldn't it be better to use 'test_and_set()'?
>
>
>> diff --git a/block/ioctl.c b/block/ioctl.c
>> index 6dd49d877584..0eefcdb936a0 100644
>> --- a/block/ioctl.c
>> +++ b/block/ioctl.c
>> @@ -528,6 +528,7 @@ static int blkdev_common_ioctl(struct block_device
>> *bdev, fmode_t mode,
>> return -EACCES;
>> if (bdev_is_partition(bdev))
>> return -EINVAL;
>> + set_bit(GD_NEED_PART_SCAN, &bdev->bd_disk->state);
>> return disk_scan_partitions(bdev->bd_disk, mode & ~FMODE_EXCL);
>> case BLKTRACESTART:
>> case BLKTRACESTOP:
> Similar here.
>
> Cheers,
>
> Hannes
next prev parent reply other threads:[~2023-02-13 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 9:26 [PATCH -next RFC 0/3] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-12 9:26 ` [PATCH -next RFC 1/3] block: Revert "block: Do not reread partition table on exclusively open device" Yu Kuai
2023-02-12 9:26 ` [PATCH -next RFC 2/3] block: factor out the setting of GD_NEED_PART_SCAN Yu Kuai
2023-02-12 11:36 ` Hannes Reinecke
2023-02-13 2:41 ` Yu Kuai [this message]
2023-02-16 13:17 ` Jan Kara
2023-02-17 1:44 ` Yu Kuai
2023-02-12 9:26 ` [PATCH -next RFC 3/3] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-16 13:19 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eeacd36-6f35-230c-1c93-074c63eee08f@huaweicloud.com \
--to=yukuai1@huaweicloud.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®