* Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)
@ 2017-02-11 5:08 Denys Fedoryshchenko
2017-02-11 7:54 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Denys Fedoryshchenko @ 2017-02-11 5:08 UTC (permalink / raw)
To: live-patching, linux-kernel
Cc: Josh Poimboeuf, Jessica Yu, Jiri Kosina, Miroslav Benes
Hello,
I noticed that sample of livepatch is not working in 4.9.9, because in
include,
linux/livepatch.h
it is:
#if IS_ENABLED(CONFIG_LIVEPATCH)
while config option is:
CONFIG_HAVE_LIVEPATCH=y
After editing livepatch.h sample module compiles fine
Probably that's just a typo?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Mistake in include IS_ENABLED(CONFIG_LIVEPATCH)
2017-02-11 5:08 Mistake in include IS_ENABLED(CONFIG_LIVEPATCH) Denys Fedoryshchenko
@ 2017-02-11 7:54 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2017-02-11 7:54 UTC (permalink / raw)
To: Denys Fedoryshchenko
Cc: live-patching, linux-kernel, Josh Poimboeuf, Jessica Yu, Miroslav Benes
On Sat, 11 Feb 2017, Denys Fedoryshchenko wrote:
> I noticed that sample of livepatch is not working in 4.9.9, because in
> include,
> linux/livepatch.h
> it is:
> #if IS_ENABLED(CONFIG_LIVEPATCH)
>
> while config option is:
> CONFIG_HAVE_LIVEPATCH=y
>
> After editing livepatch.h sample module compiles fine
>
> Probably that's just a typo?
There are two config variables. CONFIG_HAVE_LIVEPATCH is set by those
architectures for which livepatching implementation exists.
CONFIG_LIVEPATCH is the actual config option turning the support in kernel
on/off.
What you are seeing is that if you have kernel configuration that has
livepatching (CONFIG_LIVEPATCH) turned off, the sample module doesn't
compile for it either. I'd say it's not unexpected behavior.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-11 7:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-11 5:08 Mistake in include IS_ENABLED(CONFIG_LIVEPATCH) Denys Fedoryshchenko
2017-02-11 7:54 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®