* [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
@ 2019-06-26 10:39 Yue Hu
2019-06-26 10:51 ` Gao Xiang
0 siblings, 1 reply; 5+ messages in thread
From: Yue Hu @ 2019-06-26 10:39 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel, huyue2
From: Yue Hu <huyue2@yulong.com>
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
---
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index e51348f..d6e1e16 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
struct erofs_sb_info *sbi = EROFS_I_SB(inode);
const int mode = vi->datamode;
- DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
-
/* should be inode inline C */
if (mode != EROFS_INODE_LAYOUT_INLINE)
return 0;
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
2019-06-26 10:39 [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Yue Hu
@ 2019-06-26 10:51 ` Gao Xiang
0 siblings, 0 replies; 5+ messages in thread
From: Gao Xiang @ 2019-06-26 10:51 UTC (permalink / raw)
To: Yue Hu, yuchao0, gregkh
Cc: linux-erofs, devel, linux-kernel, huyue2, Miao Xie
Hi Yue,
On 2019/6/26 18:39, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
> Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
Bump the patch version in the title as Greg said...
Otherwise, it is hard to differ which patch is the latest patch...
Thanks,
Gao Xiang
> ---
> drivers/staging/erofs/inode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index e51348f..d6e1e16 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
> struct erofs_sb_info *sbi = EROFS_I_SB(inode);
> const int mode = vi->datamode;
>
> - DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
> -
> /* should be inode inline C */
> if (mode != EROFS_INODE_LAYOUT_INLINE)
> return 0;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
@ 2019-06-26 3:28 Yue Hu
2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
0 siblings, 2 replies; 5+ messages in thread
From: Yue Hu @ 2019-06-26 3:28 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel, huyue2
From: Yue Hu <huyue2@yulong.com>
Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
drivers/staging/erofs/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index e51348f..d6e1e16 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
struct erofs_sb_info *sbi = EROFS_I_SB(inode);
const int mode = vi->datamode;
- DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
-
/* should be inode inline C */
if (mode != EROFS_INODE_LAYOUT_INLINE)
return 0;
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
2019-06-26 3:28 Yue Hu
@ 2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
1 sibling, 0 replies; 5+ messages in thread
From: Chao Yu @ 2019-06-26 7:13 UTC (permalink / raw)
To: Yue Hu, gaoxiang25, gregkh; +Cc: linux-erofs, devel, linux-kernel, huyue2
On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
2019-06-26 3:28 Yue Hu
2019-06-26 7:13 ` Chao Yu
@ 2019-06-26 9:02 ` Gao Xiang
1 sibling, 0 replies; 5+ messages in thread
From: Gao Xiang @ 2019-06-26 9:02 UTC (permalink / raw)
To: Yue Hu; +Cc: yuchao0, gregkh, linux-erofs, devel, linux-kernel, huyue2
Hi Yue,
On 2019/6/26 11:28, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Already check if ->datamode is supported in read_inode(), no need to check
> again in the next fill_inline_data() only called by fill_inode().
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
You should add all the 'Reviewed-by' / 'Acked-by' / ... tags from other guyes
to the following versions when you resend your patches.
Thanks,
Gao Xiang
> ---
> drivers/staging/erofs/inode.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index e51348f..d6e1e16 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
> struct erofs_sb_info *sbi = EROFS_I_SB(inode);
> const int mode = vi->datamode;
>
> - DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
> -
> /* should be inode inline C */
> if (mode != EROFS_INODE_LAYOUT_INLINE)
> return 0;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-26 10:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26 10:39 [PATCH RESEND] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Yue Hu
2019-06-26 10:51 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2019-06-26 3:28 Yue Hu
2019-06-26 7:13 ` Chao Yu
2019-06-26 9:02 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®