From: Kyle Moffett <mrmacman_g4@mac.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Greg KH <greg@kroah.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, vserver@list.linux-vserver.org,
Herbert Poetzl <herbert@13thfloor.at>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Dave Hansen <haveblue@us.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
Suleiman Souhlal <ssouhlal@FreeBSD.org>,
Hubertus Franke <frankeh@watson.ibm.com>,
Cedric Le Goater <clg@fr.ibm.com>
Subject: Re: [PATCH 1/5] pid: Implement task references.
Date: Mon, 30 Jan 2006 00:35:14 -0500 [thread overview]
Message-ID: <AB74DF4E-5563-4449-8194-315AA4CCD7FE@mac.com> (raw)
In-Reply-To: <43DDA1E7.5010109@cosmosbay.com>
On Jan 30, 2006, at 00:19, Eric Dumazet wrote:
> - if (atomic_dec_and_test(&kref->refcount)) {
> + /*
> + * if current count is one, we are the last user and can release
> object
> + * right now, avoiding an atomic operation on 'refcount'
> + */
> + if ((atomic_read(&kref->refcount) == 1) ||
Uhh, I think you got this test reversed. Didn't you mean != 1?
Otherwise you only do the dec_and_test when the refcount is one,
which means that you leak everything kref-ed.
> + (atomic_dec_and_test(&kref->refcount))) {
> release(kref);
> return 1;
> }
Cheers,
Kyle Moffett
--
There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies. And the
other way is to make it so complicated that there are no obvious
deficiencies. The first method is far more difficult.
-- C.A.R. Hoare
next prev parent reply other threads:[~2006-01-30 5:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-29 7:19 [RFC][PATCH 0/5] Task references Eric W. Biederman
2006-01-29 7:22 ` [PATCH 1/5] pid: Implement task references Eric W. Biederman
2006-01-29 7:24 ` [PATCH 2/5] pid: Add macros for interating through tasks by type Eric W. Biederman
2006-01-29 7:28 ` [PATCH 3/5] pid: Implement kill_tref Eric W. Biederman
2006-01-29 7:33 ` [PATCH 4/5] vt: Update spawnpid to use a task_ref Eric W. Biederman
2006-01-29 7:35 ` [PATCH 5/5] file: Modify struct fown_struct to contain a tref Eric W. Biederman
2006-01-29 8:43 ` Suleiman Souhlal
2006-01-29 9:18 ` Eric W. Biederman
2006-01-30 10:51 ` [PATCH 4/5] vt: Update spawnpid to use a task_ref Pavel Machek
2006-01-30 20:39 ` Eric W. Biederman
2006-01-30 21:05 ` Pavel Machek
2006-01-30 21:15 ` Eric W. Biederman
2006-01-29 8:46 ` [PATCH 1/5] pid: Implement task references Suleiman Souhlal
2006-01-29 19:05 ` Greg KH
2006-01-29 21:58 ` Eric W. Biederman
2006-01-30 4:51 ` Greg KH
2006-01-30 5:19 ` Eric Dumazet
2006-01-30 5:35 ` Kyle Moffett [this message]
2006-01-30 5:46 ` Eric Dumazet
2006-01-30 6:46 ` Kyle Moffett
2006-01-30 18:43 ` Greg KH
2006-01-30 19:58 ` Eric Dumazet
2006-01-30 20:45 ` Eric W. Biederman
2006-01-30 21:32 ` Eric Dumazet
2006-01-30 21:51 ` Eric W. Biederman
2006-01-30 20:13 ` Eric W. Biederman
2006-01-31 6:58 ` Greg KH
2006-01-31 16:04 ` Eric W. Biederman
2006-01-29 8:05 ` [RFC][PATCH 0/5] Task references Kyle Moffett
2006-02-06 8:09 ` Eric W. Biederman
2006-02-06 14:36 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AB74DF4E-5563-4449-8194-315AA4CCD7FE@mac.com \
--to=mrmacman_g4@mac.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=clg@fr.ibm.com \
--cc=dada1@cosmosbay.com \
--cc=ebiederm@xmission.com \
--cc=frankeh@watson.ibm.com \
--cc=greg@kroah.com \
--cc=haveblue@us.ibm.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=ssouhlal@FreeBSD.org \
--cc=vserver@list.linux-vserver.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®