mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Yury Norov" <yury.norov@gmail.com>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"Dirk Behme" <dirk.behme@de.bosch.com>,
	"Steven Price" <steven.price@arm.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] rust: num: add `into_inner` method to `Bounded`
Date: Thu, 29 Jan 2026 17:05:38 +0900	[thread overview]
Message-ID: <DG0X202UKD4K.13ERXKFN9XU7V@nvidia.com> (raw)
In-Reply-To: <DG0C68O25Y9X.2X8M9OXMW17IS@garyguo.net>

On Thu Jan 29, 2026 at 12:43 AM JST, Gary Guo wrote:
> On Wed Jan 28, 2026 at 2:37 AM GMT, Alexandre Courbot wrote:
>> This is useful to access the inner value in const contexts.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> ---
>>  rust/kernel/num/bounded.rs | 16 ++++++++++++++++
>>  1 file changed, 16 insertions(+)
>>
>> diff --git a/rust/kernel/num/bounded.rs b/rust/kernel/num/bounded.rs
>> index b41ca6df1525..850827033f67 100644
>> --- a/rust/kernel/num/bounded.rs
>> +++ b/rust/kernel/num/bounded.rs
>> @@ -388,6 +388,22 @@ pub fn get(self) -> T {
>>          *self.deref()
>>      }
>>  
>> +    /// Returns the wrapped value as the backing type.
>> +    ///
>> +    /// This is a const-friendly variant of [`Self::get`] that can be used in const contexts.
>> +    ///
>> +    /// # Examples
>> +    ///
>> +    /// ```
>> +    /// use kernel::num::Bounded;
>> +    ///
>> +    /// const V: u32 = Bounded::<u32, 4>::new::<7>().into_inner();
>> +    /// assert_eq!(V, 7u32);
>> +    /// ```
>> +    pub const fn into_inner(self) -> T {
>> +        self.0
>> +    }
>
> This is... just `get`.
>
> You can implement it (with the `fits_with_in` check) in the same manner as the
> const new.

But unfortunately doing so also prevents `get` from being called from
generic code, which is a must-have. Or am I misunderstanding your
suggestion?

  reply	other threads:[~2026-01-29  8:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  2:37 [PATCH v4 0/7] rust: add `register!` macro Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 1/7] rust: enable the `generic_arg_infer` feature Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 2/7] rust: num: add `shr` and `shl` methods to `Bounded` Alexandre Courbot
2026-01-28 15:38   ` Gary Guo
2026-01-28  2:37 ` [PATCH v4 3/7] rust: num: add `as_bool` method to `Bounded<_, 1>` Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 4/7] rust: num: add `into_inner` method to `Bounded` Alexandre Courbot
2026-01-28 15:43   ` Gary Guo
2026-01-29  8:05     ` Alexandre Courbot [this message]
2026-01-29 20:23       ` Gary Guo
2026-01-30  0:58         ` Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 5/7] rust: io: add `register!` macro Alexandre Courbot
2026-01-28  3:02   ` John Hubbard
2026-01-28  3:47     ` Joel Fernandes
2026-01-28  7:42       ` Alexandre Courbot
2026-01-28 17:56         ` Joel Fernandes
2026-01-29 11:59           ` Alexandre Courbot
2026-01-28 16:16   ` Gary Guo
2026-01-29  8:00     ` Alexandre Courbot
2026-01-29 14:10       ` Gary Guo
2026-01-29 21:08         ` Danilo Krummrich
2026-01-30  6:55         ` Alexandre Courbot
2026-01-30 16:14           ` Gary Guo
2026-01-30 16:44             ` Danilo Krummrich
2026-01-30 17:01               ` Gary Guo
2026-01-30 17:18                 ` Danilo Krummrich
2026-01-29 12:48     ` Danilo Krummrich
2026-01-28  2:37 ` [PATCH v4 6/7] sample: rust: pci: use " Alexandre Courbot
2026-01-28 12:35   ` Zhi Wang
2026-01-28 13:27     ` Alexandre Courbot
2026-01-28 15:46       ` Gary Guo
2026-01-29  8:01         ` Alexandre Courbot
2026-01-31  1:06   ` Danilo Krummrich
2026-01-28  2:37 ` [PATCH FOR REFERENCE v4 7/7] gpu: nova-core: use the kernel " Alexandre Courbot
2026-01-28  2:57   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG0X202UKD4K.13ERXKFN9XU7V@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=ecourtney@nvidia.com \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=steven.price@arm.com \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome