Re: [PATCH v4 5/7] rust: io: add `register!` macro

[John Hubbard <jhubbard@nvidia.com>]

On 1/27/26 6:37 PM, Alexandre Courbot wrote:
> Add a macro for defining hardware register types with I/O accessors.
...
> +/// Fields are instances of [`Bounded`](kernel::num::Bounded) and can be read by calling their
> +/// getter method, which is named after them. They also have setter methods prefixed with `set_`
> +/// for runtime values and `with_` for constant values. All setters return the updated register
OK, this still looks like a naming problem that we don't need to create.
Let's just pick either "set_" or "with_" as a prefix (it seems that
"with_" has won out, in the v3 discussion thread), and then add "const",
so that the name doesn't require explanation.

...
> +/// // Update some fields and write the new value back.
> +/// boot0
> +///     // Constant values.
> +///     .with_major_revision::<3>()
> +///     .with_minor_revision::<10>()
> +///     // Run-time value.
> +///     .set_vendor_id(obtain_vendor_id())

See, that is just not obvious at all, why it's different. That's why
you had to write a couple of comments.

.with_const_major_revision(), on the other hand, keeps the pattern
clear and obvious. No comments necessary.

nova-core doesn't even use the const_ settors yet at all, according
to my quick read of the (very helpful) [PATCH FOR REFERENCE v4 7/7].
So clearly it is a bit rare, and the extra characters won't come into
play in daily life.

thanks,
-- 
John Hubbard