mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Sarah Emery" <sarah.emery@canonical.com>
Cc: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Yixun Lan" <dlan@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] riscv: dts: spacemit: k3-com260: Add SPI NOR flash
Date: Sat, 07 Nov 2026 13:19:39 +0000	[thread overview]
Message-ID: <DMP0C29S8OJL.3SBBFOOCLLE1K@linux.spacemit.com> (raw)
In-Reply-To: <DMOZO92UHE9L.2PC9QE72225NX@linux.spacemit.com>

[-- Attachment #1: Type: text/plain, Size: 1620 bytes --]

On Sat, 07 Nov 2026 12:48:33 +0000, Troy Mitchell wrote:
> On Fri, 6 Nov 2026 17:25:48 +0100, Sarah Emery wrote:
> > > +			uboot@210000 {
> > > +				reg = <0x210000 0x5f0000>;
> > > +			};
> >
> > This partition ends at 0x800000. On the CoM260 with EDK2,
> > 0x700000 to 0x7c0000 holds the variable store (NVRAM and FTW), so
> > reflashing this partition from Linux would erase it.
> >
> > I think we could split it like this:
> >
> >     uboot@210000 {
> >        reg = <0x210000 0x4f0000>;
> >     };
> >
> >     var@700000 {
> >        reg = <0x700000 0xc0000>;
> >        read-only;
> >     };
> >
> > What do you think?
>
> The layout here is the one used by the SpacemiT boot firmware for K3,
> where U-Boot owns everything from 0x210000 to the end of the flash.
> The EDK2 that SpacemiT ships for K3 (including the CoM260
> configurations) keeps its variables in memory and does not use the
> flash for them, so it has nothing at 0x700000.
>
> Which EDK2 build places the variable store at 0x700000?
Sorry, I checked an outdated EDK2 tree. The current SpacemiT EDK2 for
K3 does store the variables in flash, in a separate region pinned at
0x700000 with size 0xc0000, and the firmware image itself goes at
0x210000. So you are right, and I'll split the partition the way you
suggested in v2.

> > The Pico-ITX node also uses 0x5f0000, but I think it should be
> > modified to split out the var part too if it makes sense here.
>
> Same answer as above.
For Pico-ITX, the same layout applies, so its DTS should get the same
split in a separate patch.

-- 
Troy Mitchell

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

  reply	other threads:[~2026-11-07 13:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:23 [PATCH 0/5] riscv: dts: spacemit: k3-com260: Describe SD card, SPI NOR and MAC Troy Mitchell
2026-11-05  8:23 ` [PATCH 1/5] riscv: dts: spacemit: k3-com260-ifx: Drop wrong SD card vmmc-supply Troy Mitchell
2026-11-05  8:23 ` [PATCH 2/5] riscv: dts: spacemit: k3-com260: Move SD card to the module Troy Mitchell
2026-11-05  8:23 ` [PATCH 3/5] riscv: dts: spacemit: k3-com260: Add SPI NOR flash Troy Mitchell
2026-11-06 16:25   ` Sarah Emery
2026-11-07 12:48     ` Troy Mitchell
2026-11-07 13:19       ` Troy Mitchell [this message]
2026-11-05  8:23 ` [PATCH 4/5] riscv: defconfig: Enable AT24 EEPROM and ONIE TLV layout Troy Mitchell
2026-11-05 10:42   ` E Shattow
2026-11-05 14:20     ` Troy Mitchell
2026-11-05  8:23 ` [PATCH 5/5] riscv: dts: spacemit: k3-com260: Set Ethernet MAC from EEPROM Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMP0C29S8OJL.3SBBFOOCLLE1K@linux.spacemit.com \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sarah.emery@canonical.com \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®