* [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto
@ 2008-09-11 12:33 Julia Lawall
2008-09-11 13:46 ` Richard Genoud
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2008-09-11 12:33 UTC (permalink / raw)
To: mchehab, v4l-dvb-maintainer, video4linux-list, vigneshbabu,
richard.genoud, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The break after the return or goto serves no purpose.
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/media/common/tuners/mxl5007t.c | 1 -
drivers/media/common/tuners/tda18271-fe.c | 1 -
drivers/media/common/tuners/tda9887.c | 1 -
drivers/media/common/tuners/tuner-simple.c | 1 -
4 files changed, 4 deletions(-)
diff -u -p a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
--- a/drivers/media/common/tuners/tuner-simple.c
+++ b/drivers/media/common/tuners/tuner-simple.c
@@ -1038,7 +1038,6 @@ struct dvb_frontend *simple_tuner_attach
case 0:
mutex_unlock(&tuner_simple_list_mutex);
return NULL;
- break;
case 1:
fe->tuner_priv = priv;
diff -u -p a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c
--- a/drivers/media/common/tuners/tda18271-fe.c
+++ b/drivers/media/common/tuners/tda18271-fe.c
@@ -1155,7 +1155,6 @@ struct dvb_frontend *tda18271_attach(str
switch (instance) {
case 0:
goto fail;
- break;
case 1:
/* new tuner instance */
priv->gate = (cfg) ? cfg->gate : TDA18271_GATE_AUTO;
diff -u -p a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
--- a/drivers/media/common/tuners/mxl5007t.c
+++ b/drivers/media/common/tuners/mxl5007t.c
@@ -979,7 +979,6 @@ struct dvb_frontend *mxl5007t_attach(str
switch (instance) {
case 0:
goto fail;
- break;
case 1:
/* new tuner instance */
state->config = cfg;
diff -u -p a/drivers/media/common/tuners/tda9887.c b/drivers/media/common/tuners/tda9887.c
--- a/drivers/media/common/tuners/tda9887.c
+++ b/drivers/media/common/tuners/tda9887.c
@@ -686,7 +686,6 @@ struct dvb_frontend *tda9887_attach(stru
case 0:
mutex_unlock(&tda9887_list_mutex);
return NULL;
- break;
case 1:
fe->analog_demod_priv = priv;
priv->mode = T_STANDBY;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto
2008-09-11 12:33 [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto Julia Lawall
@ 2008-09-11 13:46 ` Richard Genoud
0 siblings, 0 replies; 2+ messages in thread
From: Richard Genoud @ 2008-09-11 13:46 UTC (permalink / raw)
To: Julia Lawall
Cc: mchehab, v4l-dvb-maintainer, video4linux-list, vigneshbabu,
linux-kernel, kernel-janitors
2008/9/11 Julia Lawall <julia@diku.dk>:
> From: Julia Lawall <julia@diku.dk>
>
> The break after the return or goto serves no purpose.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Reviewed-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/media/common/tuners/mxl5007t.c | 1 -
> drivers/media/common/tuners/tda18271-fe.c | 1 -
> drivers/media/common/tuners/tda9887.c | 1 -
> drivers/media/common/tuners/tuner-simple.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff -u -p a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
> --- a/drivers/media/common/tuners/tuner-simple.c
> +++ b/drivers/media/common/tuners/tuner-simple.c
> @@ -1038,7 +1038,6 @@ struct dvb_frontend *simple_tuner_attach
> case 0:
> mutex_unlock(&tuner_simple_list_mutex);
> return NULL;
> - break;
> case 1:
> fe->tuner_priv = priv;
>
> diff -u -p a/drivers/media/common/tuners/tda18271-fe.c b/drivers/media/common/tuners/tda18271-fe.c
> --- a/drivers/media/common/tuners/tda18271-fe.c
> +++ b/drivers/media/common/tuners/tda18271-fe.c
> @@ -1155,7 +1155,6 @@ struct dvb_frontend *tda18271_attach(str
> switch (instance) {
> case 0:
> goto fail;
> - break;
> case 1:
> /* new tuner instance */
> priv->gate = (cfg) ? cfg->gate : TDA18271_GATE_AUTO;
> diff -u -p a/drivers/media/common/tuners/mxl5007t.c b/drivers/media/common/tuners/mxl5007t.c
> --- a/drivers/media/common/tuners/mxl5007t.c
> +++ b/drivers/media/common/tuners/mxl5007t.c
> @@ -979,7 +979,6 @@ struct dvb_frontend *mxl5007t_attach(str
> switch (instance) {
> case 0:
> goto fail;
> - break;
> case 1:
> /* new tuner instance */
> state->config = cfg;
> diff -u -p a/drivers/media/common/tuners/tda9887.c b/drivers/media/common/tuners/tda9887.c
> --- a/drivers/media/common/tuners/tda9887.c
> +++ b/drivers/media/common/tuners/tda9887.c
> @@ -686,7 +686,6 @@ struct dvb_frontend *tda9887_attach(stru
> case 0:
> mutex_unlock(&tda9887_list_mutex);
> return NULL;
> - break;
> case 1:
> fe->analog_demod_priv = priv;
> priv->mode = T_STANDBY;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-11 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-11 12:33 [PATCH 2/5] drivers/media/common/tuners: Drop code after return or goto Julia Lawall
2008-09-11 13:46 ` Richard Genoud
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®