From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rahul Tanwar <rtanwar@maxlinear.com>
Cc: bigeasy@linutronix.de, robh@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com,
dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
linux-lgm-soc@maxlinear.com
Subject: Re: [PATCH v3 3/4] x86/of: Replace printk(KERN_LVL) with pr_lvl()
Date: Tue, 22 Nov 2022 11:14:47 +0200 [thread overview]
Message-ID: <Y3yTB7mGOPm3rFfb@smile.fi.intel.com> (raw)
In-Reply-To: <64a905649accf1b68f03c31a9b6ce205b03c6703.1669100394.git.rtanwar@maxlinear.com>
On Tue, Nov 22, 2022 at 03:39:09PM +0800, Rahul Tanwar wrote:
> Use latest available pr_lvl() instead of older printk(KERN_LVL)
> Just a upgrade of print utilities usage no functional changes.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
> ---
> arch/x86/kernel/devicetree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
> index 5cd51f25f446..fcc6f1b7818f 100644
> --- a/arch/x86/kernel/devicetree.c
> +++ b/arch/x86/kernel/devicetree.c
> @@ -248,7 +248,7 @@ static void __init dtb_add_ioapic(struct device_node *dn)
>
> ret = of_address_to_resource(dn, 0, &r);
> if (ret) {
> - printk(KERN_ERR "Can't obtain address from device node %pOF.\n", dn);
> + pr_err("Can't obtain address from device node %pOF.\n", dn);
> return;
> }
> mp_register_ioapic(++ioapic_id, r.start, gsi_top, &cfg);
> @@ -265,7 +265,7 @@ static void __init dtb_ioapic_setup(void)
> of_ioapic = 1;
> return;
> }
> - printk(KERN_ERR "Error: No information about IO-APIC in OF.\n");
> + pr_err("Error: No information about IO-APIC in OF.\n");
> }
> #else
> static void __init dtb_ioapic_setup(void) {}
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-11-22 9:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 7:39 [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support Rahul Tanwar
2022-11-22 7:39 ` [PATCH v3 1/4] x86/of: Convert Intel's APIC bindings to YAML schema Rahul Tanwar
2022-11-22 9:10 ` Andy Shevchenko
2022-11-22 9:43 ` Rahul Tanwar
2022-11-22 10:09 ` Andy Shevchenko
2022-11-22 10:37 ` Rahul Tanwar
2022-11-23 16:02 ` Krzysztof Kozlowski
2022-11-23 17:24 ` Andy Shevchenko
2022-11-24 8:33 ` Rahul Tanwar
2022-11-22 7:39 ` [PATCH v3 2/4] x86/of: Introduce new optional bool property for lapic Rahul Tanwar
2022-11-22 7:39 ` [PATCH v3 3/4] x86/of: Replace printk(KERN_LVL) with pr_lvl() Rahul Tanwar
2022-11-22 9:14 ` Andy Shevchenko [this message]
2022-11-22 7:39 ` [PATCH v3 4/4] x86/of: Add support for boot time interrupt delivery mode configuration Rahul Tanwar
2022-11-22 9:14 ` Andy Shevchenko
2022-11-22 9:45 ` Rahul Tanwar
2022-11-22 10:10 ` Andy Shevchenko
2022-11-22 9:17 ` [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support Andy Shevchenko
2022-11-22 9:49 ` Rahul Tanwar
2022-11-22 10:14 ` Andy Shevchenko
2022-11-22 10:45 ` Rahul Tanwar
2022-11-22 12:42 ` Andy Shevchenko
2022-11-23 9:52 ` Rahul Tanwar
2022-11-23 13:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3yTB7mGOPm3rFfb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lgm-soc@maxlinear.com \
--cc=mingo@redhat.com \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®