mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rahul Tanwar <rtanwar@maxlinear.com>
To: <bigeasy@linutronix.de>, <robh@kernel.org>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <x86@kernel.org>,
	<hpa@zytor.com>
Cc: <andriy.shevchenko@linux.intel.com>,
	<dave.hansen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-lgm-soc@maxlinear.com>,
	Rahul Tanwar <rtanwar@maxlinear.com>
Subject: [PATCH v3 4/4] x86/of: Add support for boot time interrupt delivery mode configuration
Date: Tue, 22 Nov 2022 15:39:10 +0800	[thread overview]
Message-ID: <c62b81d5b91514e905d97e37feff6920f598e0ac.1669100394.git.rtanwar@maxlinear.com> (raw)
In-Reply-To: <cover.1669100394.git.rtanwar@maxlinear.com>

Presently, init/boot time interrupt delivery mode is enumerated
only for ACPI enabled systems by parsing MADT table or for older
systems by parsing MP table. But for OF based x86 systems, it is
assumed & hardcoded to legacy PIC mode. This is a bug for
platforms which are OF based but do not use 8259 compliant legacy
PIC interrupt controller. Such platforms can not even boot because
of this bug/hardcoding.

Fix this bug by adding support for configuration of init time
interrupt delivery mode for x86 OF based systems by introducing a
new optional boolean property 'intel,virtual-wire-mode' for
interrupt-controller node of local APIC. This property emulates
IMCRP Bit 7 of MP feature info byte 2 of MP floating pointer
structure.

Defaults to legacy PIC mode if absent. Configures it to virtual
wire compatibility mode if present.

Fixes: 3879a6f32948 ("x86: dtb: Add early parsing of IO_APIC")
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
---
 arch/x86/kernel/devicetree.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/devicetree.c b/arch/x86/kernel/devicetree.c
index fcc6f1b7818f..458e43490414 100644
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -167,7 +167,14 @@ static void __init dtb_lapic_setup(void)
 			return;
 	}
 	smp_found_config = 1;
-	pic_mode = 1;
+	if (of_property_read_bool(dn, "intel,virtual-wire-mode")) {
+		pr_info("Virtual Wire compatibility mode.\n");
+		pic_mode = 0;
+	} else {
+		pr_info("IMCR and PIC compatibility mode.\n");
+		pic_mode = 1;
+	}
+
 	register_lapic_address(lapic_addr);
 }
 
-- 
2.17.1


  parent reply	other threads:[~2022-11-22  7:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  7:39 [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support Rahul Tanwar
2022-11-22  7:39 ` [PATCH v3 1/4] x86/of: Convert Intel's APIC bindings to YAML schema Rahul Tanwar
2022-11-22  9:10   ` Andy Shevchenko
2022-11-22  9:43     ` Rahul Tanwar
2022-11-22 10:09       ` Andy Shevchenko
2022-11-22 10:37         ` Rahul Tanwar
2022-11-23 16:02   ` Krzysztof Kozlowski
2022-11-23 17:24     ` Andy Shevchenko
2022-11-24  8:33     ` Rahul Tanwar
2022-11-22  7:39 ` [PATCH v3 2/4] x86/of: Introduce new optional bool property for lapic Rahul Tanwar
2022-11-22  7:39 ` [PATCH v3 3/4] x86/of: Replace printk(KERN_LVL) with pr_lvl() Rahul Tanwar
2022-11-22  9:14   ` Andy Shevchenko
2022-11-22  7:39 ` Rahul Tanwar [this message]
2022-11-22  9:14   ` [PATCH v3 4/4] x86/of: Add support for boot time interrupt delivery mode configuration Andy Shevchenko
2022-11-22  9:45     ` Rahul Tanwar
2022-11-22 10:10       ` Andy Shevchenko
2022-11-22  9:17 ` [PATCH v3 0/4] x86/of: Fix a bug in x86 arch OF support Andy Shevchenko
2022-11-22  9:49   ` Rahul Tanwar
2022-11-22 10:14     ` Andy Shevchenko
2022-11-22 10:45       ` Rahul Tanwar
2022-11-22 12:42         ` Andy Shevchenko
2022-11-23  9:52           ` Rahul Tanwar
2022-11-23 13:47             ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c62b81d5b91514e905d97e37feff6920f598e0ac.1669100394.git.rtanwar@maxlinear.com \
    --to=rtanwar@maxlinear.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-lgm-soc@maxlinear.com \
    --cc=mingo@redhat.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®