[PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[Andy Shevchenko]

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove these assignment all at once.

For the details one may look into the of_gpio_dev_init() implementation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/regulator/rpi-panel-attiny-regulator.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/rpi-panel-attiny-regulator.c b/drivers/regulator/rpi-panel-attiny-regulator.c
index f7df0f4b2f87..fa8706a352ce 100644
--- a/drivers/regulator/rpi-panel-attiny-regulator.c
+++ b/drivers/regulator/rpi-panel-attiny-regulator.c
@@ -364,7 +364,6 @@ static int attiny_i2c_probe(struct i2c_client *i2c,
 	state->gc.parent = &i2c->dev;
 	state->gc.label = i2c->name;
 	state->gc.owner = THIS_MODULE;
-	state->gc.of_node = i2c->dev.of_node;
 	state->gc.base = -1;
 	state->gc.ngpio = NUM_GPIO;
 
-- 
2.35.1

Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[Andy Shevchenko]

On Fri, Mar 25, 2022 at 08:45:08PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
> 
> For the details one may look into the of_gpio_dev_init() implementation.

Any comments on this? Can it be applied now?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On Wed, Apr 06, 2022 at 04:01:41PM +0300, Andy Shevchenko wrote:
> On Fri, Mar 25, 2022 at 08:45:08PM +0200, Andy Shevchenko wrote:
> > GPIO library does copy the of_node from the parent device of
> > the GPIO chip, there is no need to repeat this in the individual
> > drivers. Remove these assignment all at once.
> > 
> > For the details one may look into the of_gpio_dev_init() implementation.
> 
> Any comments on this? Can it be applied now?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[Andy Shevchenko]

On Wed, Apr 06, 2022 at 02:13:09PM +0100, Mark Brown wrote:
> On Wed, Apr 06, 2022 at 04:01:41PM +0300, Andy Shevchenko wrote:
> > On Fri, Mar 25, 2022 at 08:45:08PM +0200, Andy Shevchenko wrote:
> > > GPIO library does copy the of_node from the parent device of
> > > the GPIO chip, there is no need to repeat this in the individual
> > > drivers. Remove these assignment all at once.
> > > 
> > > For the details one may look into the of_gpio_dev_init() implementation.
> > 
> > Any comments on this? Can it be applied now?
> 
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so 
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.

Oops, indeed, it has been only 12 days passed with no nothing :-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment

[Mark Brown]

On Fri, 25 Mar 2022 20:45:08 +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove these assignment all at once.
> 
> For the details one may look into the of_gpio_dev_init() implementation.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator/rpi-panel-attiny: Get rid of duplicate of_node assignment
      commit: 4917e54997b0c5fbf39a3bd574802a16fa705096

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark