* [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
@ 2021-01-20 9:01 Lad Prabhakar
2021-01-20 9:21 ` Jacopo Mondi
2021-01-20 10:17 ` Kieran Bingham
0 siblings, 2 replies; 7+ messages in thread
From: Lad Prabhakar @ 2021-01-20 9:01 UTC (permalink / raw)
To: Sakari Ailus, Mauro Carvalho Chehab, Laurent Pinchart,
Jacopo Mondi, linux-media
Cc: linux-kernel, Biju Das, Prabhakar
Fix OV772x build breakage by selecting V4L2_FWNODE config:
ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/media/i2c/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index eddb10220953..bb1b5a340431 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -1013,6 +1013,7 @@ config VIDEO_OV772X
tristate "OmniVision OV772x sensor support"
depends on I2C && VIDEO_V4L2
select REGMAP_SCCB
+ select V4L2_FWNODE
help
This is a Video4Linux2 sensor driver for the OmniVision
OV772x camera.
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 9:01 [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor Lad Prabhakar
@ 2021-01-20 9:21 ` Jacopo Mondi
2021-01-20 10:17 ` Kieran Bingham
1 sibling, 0 replies; 7+ messages in thread
From: Jacopo Mondi @ 2021-01-20 9:21 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Sakari Ailus, Mauro Carvalho Chehab, Laurent Pinchart,
Jacopo Mondi, linux-media, linux-kernel, Biju Das, Prabhakar
Hi Prabhakar,
On Wed, Jan 20, 2021 at 09:01:48AM +0000, Lad Prabhakar wrote:
> Fix OV772x build breakage by selecting V4L2_FWNODE config:
>
> ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
>
> Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
You beat me to it, I was about to hit send for the same patch :)
Thanks!
Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index eddb10220953..bb1b5a340431 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> tristate "OmniVision OV772x sensor support"
> depends on I2C && VIDEO_V4L2
> select REGMAP_SCCB
> + select V4L2_FWNODE
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV772x camera.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 9:01 [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor Lad Prabhakar
2021-01-20 9:21 ` Jacopo Mondi
@ 2021-01-20 10:17 ` Kieran Bingham
2021-01-20 10:36 ` Sakari Ailus
1 sibling, 1 reply; 7+ messages in thread
From: Kieran Bingham @ 2021-01-20 10:17 UTC (permalink / raw)
To: Lad Prabhakar, Sakari Ailus, Mauro Carvalho Chehab,
Laurent Pinchart, Jacopo Mondi, linux-media
Cc: linux-kernel, Biju Das, Prabhakar
Hi Lad,
On 20/01/2021 09:01, Lad Prabhakar wrote:
> Fix OV772x build breakage by selecting V4L2_FWNODE config:
>
> ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
>
> Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
I see this driver uses subdev API too.
Should the driver also select VIDEO_V4L2_SUBDEV_API?
Or is that covered sufficiently already on any platforms that would use
the driver?
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index eddb10220953..bb1b5a340431 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> tristate "OmniVision OV772x sensor support"
> depends on I2C && VIDEO_V4L2
> select REGMAP_SCCB
> + select V4L2_FWNODE
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV772x camera.
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 10:17 ` Kieran Bingham
@ 2021-01-20 10:36 ` Sakari Ailus
2021-01-20 11:08 ` Lad, Prabhakar
2021-01-20 11:09 ` Kieran Bingham
0 siblings, 2 replies; 7+ messages in thread
From: Sakari Ailus @ 2021-01-20 10:36 UTC (permalink / raw)
To: Kieran Bingham
Cc: Lad Prabhakar, Mauro Carvalho Chehab, Laurent Pinchart,
Jacopo Mondi, linux-media, linux-kernel, Biju Das, Prabhakar
On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
> Hi Lad,
>
> On 20/01/2021 09:01, Lad Prabhakar wrote:
> > Fix OV772x build breakage by selecting V4L2_FWNODE config:
> >
> > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> >
> > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> I see this driver uses subdev API too.
>
> Should the driver also select VIDEO_V4L2_SUBDEV_API?
Yes, it should. Another patch? This one fixes a compilation problem.
>
> Or is that covered sufficiently already on any platforms that would use
> the driver?
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> > ---
> > drivers/media/i2c/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > index eddb10220953..bb1b5a340431 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> > tristate "OmniVision OV772x sensor support"
> > depends on I2C && VIDEO_V4L2
> > select REGMAP_SCCB
> > + select V4L2_FWNODE
> > help
> > This is a Video4Linux2 sensor driver for the OmniVision
> > OV772x camera.
> >
>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 10:36 ` Sakari Ailus
@ 2021-01-20 11:08 ` Lad, Prabhakar
2021-01-20 11:09 ` Kieran Bingham
1 sibling, 0 replies; 7+ messages in thread
From: Lad, Prabhakar @ 2021-01-20 11:08 UTC (permalink / raw)
To: Sakari Ailus, Kieran Bingham
Cc: Lad Prabhakar, Mauro Carvalho Chehab, Laurent Pinchart,
Jacopo Mondi, linux-media, LKML, Biju Das
Hi Sakari and Kieran,
On Wed, Jan 20, 2021 at 10:36 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
> > Hi Lad,
> >
> > On 20/01/2021 09:01, Lad Prabhakar wrote:
> > > Fix OV772x build breakage by selecting V4L2_FWNODE config:
> > >
> > > ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> > > ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > > ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> > > ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> > >
> > > Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > I see this driver uses subdev API too.
> >
> > Should the driver also select VIDEO_V4L2_SUBDEV_API?
>
> Yes, it should. Another patch? This one fixes a compilation problem.
>
Do agree, I will post an incremental patch on top of this.
Cheers,
Prabhakar
> >
> > Or is that covered sufficiently already on any platforms that would use
> > the driver?
> >
> > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >
> > > ---
> > > drivers/media/i2c/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > > index eddb10220953..bb1b5a340431 100644
> > > --- a/drivers/media/i2c/Kconfig
> > > +++ b/drivers/media/i2c/Kconfig
> > > @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> > > tristate "OmniVision OV772x sensor support"
> > > depends on I2C && VIDEO_V4L2
> > > select REGMAP_SCCB
> > > + select V4L2_FWNODE
> > > help
> > > This is a Video4Linux2 sensor driver for the OmniVision
> > > OV772x camera.
> > >
> >
>
> --
> Sakari Ailus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 10:36 ` Sakari Ailus
2021-01-20 11:08 ` Lad, Prabhakar
@ 2021-01-20 11:09 ` Kieran Bingham
2021-01-20 11:13 ` Lad, Prabhakar
1 sibling, 1 reply; 7+ messages in thread
From: Kieran Bingham @ 2021-01-20 11:09 UTC (permalink / raw)
To: Sakari Ailus
Cc: Lad Prabhakar, Mauro Carvalho Chehab, Laurent Pinchart,
Jacopo Mondi, linux-media, linux-kernel, Biju Das, Prabhakar
On 20/01/2021 10:36, Sakari Ailus wrote:
> On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
>> Hi Lad,
>>
>> On 20/01/2021 09:01, Lad Prabhakar wrote:
>>> Fix OV772x build breakage by selecting V4L2_FWNODE config:
>>>
>>> ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
>>> ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
>>> ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
>>> ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
>>>
>>> Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>>
>> I see this driver uses subdev API too.
>>
>> Should the driver also select VIDEO_V4L2_SUBDEV_API?
>
> Yes, it should. Another patch? This one fixes a compilation problem.
Yes, it's probably another patch, because indeed this is a specific fix.
I wonder if that means the builders haven't been able to construct a
combination without VIDEO_V4L2_SUBDEV_API...
--
Kieran
>> Or is that covered sufficiently already on any platforms that would use
>> the driver?
>>
>> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>>
>>> ---
>>> drivers/media/i2c/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
>>> index eddb10220953..bb1b5a340431 100644
>>> --- a/drivers/media/i2c/Kconfig
>>> +++ b/drivers/media/i2c/Kconfig
>>> @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
>>> tristate "OmniVision OV772x sensor support"
>>> depends on I2C && VIDEO_V4L2
>>> select REGMAP_SCCB
>>> + select V4L2_FWNODE
>>> help
>>> This is a Video4Linux2 sensor driver for the OmniVision
>>> OV772x camera.
>>>
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor
2021-01-20 11:09 ` Kieran Bingham
@ 2021-01-20 11:13 ` Lad, Prabhakar
0 siblings, 0 replies; 7+ messages in thread
From: Lad, Prabhakar @ 2021-01-20 11:13 UTC (permalink / raw)
To: Kieran Bingham
Cc: Sakari Ailus, Lad Prabhakar, Mauro Carvalho Chehab,
Laurent Pinchart, Jacopo Mondi, linux-media, LKML, Biju Das
On Wed, Jan 20, 2021 at 11:09 AM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
>
> On 20/01/2021 10:36, Sakari Ailus wrote:
> > On Wed, Jan 20, 2021 at 10:17:14AM +0000, Kieran Bingham wrote:
> >> Hi Lad,
> >>
> >> On 20/01/2021 09:01, Lad Prabhakar wrote:
> >>> Fix OV772x build breakage by selecting V4L2_FWNODE config:
> >>>
> >>> ia64-linux-ld: drivers/media/i2c/ov772x.o: in function `ov772x_probe':
> >>> ov772x.c:(.text+0x1ee2): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> >>> ia64-linux-ld: ov772x.c:(.text+0x1f12): undefined reference to `v4l2_fwnode_endpoint_free'
> >>> ia64-linux-ld: ov772x.c:(.text+0x2212): undefined reference to `v4l2_fwnode_endpoint_alloc_parse'
> >>>
> >>> Fixes: 8a10b4e3601e ("media: i2c: ov772x: Parse endpoint properties")
> >>> Reported-by: kernel test robot <lkp@intel.com>
> >>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >>
> >> I see this driver uses subdev API too.
> >>
> >> Should the driver also select VIDEO_V4L2_SUBDEV_API?
> >
> > Yes, it should. Another patch? This one fixes a compilation problem.
>
> Yes, it's probably another patch, because indeed this is a specific fix.
>
> I wonder if that means the builders haven't been able to construct a
> combination without VIDEO_V4L2_SUBDEV_API...
>
Thats because v4l2-subdev.o is built irrespective of
VIDEO_V4L2_SUBDEV_API enabled/disabled and there are empty fillers in
v4l2-subdev.c when VIDEO_V4L2_SUBDEV_API is disabled.
Cheers,
Prabhakar
> --
> Kieran
>
>
> >> Or is that covered sufficiently already on any platforms that would use
> >> the driver?
> >>
> >> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> >>
> >>> ---
> >>> drivers/media/i2c/Kconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> >>> index eddb10220953..bb1b5a340431 100644
> >>> --- a/drivers/media/i2c/Kconfig
> >>> +++ b/drivers/media/i2c/Kconfig
> >>> @@ -1013,6 +1013,7 @@ config VIDEO_OV772X
> >>> tristate "OmniVision OV772x sensor support"
> >>> depends on I2C && VIDEO_V4L2
> >>> select REGMAP_SCCB
> >>> + select V4L2_FWNODE
> >>> help
> >>> This is a Video4Linux2 sensor driver for the OmniVision
> >>> OV772x camera.
> >>>
> >>
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-20 12:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 9:01 [PATCH] media: i2c/Kconfig: Select FWNODE for OV772x sensor Lad Prabhakar
2021-01-20 9:21 ` Jacopo Mondi
2021-01-20 10:17 ` Kieran Bingham
2021-01-20 10:36 ` Sakari Ailus
2021-01-20 11:08 ` Lad, Prabhakar
2021-01-20 11:09 ` Kieran Bingham
2021-01-20 11:13 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®